Time Nick Message 05:38 NikolayGospodinov[m] Good morning Koha! I want to ask or way to do the following thing. When pressing the edit button, a certain tag from the MARCH frame to be duplicated. 05:58 marcelr o/ 06:08 ashimema paulderscheid++ setting out the tasks to reinvigorate the website :-) 06:14 marcelr hi ashimema 06:15 marcelr get a bit distracted by the perltidy thing 06:21 marcelr seems to me that we need a bit more communication about whats happening in qa tools 06:21 marcelr things are just pushed and announced afterwards etc 06:22 marcelr really motivating 06:29 marcelr is there a way to perltidy a file based on a diff ? 06:30 marcelr these things should be done automatically 07:26 ashimema That's a good idea marcelr 07:27 ashimema I think we discussed perltidy at a Dev meeting.. but I do agree, we're not great at communicating at the moment 07:27 marcelr well at least an idea 07:27 marcelr the communication is very poor 07:28 ashimema I'd love to see a global tidy at some point... But it would cause havoc with existing submissions 07:28 marcelr we cant refuse devs now that were written already 07:28 marcelr some even a long time ago 07:28 ashimema I love caits QA emails. 07:28 marcelr since enh takes ages to get in 07:29 ashimema Thought I must admit, I sometimes struggle to keep on top of email 07:29 ashimema Indeed 07:29 marcelr i am having a lot of pending patches now waiting for SO or QA too 07:30 marcelr simple test stuff waiting for 2 months etc 07:30 marcelr and now they will be rejected on perltidy ;) 07:30 ashimema Sorry dude, I wish I was less swamped so I could do more so and qa 07:31 marcelr koha frustration channel :) 07:31 ashimema I think the perltidy stuff needs a little human consideration still.. ;) 07:31 marcelr right 07:32 ashimema We have an internal Dev meeting this afternoon.. I'll be reminding the guys that SO is part of their role still ;) 07:32 ashimema They're a great team.. but also juggling a lot for me 07:32 marcelr great 07:33 ashimema I'm keen to get Pedro into QA at some time too. Help spread that load 07:33 ashimema Oop, school run time 07:47 marcelr i need qa on bug 33608 people 07:47 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 enhancement, P5 - low, ---, m.de.rooy, Signed Off , Allow to get statistics about found/recovered books 08:00 cait hello #koha 08:01 marcelr hi cait 08:06 cait ashimema: glad to hear, sometimes not sure if people are reading them ;) 08:07 cait I did run the QA tools but if it was only a one line change i dint' enforce the tidy, all were bug fixes too 08:07 cait we for sure need to be on the same page with our RM - we don't want to cause more work or rejects 08:07 cait I thik if a whole new file is added perltidy makes sense for older devs too 08:07 cait for partial changes it's a bit of a grey area 08:08 cait but no need to add new files untidied 08:12 cait ... an automated script woudl be great (just read back) 08:12 cait might be a solved issue somewhere even? 08:13 ashimema I always read them, though I might be a few days behind.. I'd love to act on them more.. I do use them to pick bugs when I have time to QA 08:14 ashimema Perltidy can tidy between markers.. so we should be able to do something 08:15 ashimema I also wonder if we could use splitter or similar to identify all files without patches outstanding and tidy those in one sweep 08:15 ashimema not sure how many files are in such a state though. 08:26 aw-bib[m] hello! a pretty basic question. I just staged records for import, marcxml, utf-8. The job has been enqueued! It will be processed as soon as possible. 0% not started in yellow. What does Koha try to tell me here? IOW why does it not start the job? I see it in the job list, but it sits there. (and it is not a large job, just a few sample records.) 08:30 MatthewBlenkinsop[m] Which version are you running on? I think there was an issue with this on one of the earlier versions of 22.11 08:30 aw-bib[m] 23.05 08:32 cait it might just take a while, not suer how reliable the progess bar is 08:33 cait but it's not started still? hm 08:33 cait we had that happen during our koha lab... 08:33 cait a restart of koha-common fixed it temporarily as some backgroudn job was not running 08:33 MatthewBlenkinsop[m] I just tested staging a file and it worked fine - a restart is probably the best first step as cait suggests 08:34 cait it did work on one instance not on others, it was something with the background processes (it was no fun) 08:34 aw-bib[m] nope. still sitting there. is there some kind of log somehwere I cook peek? 08:34 cait maybe another question: when you go to about koha = does it show rabbitmq as running? 08:34 aw-bib[m] I could go back ot an older koha if that helps. (then a hint on whic one would benice.) 08:35 aw-bib[m] ok, checking for rabbit. just a second. 08:35 cait I think 23.05 is a good choice 08:35 cait the problems where with 22.11.05 etc. 08:35 cait did it work before with MARCXML? I sometimes had problems, usually I convert to mrc 08:36 aw-bib[m] â rabbitmq-server.service - RabbitMQ Messaging Server 08:36 aw-bib[m] Loaded: loaded (/lib/systemd/system/rabbitmq-server.service; enabled; vendor preset: enabled) 08:36 aw-bib[m] Active: active (running) since Fri 2023-07-14 10:13:12 CEST; 22min ago 08:37 aw-bib[m] as for the marcxml I could try to recode. I think I used the same xml on oldoldstable. does it tell me somewhere if she is unhappy? 08:37 aw-bib[m] e.g. some sort of validation. 08:40 marcelr ashimema: i assume that most code still is not tidy in the queues and that is understandable; we should enforce from now on 08:41 ashimema indeed 08:41 marcelr we could add follow-ups on new files 08:42 marcelr MatthewBlenkinsop[m]++ # SO 08:44 cait PedroAmorim++ # bug 34256 08:44 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34256 normal, P5 - low, ---, pedro.amorim, Needs Signoff , Patron search: search for borrowernumber starts with fails 08:44 cait thx for the prompt reaction 08:44 cait I am updating mx dev env, then diving in 08:44 cait aw-bib[m]: best for validating is MARCedit 08:44 cait koah doesn't really validate 08:45 ashimema Nice work Pedro 08:45 cait but it shoudl still start and maybe fail - I am not sure why it is stuck 08:45 cait someone else an idea maybe? 08:45 ashimema it's so easy for things to creep in during rebases âšī¸ 08:45 ashimema makes it incredibly difficult having such a fast moving project 08:58 cait can someone have a look at an update issue? bug 34276 08:58 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34276 enhancement, P5 - low, ---, jonathan.druart+koha, NEW , upgrading 23.05 to 23.05.002 09:03 cait aw-bib[m]: any luck yet? 09:03 cait there shoudl be 2 processes for the rabbit... but I don't know my way aroudn there well enough yet 09:03 aw-bib[m] destructive interference by a meeting. I'll come back to you. 09:04 cait aw-bib[m]: maybe look for kidclamp later too - he has been working on the import and rabbit issues 09:04 cait PedroAmorim[m]: commit title.. ;) 09:05 cait you missed "Bug " :) 09:05 PedroAmorim[m] I'll fixed it 09:05 PedroAmorim[m] sorry, my mind is a bit all over the palce 09:05 cait no need 09:05 cait I am on it already 09:05 PedroAmorim[m] đī¸ 09:06 PedroAmorim[m] * I'll fix it 09:06 PedroAmorim[m] s/palce/place/ 09:06 cait still no need heh 09:06 cait unless the patch doesn't work :P 09:06 marcelr thats the problem with patches in general 09:06 marcelr sometimes they dont work 09:07 cait also had a couple patches with no test plans - it really takes a lot longer ot udnertand the goals 09:07 cait or make up some complicated circ config 09:08 cait I have left some comments about that on other bugs 09:10 marcelr interruption battery 09:10 marcelr no test plan is common or architecture stuff 09:11 marcelr not saying that it is good bw 09:11 marcelr btw 09:11 cait yeah, but was not on architecture bugs 09:11 marcelr ok 09:11 cait and the architecture ones shoudl have at least soem good description/reasoning then 09:12 aw-bib[m] @cait I'll watch out for kidclamp. . o O ( installing mono to get marcedit working ;) 09:12 huginn aw-bib[m]: I suck 09:12 cait ah Linux, yes, hope ti works 09:12 cait I have windows on my work computer, that makes it a little easier (and a remote with Linux) 09:14 cait ashimema: I'll look at bug 34269 next 09:14 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 major, P5 - low, ---, martin.renvoize, Needs Signoff , Regression in circulation rules for 'similar' patron categories 09:16 cait ashimema: you have missing qa test tools too lol 09:17 cait I'll also fix... TT filters 09:18 cait ... and no test plan. Can someone remind me how the grouping for circulation rules works? 09:19 ashimema oh... 09:20 ashimema I use the qa script that's embedding inside ktd 09:20 cait I am nto sure the patch is right 09:20 ashimema not sure how I missed stuff then 09:20 cait i think you forgot to run it - it's old checks on TT filters 09:20 ashimema it certainly needs thorough testing.. it's a 'thrown together' state 09:20 cait + itm_code = $(this).data('code'); 09:20 cait + itm_text = $(this).text(); 09:20 cait + itm_text = itm_text.replace(/^\s*|\s*$/g,''); 09:20 cait you don't use item_code 09:20 cait you use the old regex... or do I miss soemthing? 09:20 ashimema you miss something đ 09:21 ashimema it's the nested loops 09:21 cait that's good 09:21 ashimema we still use text for the non-select fields 09:22 ashimema we only switch to code for the select options comparison stuff 09:22 ashimema which is around line 191 09:22 cait do you mean selected and unselected? 09:22 ashimema 1491 even 09:22 ashimema yeah 09:22 ashimema that bit 09:22 cait ok,.. still struggling a little bit remembering hwo this is upposed to work 09:22 cait we don't use that yet 09:22 ashimema as in drop down list vs text input box cait 09:22 ashimema yeah.. it's not the most intuitive of code 09:23 aw-bib[m] @cait marcedit works but I am out of luck there to. so it seems not format related. 09:23 huginn aw-bib[m]: I've exhausted my database of quotes 09:23 cait aw-bib[m]: I was afraid it might not be :( 09:23 cait did you load through the GUI? 09:24 cait ashimema: any idea how to make a stuck rabbit task moving? 09:25 aw-bib[m] cait yes, via the gui. stage for import select marcxml biblio utf8 and then also for marc. even tried both marc formats (text and binary) always the same thing I get the yellow bar at 0 and in the job list Isee now 3 jobs enqueued. restarting the rabbit didn't help either. hm. 09:26 cait yeah, we had the exact same problem int he workshop :( 09:26 cait i was really hoping it was resolved by now 09:26 cait there were quite some patches pushed around the MARC import and Rabbit 09:26 cait kidclamp: ? 09:26 cait might still be a bit early for him 09:26 aw-bib[m] ok, good to know. then I assume that I didn't screw anything on my end for the time being. 09:27 cait I think if it didn't like the file it would ay "failed" 09:27 cait what status doe sit have now? 09:27 aw-bib[m] would those patches end up in the packages for koha already? or should I apply something beyond apt? 09:27 cait there are also command line scripts.. bulkmarcimport as a faster laoder for migration and stage and commit cli scripts that mimick what the tools do 09:27 aw-bib[m] the joblist says Staged MARC records for import Status New Progress null/0 09:28 cait no they shoudl be there 09:28 aw-bib[m] ok, maybe I'll give them a try and watch out if they tell me anything. 09:29 cait ashimema: I am trying to make sense of it from the test plan from bug 30517 09:29 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517 normal, P5 - low, ---, shi-yao.wang, RESOLVED FIXED, Translation breaks editing parent type circulation rule 09:36 ashimema yeah.. I struggled to work out a test plan in my fuzzy brain end of yesterday 09:36 ashimema I can help work through it.. just managed to close off most of the other chats that bombarded me for the last 20 mins 09:38 aw-bib[m] wow. this bulkmarkimport-tool even comes with an extensive --help. :) 09:38 ashimema beware bulkmarcimport and stage_file + commit_file seem to fall out of sync feature wise 09:39 ashimema We tend to stick to bulkmarcimport for initial migrations, big one time imports here at ptfs-e and use stage + commit for regular ongoing things.. just to guide around the use cases and their designs aw-bib 09:40 aw-bib[m] great! thanks for those pointers! 09:40 aw-bib[m] ( did someone recently mention that this is a really great group here? ) 09:41 ashimema aww, shucks 09:46 cait we love to hear it :) 09:46 cait but I feel the same, Koha people are good people 09:48 ashimema many are perhaps a little over stretched.. but we all actively want to help out and do things đ 09:58 cait was there a post about KohaCon programme to the ML yet? 10:05 cait ashimema: I believe your patchw orks 10:05 ashimema đ 10:06 marcelr bug 33745 is very promising 10:06 cait SO 10:06 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33745 enhancement, P5 - low, ---, glasklas, Passed QA , Speed up Koha::Object attribute accessors 10:06 marcelr cool benchmarking numbers 10:07 cait bbl after lunch 10:07 marcelr PedroAmorim[m]++ 10:11 ashimema that code is really interesting marcelr 10:11 ashimema david is doing some great work 10:11 marcelr certainly 10:12 marcelr From 437ms to 54ms is great 10:12 marcelr Factor 8 10:12 ashimema that's a huge improvement 10:12 jpahd[m] This is awesome 10:12 ashimema it'll really add up.. it's such a low level area 10:12 jpahd[m] One of the pain points of Koha::Objects for me 10:13 ashimema totaly 10:13 marcelr htg thx everybody 10:20 kidclamp Cait: our import issues turned out to be related to plugins. We had plugins that added new objects. They did this by reloading the schema, which made a new db connection, and lost the transaction 10:54 ashimema cait still around? 10:56 ashimema I found another bug in circ rule matrix editing 11:11 cait kidclamp: on the workshop instances were no plugins installed :( 11:12 cait kidclamp: so I don't think that was it, also aw-bib[m] - do you have plugins yet? 11:17 cait ashimema: noooo 11:17 ashimema I think it's long standing.. I tried it in master and it's there too 11:18 ashimema if you click edit on one line.. then edit again on another.. then again on another... at some point we seem to loose track and stop updating the edit boxes properly.. basically it goes out of sync 11:18 cait huh 11:18 ashimema however.. as it's never been mentioned I'm inclined to quietly step away and pretend I've not noticed it đ 11:18 cait sometimes... that's ok 11:19 cait don't cite me 11:19 cait might ruin my reputation ;) 11:19 ashimema I have a feeling it's the sort of thing that would only be done by someone manically testing something like what I just wrote đ 11:19 cait ah marcelr is already gone 11:19 ashimema in real life I think it's unlikely a librarian would do such a convoluted route 11:21 * ashimema is manically re-basing bugs today.. man there's a lot of them 11:21 ashimema will be soo happy once 30979 hits 11:21 cait bug 30797 11:21 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30797 normal, P5 - low, ---, alexbuckley, CLOSED FIXED, Subfields linked to the dateaccessioned.pl value builder on addbiblio.pl throw a JS error 11:22 cait this one? 11:22 wahanui hmmm... this one is on oleonard 11:25 ashimema nope 11:26 ashimema bug 30979 11:26 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 enhancement, P5 - low, ---, martin.renvoize, Passed QA , Add ability for OPAC users to checkout to themselves 11:26 ashimema it's been PQA for months 11:26 ashimema but needs... another rebase 11:29 aw-bib[m] cait: kidclamp: no plugins on my box I am aware of. it is a straight forward `apt install koha-common mariadb-server`. 11:29 aw-bib[m] I did mess with installer and onboarding by just loading the files using `populate_db`. could I have missed something there? 11:29 kidclamp it's just not the same problem I saw then 11:30 cait but any idea where to start looking when they get stuck? 11:30 kidclamp tail all the logs, any errors? if not you just have to start tracing code 11:31 cait (11:27:59) aw-bib[m]: the joblist says Staged MARC records for import Status New Progress null/0 11:31 kidclamp what version? 11:31 wahanui version is very stable and translation is great 11:31 aw-bib[m] 4 New null/0 Staged MARC records for import 14/07/2023 11:07 its what it tells me. v23.05 (stable according to apt.) 11:33 aw-bib[m] could you give me a pointer to the logs? 11:33 aw-bib[m] iow where does koha put them? 11:33 cait tail -f /var/log/koha/instance?/*.log 11:34 aw-bib[m] thx. start checking them. 11:38 tcohen hola #koha o/ 11:40 cait hola tcohen 11:40 * ashimema doesn't know how to get bug 33997 moving 11:40 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 minor, P5 - low, ---, matt.blenkinsop, Failed QA , Borrowers.updated_on should not be updated by track_login 11:40 ashimema we seem to be at an empass 11:40 aw-bib[m] hm, all logs show a size of 0 exccpt 11:40 aw-bib[m] - `indeer-error.log` complaining `koha_l00koha.zebraqueue' doesn't exist` (which stems from the clean install I guess. looks like zebra tried to run before the db was filled) 11:40 aw-bib[m] - `intranet-error.log` that gives `AH01215: Problem = a value of 1 has been passed to param without key` (referer: http://l00koha.desy.de:8080/cgi-bin/koha/tools/viewlog.pl) 11:41 ashimema in reality.. what I really want is bug 15504 11:41 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 enhancement, P1 - high, ---, matt.blenkinsop, Signed Off , Track Patron's Last Activity 11:43 cait khall++ were you reading my mind? looking at bug 34279 now :) 11:43 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34279 major, P5 - low, ---, kyle, Needs Signoff , overduefinescap of 0 is ignored, but overduefinescap of 0.00 is enforced 11:43 khall đ 11:44 cait hm there is a duplicate of this bug 11:44 cait in old versions you could just leave it epty 11:44 cait wouldn#t that be clearer than 0? 11:45 cait the problme is, if you edit an "old" rule with empty, it now sets them to 0.00 - people don't notice and end up with non-working fines 11:45 cait we have empty = unlimited for the checkouts, it would be more logical I think 11:56 cait hm I tried to explain and I tested your patch: bug 34279 11:56 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34279 major, P5 - low, ---, kyle, RESOLVED DUPLICATE, overduefinescap of 0 is ignored, but overduefinescap of 0.00 is enforced 11:58 aw-bib[m] cait: kidclamp if I use the cli like:... (full message at <https://matrix.org/_matrix/media/v3/download/matrix.org/lTvoBlhdDgYimKnsnGNHAzfD>) 11:58 khall cait I would recommend both bugs be pushed. Bug 34279 fixes it at the surface level, but bug 34279 fixes it at the root. Do you disagree? 12:00 khall my patch doesn't change the value of the rule, it makes it so "0" and "0.00" behave the same way 12:02 cait hm 12:02 cait i just wonder if that is something people understand 12:02 cait leaving empty for unlimited seems much more logical to me 12:02 khall then we need to enforce a cap for "0" as well 12:02 khall either way, we can't have "0" and "0.00" behave differently 12:02 cait i thik that's what heppans right now 12:03 cait agreed, I misunderstood you there and you are right 12:03 cait i think you can't really enter 0 via the GUI right now, but it could still happen in other weays 12:03 khall if you think both should be enforced, I will modify my patches 12:03 cait so the question is now if 0/0.00 shoudl block overdue calculation or not? 12:03 khall that is correct 12:04 cait what do you think? if we allowed leaving empty again, what>'s the most obvious to users? 12:04 cait I'd really love to see this fixed - it's one of my major update headaches 12:05 cait I am taking a second look at the other bug 12:08 cait khall: i have the same werror, our comments just overlapped :( 12:08 khall bug 32271 would also be FQA if it weren't set to NEW 12:08 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32271 major, P5 - low, ---, geraud.frappier, NEW , Overdue fines cap (amount) set to 0.00 when editing rule 12:08 khall đ 12:10 cait can we resolve this somehow? I am not sure if the original author will fix, there has been no interaction for a while since I have been watching and commenting there 12:11 cait ashimema: is that error maybe due to our changes for monetary? so that empty throws an exception? 12:11 khall cait, I'm going to make this argument for my bug and patches. Koha has always ignored a cap of 0. Now, we have many libraries with caps of "0.00" after created/editing rules 12:11 cait it#s a very valid argument 12:11 khall without my patches, those libraries won't have the bug fixed without editing all their rules 12:11 cait I still want the empty back heh 12:11 khall cait, I would agree with that too 12:11 cait yes, I think we can go with your bug, but can you please fix the commit message? 12:11 cait description and test plan? 12:11 khall let's get mine in and we can fix the UI in a followup bug 12:11 khall can do! 12:12 cait i already deduplicated them 12:12 khall what needs to change about the description? 12:13 cait there was none :) 12:13 cait both patches just have a subject 12:13 khall heh, just noticed that đ 12:14 khall was just too excited fixing the bug! 12:14 cait and i got excited seeing overdues cap heh 12:14 cait PedroAmorim[m]: are you still around? 12:14 PedroAmorim[m] in a call atm 12:14 PedroAmorim[m] and lunch after that, but I'm here 12:14 cait was pondering to go back to our ILL bug? but might need help with the setup/testing gui wise 12:15 PedroAmorim[m] I'll be available in an hour's time? maybe a bit before that! 12:15 cait that#s alreight, I will wait for Kyle's new patch and start setting up the ILL branch meanwhile 12:16 cait PedroAmorim[m]: quick question - use remote branch or patches on the bug? 12:17 cait oh, you told me in your last comment. forget I asked :) 12:17 PedroAmorim[m] remote branch would be more advisable I think! 12:17 PedroAmorim[m] it's just the patches in the bug with follow-ups on top of it 12:17 cait yep, setting that up now 12:17 khall cait fresh patches are up! 12:18 cait khall: next thing on the list :) 12:18 khall đ 12:25 khall cait, another interesting weirdsy. I jumped back to 22.05.00 and found if you set overduefinescap to 0, it blanks it, but if you put in 0.00 it shows 0.00. Nothing actionable but something to note if we pursue bug 32271 in the future 12:25 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32271 major, P5 - low, ---, geraud.frappier, NEW , Overdue fines cap (amount) set to 0.00 when editing rule 12:26 cait but it's another proof that empty and 0 were treated equivalently 12:37 cait khall: please remember to tidy your code now :) 12:37 cait for new patches we won't get it past RM otherwiese 12:37 cait the updates QA tools show it 12:37 khall heh đ 12:38 tcohen MatthewBlenkinsop[m], Joubu : can someone looks at the Cypress failures in master? 12:38 cait WARN t/db_dependent/Circulation/CalcFine.t 12:38 cait WARN tidiness 12:38 cait The file is less tidy than before (bad/messy lines before: 53, now: 65) 12:38 khall hmm, I *did* tidy it! I guess it considers more lines to always be less tidy? 12:39 khall tidy broke it up into multiple lines 12:39 tcohen I've pushed something from khall yesterday, that had the tidiness check error 12:39 cait that I cannot say... maybe the whole block? 12:39 tcohen but I found that 12:39 tcohen khall changed a few lines, that were tidy on their own, but not in the context 12:39 khall interesting 12:39 tcohen so it is hard! because I should ask to tidy the whole block, but we don't want that 12:40 cait so what do we do? i cannot check it by viewing the code 12:40 khall I vote we perltidy the entire codebase, then re-tidy it as part of CI/CD with each push 12:40 tcohen it was about my $var = something; 12:40 tcohen not having all the = aligned 12:40 khall we considered it many years ago, but it was voted down because we didn't know that git blame could ignore whitespace changes 12:40 cait khall: ther problem was that it might cause bad bad rebase issues with all the stuff waiting 12:40 khall cait that is a much better reason not to 12:40 cait I think it also breaks lines differently, so not only whitespace 12:41 cait but maybe the whol block or so woudl be ok? 12:41 khall iirc I was working on something with bz-splitter to find any files that didn't have open patches. That was so long ago though 12:41 cait that#s what ashimema suggested earlier actually 12:41 khall cait tcohen should I tidy the outer block? 12:41 cait tidy all files with no waiting patches 12:41 cait and maybe we could repeat that a few times 12:42 khall I'm 100% in favor of that! 12:42 cait I am referring to tcohen, as he just send the email yestrday :) 12:42 * khall is always head in the clouds, out of the loop ;) 12:42 cait and we could maybe make it a blocker in QA tests for new files and a warn for existing 12:43 cait it's nice down here too sometimes :) 12:43 cait I'll work on the actual testing while we wait for tcohen's decree 12:44 aw-bib[m] cait: kidclamp after playing with the `bulkmarcimporter` I can now also confirm that `stage_file` and `commit_file` work well from the backend. Only if I initiate it from the web it gets stuck. This problem persists. If I can be of any help to hunt this down... (I don't know koha well enough to have an idea about the difference between the two submission methods.) 12:45 cait hm khall - are you using the new perltidy file? 12:45 paulderscheid[m] Does anyone use perlnavigator in neovim or vscode? 12:45 khall cait I presume so. I think perltidy checks the directory you are in first. Then again, I'm tidying from inside vim so I have no idea how it behaves 12:46 cait i meant the koha specific perltidy file 12:46 cait because it complains about the new test syou added and that'a ctually a nice block of code 12:46 cait I am trying to see if me perltidying it makes a difference 12:47 khall ah, I didn't tidy that one! I just did a copy/paste/modify 12:47 cait ok, trying a fix 12:47 cait i need to practice that too 12:48 ashimema I've dabbled with perlnavigator in vscode paulderscheid 12:48 ashimema I never got it working in vim.. 12:48 cait I'll amend your patch if that's ok 12:48 ashimema well.. I don't think I got it working in vim 12:48 cait was jsut the tidy 12:48 ashimema I can't honestly remember 12:48 khall cait, go for it! 12:48 ashimema have you played with dev containers in vscode paulderscheid ? 12:48 paulderscheid[m] A little 12:49 cait khall: qa tools green now, ti was only a few spaces 12:49 khall đ 12:49 ashimema we're currently investigating whether we could somehow use ktd as a dev container to have all the perl deps and plugins working nicely in vscode without having to mess with the host 12:49 paulderscheid[m] That's exactly my problem w/ perlnavigator right now :D 12:49 ashimema if it's something your interested in, we're deffo also working in that space 12:50 ashimema so.. i got it working here.. but that's because I installed koha-perldeps on my host 12:50 ashimema that's not an ideal solution 12:50 ashimema at least.. i think that's how I had it working.. 12:50 paulderscheid[m] Yeah, that is the one thing I don't want 12:50 paulderscheid[m] But if you're on the host, there might be no other way 12:50 tcohen perlnavigator? 12:51 paulderscheid[m] Yeah 12:51 ashimema it's the current recommended language server based plugin for deving perl in vscode and friends 12:52 tcohen ah, is a new packaging for the LanguageServer? 12:52 ashimema autocompletion, syntax highlighting, inline perldoc support etc 12:52 ashimema I think 12:52 paulderscheid[m] It's the best one, I think. The Richter thing is terribly documented. 12:52 ashimema https://marketplace.visualstudio.com/items?itemName=bscan.perlnavigator 12:54 tcohen no mention of remote operation 12:54 ashimema dev containers does that bit I believe 12:55 MatthewBlenkinsop[m] <tcohen> "Matthew Blenkinsop, Joubu..." <- Looking now 12:56 paulderscheid[m] I just want to be able to 'go to definition' ^^ 12:56 ashimema such a nice feature I've been missing for ages đ 12:56 ashimema we should deffo have a guide for this on the wiki once someone works it out 12:57 paulderscheid[m] I need to. I'll try to set something up. If you do it first I'll gladly steal it. :D 12:57 tcohen I can jump to definitions using the plain Perl extension 12:59 tcohen https://metacpan.org/pod/Perl::LanguageServer 12:59 paulderscheid[m] Which extension are you using? 12:59 cait khall: signed off 12:59 khall thanks cait! 13:00 tcohen paulderscheid[m]: it doesn't jump to things not on your host... you are right about that 13:00 paulderscheid[m] Yes, but that's what I want. 13:00 tcohen https://marketplace.visualstudio.com/items?itemName=cfgweb.vscode-perl 13:00 paulderscheid[m] I want to be able to even jump to every dependency 13:00 tcohen you could, if it was available on your host machine 13:00 tcohen that's the problem 13:01 tcohen ashimema: I'm not sure what's dev container 13:01 tcohen but Perl::LanguageServer allows remote file mappings 13:01 tcohen so 13:01 tcohen and remote debugging 13:01 tcohen not just language syntax and analysis 13:02 tcohen I didn't know about perlnavigator at alll 13:02 tcohen so will start looking 13:03 tcohen https://github.com/richterger/Perl-LanguageServer/issues/35 13:04 oleonard o/ 13:04 tcohen hi oleonard 13:04 wahanui hi oleopard 13:04 oleonard Y'all have been busy today! 13:06 cait we just make it look like it 13:06 cait :) 13:06 oleonard Okay, maybe y'all have just been NOISY :D 13:07 ashimema talk for yourself cait.. I've got LOADS done today đ 13:08 cait :P 13:08 cait PedroAmorim[m]: I have issues witht he database update on the ILL bug, please check (noted on the bug too) 13:09 khall cait I added a followup to 32271 to get it moving too 13:09 cait I will check in a moment - thank you! 13:13 cait khall: how shoudl it be have now? 13:14 PedroAmorim[m] cait: checking now, thanks! 13:15 khall cait I'm not sure I understand you last sentence! 13:16 cait I was not sure waht I shoudl see in the editor with your patch 13:20 cait khall: it looks like it works well :) 13:20 cait it turns 0 and 0.00 into empty too... but taht's actually nicely consistent I think 13:35 khall cait: yes, I agree! If 0/0.00 do nothing, let's just show them as blank to the librarians 13:37 cait I commented as such on the bug :) 13:38 cait now... if only we had someone to QA these 2 bugs... *cough* 13:39 tcohen <.< 14:38 ashimema which two cait 14:38 * ashimema should really not allow himself to get distracted.. it's already 4pm and I'm meant to have a booking sandbox up and running before the end of the day 14:40 cait ashimema: so you are maybe not the one for those today 14:40 cait but I was talking about bug 32271 and bug 34279 14:40 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32271 major, P5 - low, ---, geraud.frappier, Signed Off , Overdue fines cap (amount) set to 0.00 when editing rule 14:40 huginn 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34279 major, P5 - low, ---, kyle, Signed Off , overduefinescap of 0 is ignored, but overduefinescap of 0.00 is enforced 14:51 * oleonard is also here 14:57 oleonard ashimema: still around? 14:57 ashimema yup 14:58 oleonard How did your Windows-user make out with ktd? Any luck? 14:58 ashimema Yeah, they're using it happily now đ 14:58 oleonard I'm on my Windows machine today so I was thinking about it 14:58 ashimema Alexander Blanchard: ^ 14:59 ashimema don't know whether he's in the habbit of paying attention here yet 14:59 ashimema but we got over all the little hurdles and I think he was going to feedback into the documentation 14:59 oleonard That's great 15:00 ashimema we're going through the motions with a few more in company too to make sure it's solid 15:00 ashimema ktd is awesome 15:00 oleonard It really makes things so much easier. Virtualbox was a pain in the ass 15:01 * ashimema goes back to getting this bookings sandbox up.. on a deadline I'm afraid 15:02 ashimema can master stop moving for 5 minutes please.. haha.. I can't keep up 15:02 cait you guys always complain... 15:02 cait either it's we're moving too slow or too fast.. 15:03 ashimema hehe 15:03 * oleonard never complains, I am a perfect angel 15:03 ashimema Koha is amazing really.. 15:13 cait I'll remind you :) 15:40 oleonard I'm getting "Cannnot open file No such file or directory at /kohadevbox/misc4dev/cp_debian_files.pl line 35." when I try ktd on Windows :( 15:40 cait oh no 16:01 kidclamp ashimema++ 16:06 cait have a nice weekend all! 16:07 aw-bib[m] same to you :-) 16:08 cait aw-bib[m]: just found your ealrier message - bulkmarcimport I think doesn't use the task queue yet, so that this works means the data is ok 16:08 cait interesting woud be if you get an error with the stage command line script - that's the same code I believe than the gui tools 16:09 cait just another thought... I woudl like to knwo what's going on there! 18:11 tcohen cait++ 18:11 tcohen ashimema++ 18:11 tcohen kidclamp++ 18:44 ashimema tcohen++ 18:47 cait tcohen++ 19:47 caroline is anyone still around? I have an somewhat off-topic question 19:48 * cait waves 19:51 tcohen \o 19:51 tcohen shoot caroline 19:53 cait nooo don't shoot caroline! 19:55 caroline please! 19:55 caroline tcohen, I was looking for (informal) feedback on the streaming part of Kohacon... if there was something good to do or annonying not to repeat 20:03 h2h2 waves! I always enjoy tuning into KohaCon--I've never found anything annoying! I always learn something new! 20:04 caroline I thought last year the setup was pretty seamless from the room point of view 20:04 caroline Jason did a good job 20:04 caroline but I wasn't online, so I don't know what it looked like/felt like 20:06 h2h2 I was online for almost all of it--it was very seamless from my perspective! Jason did (and does) a great job! 20:09 h2h2 I've seen a couple different approaches to hybrid conferences that I think work well--during breaks, one way is to have something playing to the remote audience like a "we're on break" slide, and another is just keeping the live view of the room on--I think both work well. 20:11 caroline kohacon20 was my first and only online conf, and I thought they had done a really good job too 20:13 h2h2 I had attended some online "unconferences" before then, & the technology has come a long way--it got much better from 2020 onwards! 20:15 caroline necessity does tend to accelerate innovation... 20:16 h2h2 Yes, indeed!! 20:42 h2h2 See y'all next time! Bye!