IRC log for #koha, 2022-04-21

All times shown according to UTC.

Time S Nick Message
00:12 AndrewFH joined #koha
00:27 fridolin joined #koha
05:55 lds joined #koha
06:11 fridolin joined #koha
06:38 marcelr joined #koha
06:38 marcelr hi #koha
06:43 huginn News from kohagit: Bug 28786: add Auth::GoogleAuth module to cpanfile <https://git.koha-community.org[…]5171d100e7b9d2cc9>
06:43 huginn News from kohagit: Bug 28786: DBRev 21.12.00.036 <https://git.koha-community.org[…]689f41291e05e5bc9>
06:43 huginn News from kohagit: Bug 28786: (follow-up) Improve style of 2FA code input <https://git.koha-community.org[…]e742840a5609aca86>
06:43 huginn News from kohagit: Bug 30204: Add unit test <https://git.koha-community.org[…]50135c0de07c201f9>
06:43 huginn News from kohagit: Bug 28786: DBIC schema changes <https://git.koha-community.org[…]b2eb3bd7dd7f9bad2>
06:43 huginn News from kohagit: Bug 30205: Add subtitle to subscription detail page <https://git.koha-community.org[…]b2f317dd04203ebbc>
06:43 huginn News from kohagit: Bug 30204: Add subtitle to serial search results <https://git.koha-community.org[…]a3c0a9b76f9ac25b1>
06:43 huginn News from kohagit: Bug 28786: Don't expose secret and auth_method to the REST API <https://git.koha-community.org[…]0a4336adab516004d>
06:43 huginn News from kohagit: Bug 28786: (QA follow-up) Check the returned CSRF token <https://git.koha-community.org[…]10a86e7c8f243a3a5>
06:43 huginn News from kohagit: Bug 28786: (QA follow-up) Do not call generate_secret32 <https://git.koha-community.org[…]520916d436ad7ed2c>
06:43 huginn News from kohagit: Bug 28786: (QA follow-up) Fix qa warnings <https://git.koha-community.org[…]31e6799258311f687>
06:43 huginn News from kohagit: Bug 28786: (QA follow-up) Upgrade atomicupdate to new style <https://git.koha-community.org[…]b9bc4c0f3d3769008>
06:43 huginn News from kohagit: Bug 28786: Add tests for checkauth <https://git.koha-community.org[…]d3f81cfb6151aa859>
06:43 huginn News from kohagit: Bug 28786: Correctly inherit from Auth::GoogleAuth <https://git.koha-community.org[…]bca08b1afb546df62>
06:43 huginn News from kohagit: Bug 28786: Improve readability in C4::Auth::checkauth <https://git.koha-community.org[…]0088cfd58500d0e67>
06:43 huginn News from kohagit: Bug 28786: Two-factor authentication for staff client - TOTP <https://git.koha-community.org[…]a60f5ae2a0283e761>
06:43 huginn News from kohagit: Bug 28786: Add new DB column borrowers.auth_method <https://git.koha-community.org[…]e1d5c4b7e194b1702>
06:43 huginn News from kohagit: Bug 28786: Add controller script and template <https://git.koha-community.org[…]048f5c7763d5b32ad>
06:43 huginn News from kohagit: Bug 28786: Add new DB column borrowers.secret <https://git.koha-community.org[…]89998c94268077cc1>
06:44 huginn News from kohagit: Bug 28786: Add new syspref TwoFactorAuthentication <https://git.koha-community.org[…]9a5ec41c155b0daa0>
06:44 reiveune joined #koha
06:44 reiveune hello
06:44 marcelr fridolin++ # 2FA is in
06:45 marcelr still three follow-up patch sets need attention
06:46 marcelr bug 29873 needs SO
06:46 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=29873 enhancement, P5 - low, ---, m.de.rooy, Needs Signoff , 2FA: Generate QR code without exposing secret via HTTP GET
06:47 koha-jenkins Project Koha_Master_D9 build #1929: FAILURE in 3 min 0 sec: https://jenkins.koha-community[…]a_Master_D9/1929/
06:47 koha-jenkins Project Koha_Master_U20 build #368: FAILURE in 3 min 33 sec: https://jenkins.koha-community[…]a_Master_U20/368/
06:48 fridolin marcelr: yep i pushed it fast so no need to rebase anymore
06:48 fridolin looks like fun feature
06:50 koha-jenkins Project Koha_Master build #1985: FAILURE in 5 min 50 sec: https://jenkins.koha-community[…]Koha_Master/1985/
06:51 koha-jenkins Project Koha_Master_D11_My8 build #798: FAILURE in 3 min 2 sec: https://jenkins.koha-community[…]ster_D11_My8/798/
06:51 koha-jenkins Project Koha_Master_Sid build #14: FAILURE in 3 min 47 sec: https://jenkins.koha-community[…]ha_Master_Sid/14/
06:51 marcelr and another signoff needed on bug 29894
06:51 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=29894 enhancement, P5 - low, ---, m.de.rooy, Needs Signoff , 2FA: Add few validations, clear secret, send register notice
06:51 koha-jenkins Project Koha_Master_D10 build #600: FAILURE in 6 min 44 sec: https://jenkins.koha-community[…]a_Master_D10/600/
06:52 koha-jenkins Project Koha_Master_D11_MDB_Latest build #866: FAILURE in 5 min 39 sec: https://jenkins.koha-community[…]1_MDB_Latest/866/
06:54 koha-jenkins Project Koha_Master_D10 build #601: STILL FAILING in 3 min 34 sec: https://jenkins.koha-community[…]a_Master_D10/601/
06:54 koha-jenkins Project Koha_Master_U22 build #20: FAILURE in 2 min 52 sec: https://jenkins.koha-community[…]ha_Master_U22/20/
06:54 koha-jenkins Project Koha_Master_U21 build #148: FAILURE in 4 min 53 sec: https://jenkins.koha-community[…]a_Master_U21/148/
06:55 koha-jenkins Project Koha_Master_U_Stable build #439: FAILURE in 3 min 38 sec: https://jenkins.koha-community[…]ter_U_Stable/439/
06:55 koha-jenkins Project Koha_Master_U_Stable build #440: STILL FAILING in 2 min 57 sec: https://jenkins.koha-community[…]ter_U_Stable/440/
06:56 ashimema morning #koha
06:56 MarkHofstetter1 joined #koha
06:57 koha-jenkins Project Koha_Master_U22 build #21: STILL FAILING in 2 min 58 sec: https://jenkins.koha-community[…]ha_Master_U22/21/
06:58 ashimema fridolin
06:58 wahanui fridolin is RM for 22.05
06:58 ashimema still around?
06:58 koha-jenkins Project Koha_Master_D11_MDB_Latest build #867: STILL FAILING in 3 min 25 sec: https://jenkins.koha-community[…]1_MDB_Latest/867/
06:59 ashimema I wish you'd just pushed my follow-up on bug 29602 instead of rolling your own
06:59 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=29602 enhancement, P5 - low, ---, fridolin.somers, Pushed to master , We must be nicer with translators
06:59 ashimema you've effectively reverted a fix by rolling your own I believe
07:01 koha-jenkins Project Koha_Master_D12 build #128: FAILURE in 6 min 10 sec: https://jenkins.koha-community[…]a_Master_D12/128/
07:07 nikkom joined #koha
07:10 ashimema oh, I see.
07:10 ashimema no, yours is better I think
07:10 ashimema 🙂
07:13 alexbuckley joined #koha
07:15 fridolin ashimema: thanks a lot for your patch
07:16 ashimema no worries
07:16 ashimema yours was nicer on reflection
07:16 fridolin i was pushing other stuff
07:16 ashimema as was your second one to fix the filter issue
07:16 ashimema 🙂
07:16 fridolin to much span seems odd
07:16 alohabot 🎁 🦄 Koha 'master' packages pushed to 'koha-staging' repo  🥬🥪🍕
07:16 * ashimema is currently trying to work out why Jenkins exploded on that last push
07:16 ashimema it aint happy at all
07:17 fridolin ashimema: jenkins broken because new perl dep
07:17 fridolin it is in cpanfile
07:17 ashimema ah, I see
07:17 ashimema coolios
07:17 fridolin but needs to be added to KTD right ?
07:18 ashimema maybe
07:18 ashimema koha-staging may have just fixed it.. I can't remember how that stuff fits together these days
07:23 mtj hi fridolin, i made a small fix to 28786
07:24 mtj https://bugs.koha-community.or[…]cgi?id=28786#c150
07:24 huginn Bug 28786: enhancement, P5 - low, ---, jonathan.druart+koha, Pushed to master , Two-factor authentication for staff client - TOTP
07:24 mtj i think we are ok to reduce version to 1.02 for d9/d10 and friends
07:25 ashimema I concur
07:25 ashimema doesn't look like any functionality changed.. just the tests and documentation improvements
07:27 huginn News from kohagit: Bug 28786: decrease Auth::GoogleAuth version to 1.02 <https://git.koha-community.org[…]7dd56b7c6c6b48b13>
07:27 fridolin pushed
07:27 ashimema 🙂
07:27 * ashimema loves a quick fix
07:29 fridolin same for me  :D
07:30 mtj thanks, pkgs are building
07:31 ashimema those latest builds will all fail too right.. waiting for packages to complete first
07:31 koha-jenkins Project Koha_Master_D11_My8 build #799: STILL FAILING in 3 min 13 sec: https://jenkins.koha-community[…]ster_D11_My8/799/
07:31 * ashimema really is out of date on how our jenkins workflow all fits together these days
07:31 koha-jenkins Project Koha_Master_U21 build #149: STILL FAILING in 3 min 39 sec: https://jenkins.koha-community[…]a_Master_U21/149/
07:32 koha-jenkins Project Koha_Master_D9 build #1930: STILL FAILING in 2 min 50 sec: https://jenkins.koha-community[…]a_Master_D9/1930/
07:32 koha-jenkins Project Koha_Master_U20 build #369: STILL FAILING in 2 min 50 sec: https://jenkins.koha-community[…]a_Master_U20/369/
07:32 ashimema I 'think' the changes stuff might be failing because we drop the workspace/build data all the time now maybe btw..
07:33 ashimema it feels like Jenkins has no record of the last commit it built somehow so can't display the commits since
07:33 ashimema pass
07:33 koha-jenkins Project Koha_Master_D12 build #129: STILL FAILING in 2 min 27 sec: https://jenkins.koha-community[…]a_Master_D12/129/
07:35 koha-jenkins Project Koha_Master build #1986: STILL FAILING in 6 min 45 sec: https://jenkins.koha-community[…]Koha_Master/1986/
07:36 koha-jenkins Project Koha_Master_U_Stable build #441: STILL FAILING in 3 min 2 sec: https://jenkins.koha-community[…]ter_U_Stable/441/
07:37 koha-jenkins Project Koha_Master_D10 build #602: STILL FAILING in 5 min 16 sec: https://jenkins.koha-community[…]a_Master_D10/602/
07:37 koha-jenkins Project Koha_Master_D11_MDB_Latest build #868: STILL FAILING in 5 min 46 sec: https://jenkins.koha-community[…]1_MDB_Latest/868/
07:38 marcelr joined #koha
07:38 koha-jenkins Project Koha_Master_U22 build #22: STILL FAILING in 3 min 34 sec: https://jenkins.koha-community[…]ha_Master_U22/22/
07:41 koha-jenkins Project Koha_Master_Sid build #15: STILL FAILING in 5 min 34 sec: https://jenkins.koha-community[…]ha_Master_Sid/15/
07:41 mtj ashimema: i noticed this recently.. https://jenkins.koha-community[…]ha_Master/changes
07:41 koha-jenkins Project Koha_Master_Sid build #16: STILL FAILING in 3 min 49 sec: https://jenkins.koha-community[…]ha_Master_Sid/16/
07:41 koha-jenkins Project Koha_Master_D10 build #603: STILL FAILING in 4 min 52 sec: https://jenkins.koha-community[…]a_Master_D10/603/
07:41 koha-jenkins Project Koha_Master_D11_MDB_Latest build #869: STILL FAILING in 4 min 8 sec: https://jenkins.koha-community[…]1_MDB_Latest/869/
07:43 alohabot 🎁 🦄 Koha 'master' packages pushed to 'koha-staging' repo  🍏🍪🍙
08:03 mtj hmm ashimema: i think we are missing the 'changelog' extension for the git plugin..
08:03 mtj https://plugins.jenkins.io/git[…]ngelog-extensions
08:08 mtj ive enabled for koha_master build, fingers xrossed
08:20 Joubu hi #koha
08:22 fridolin left #koha
08:24 marcelr joined #koha
08:28 ashimema oh, thanks mtj
08:28 ashimema hi Joubu, long time no see.
08:32 koha-jenkins Project Koha_Master_D9 build #1931: NOW UNSTABLE in 40 min: https://jenkins.koha-community[…]a_Master_D9/1931/
08:32 koha-jenkins Project Koha_Master build #1987: NOW UNSTABLE in 38 min: https://jenkins.koha-community[…]Koha_Master/1987/
08:43 marcelr ashimema: any chance to SO on 29873/29894 ?
08:43 marcelr small 2FA refinements
08:43 ashimema certainly
08:43 ashimema 2FA was top of my list to play with today 🙂
08:43 marcelr cool
08:52 ashimema thanks for working through that marcelr
08:52 marcelr np
08:53 marcelr afk for a bit now
08:53 koha-jenkins Project Koha_Master_D10 build #604: NOW UNSTABLE in 43 min: https://jenkins.koha-community[…]a_Master_D10/604/
08:58 matts joined #koha
09:00 davidnind joined #koha
09:24 ashimema our patron search autocomplete code is really weird
09:32 Joubu mtj: should we start again all the jobs for master?
09:35 mtj hi Joubu, i thik they will all fail, so no need
09:35 mtj DBD::mysql::st execute failed: Data truncated for column 'auth_method' at row 1 at /kohadevbox/koha/Koha/Object.pm line 170
09:35 nlegrand Hello #koha
09:36 Joubu yes, noticed that, I am on it right now
09:37 ashimema good to have you back Joubu
09:37 Joubu o/
09:38 Joubu it's a bug in TestBuilder
09:41 mtj ahh, in _gen_default_values() sub
09:43 Joubu nope
09:43 Joubu actually it's something else
09:43 Joubu see last patch on bug 28786
09:43 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=28786 enhancement, P5 - low, ---, jonathan.druart+koha, Pushed to master , Two-factor authentication for staff client - TOTP
09:45 koha-jenkins Project Koha_Master build #1988: STILL UNSTABLE in 1 hr 4 min: https://jenkins.koha-community[…]Koha_Master/1988/
09:45 mtj Joubu++ well spotted
09:45 Joubu should I push it now?
09:46 Joubu or ashimema maybe, if you have a minute to review it?
09:50 ashimema sure
09:50 ashimema might pick your brains on patron search after though if that's OK
09:50 ashimema I'm baffled
09:51 mtj Joubu: patch looks good to mee
09:51 ashimema yup me too
09:51 Joubu what's the problem with the patron search, ashimema?
09:51 ashimema I'll push
09:51 ashimema nothings wrong with it.. I just don't understand something
09:51 ashimema will ask in a tick
09:52 ashimema it's on my middle_name bug
09:52 ashimema bug 21978
09:52 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=21978 enhancement, P5 - low, ---, martin.renvoize, Failed QA , Add middle name field
09:52 ashimema I'm not understanding how the standard search fields stuff gets put together
09:55 ashimema right.. that's that pushed 🙂
09:55 huginn News from kohagit: Bug 28786: Don't set auth_method to NULL in ->anonymize <https://git.koha-community.org[…]e0ea9297e58082da7>
09:56 * ashimema also wants to drop circ/ysearch.pl
09:56 ashimema and the plethora of near duplicate autocomplete js methods we have
10:03 oleonard If you're getting in there ashimema you can replace jQueryUI autocomplete while you're at it ;)
10:04 ashimema how does replacing it with select2 sound?
10:04 ashimema I have that already in a few places
10:05 oleonard I'd never thought of that... seems like a logical place to start
10:05 ashimema I used it in the bookings work that never made the light of day
10:05 oleonard I'd played with another JS library, but fewer dependencies are good
10:05 ashimema it's nice
10:06 ashimema though I'm not 100% sure how it will play with the our existing autocomplete UX
10:06 ashimema select2 is really for select boxes.. our autocomplete stuff kinda acts like a weird middle place
10:06 oleonard This is what I tried, by the way: https://tarekraafat.github.io/autoComplete.js
10:06 ashimema producing a select from a search box
10:16 alohabot 🎁 🦄 Koha 'master' packages pushed to 'koha-staging' repo  🍅🍎🧁
10:17 oleonard ashimema: Yeah that might be a deal-breaker
10:17 ashimema indeed
10:17 ashimema I've not really given it a great deal of thought yet
10:18 ashimema still trying to work out what on earth is going on with my middle_name patch
10:20 Joubu ashimema: what's the problem?
10:20 wahanui the problem is probably time travel hasn't been invented.
10:20 ashimema I added middle_name to the default search fields
10:21 ashimema but instead of searching on them it falls back to just searching on surname
10:22 ashimema the guts of my change are here: https://gitlab.com/mrenvoize/K[…]2f8fadb53df0e9f2a
10:23 * ashimema is thinking he'll split the autocomplete stuff out into it's own patch.... there's way more autocompletes duplicated all over the shop than I thought so it makes this commit messy and confusing
10:25 cait joined #koha
10:25 * cait waves
10:27 oleonard Hi cait
10:27 davidnind left #koha
10:28 oleonard cait do you know anything about how serial collection might show up in the OPAC?
10:28 oleonard opac-detail.tt has a tab for it but I don't know when it shows up
10:29 cait i think it had a note to only work for UNIMARC at some point
10:29 cait I don't knwo what it woudl look like, maybe check with Frido/tuxayo if they might know about an example?
10:30 khall joined #koha
10:33 oleonard Okay thanks
10:33 cait oleonard: it should relate to the opacSerialDefaultTab    syspref I think
10:34 oleonard Oh yeah that's where the note about UNIMARC is
10:35 cait :)
10:36 oleonard It's odd, the code in opac-detail.pl looks like it tries to accommodate both MARC and UNIMARC
10:36 cait hm maybe it got broken at some point - the note has been there forever
10:37 khall_ joined #koha
10:38 * oleonard is very curious about the 4 libraries reporting that they use LibraryThing for Libraries...
10:38 * oleonard would take it out of Koha just to spite LibraryThing...
10:40 cait what did they do?
10:40 oleonard Their leader badmouthed Koha on Twitter a few years ago and I hold grudges
10:42 cait I see, I think i remember - the OPAC one?
10:42 koha-jenkins Project Koha_Master_D10 build #605: STILL UNSTABLE in 47 min: https://jenkins.koha-community[…]a_Master_D10/605/
10:42 AndrewFH joined #koha
10:43 marcelr joined #koha
10:43 marcelr o/
10:43 tcohen \o
10:45 ashimema mm, he's not the nicest chap
10:49 oleonard Anyway.... My OPAC tabs patch will not have tested LTFL features
10:50 oleonard Similarly... Anyone know anything about OPACFRBRizeEditions being broken?
10:51 oleonard The "Editions" tab works in the staff interface but doesn't show up in the OPAC
10:51 cait hm strange
10:52 cait it's been a while since Itested that one for a demo and we are almost always a few versions back
10:52 koha-jenkins Project Koha_Master_D11_MDB_Latest build #870: NOW UNSTABLE in 55 min: https://jenkins.koha-community[…]1_MDB_Latest/870/
10:52 oleonard Oh wait... Now it's working!
10:52 oleonard It didn't work day before yesterday :|
10:52 koha-jenkins Project Koha_Master build #1989: STILL UNSTABLE in 1 hr 7 min: https://jenkins.koha-community[…]Koha_Master/1989/
10:53 cait it does still work in 20.11 - i just confirmed
10:53 cait ah
10:58 tcohen oleonard: don't forget to restart_all
10:58 tcohen :-P
10:59 oleonard 🤪
11:00 koha-jenkins Project Koha_Master_U_Stable build #442: NOW UNSTABLE in 1 hr 3 min: https://jenkins.koha-community[…]ter_U_Stable/442/
11:10 koha-jenkins Project Koha_Master_Sid build #17: NOW UNSTABLE in 36 min: https://jenkins.koha-community[…]ha_Master_Sid/17/
11:22 Joubu mtj, ashimema: still a problem with auth_method, I will a look in a bit
11:22 Joubu have*
11:29 koha-jenkins Project Koha_Master_U22 build #23: NOW UNSTABLE in 46 min: https://jenkins.koha-community[…]ha_Master_U22/23/
11:30 oleonard Bugzilla down
11:32 Joubu working here
11:32 oleonard Well NOW it is.
11:33 oleonard Joubu: Does your comment on Bug 29155 refer to Bootstrap?
11:33 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=29155 enhancement, P5 - low, ---, oleonard, Signed Off , Upgrade jquery version
11:35 Joubu oleonard: oops yes, sorry. I read "3.5.0" and assumed it was about bootstrap
11:39 oleonard Joubu: I don't suppose you've heard any news from Biblibre about the staff interface redesign?
11:40 Joubu not since the hackfest
11:47 koha-jenkins Project Koha_Master_D11_My8 build #800: NOW UNSTABLE in 55 min: https://jenkins.koha-community[…]ster_D11_My8/800/
11:48 koha-jenkins Project Koha_Master_U20 build #370: NOW UNSTABLE in 37 min: https://jenkins.koha-community[…]a_Master_U20/370/
11:49 koha-jenkins Project Koha_Master_U21 build #150: NOW UNSTABLE in 56 min: https://jenkins.koha-community[…]a_Master_U21/150/
11:58 marcelr joined #koha
11:59 khall joined #koha
12:04 marcelr Joubu: not sure whats problem in Import.t ?
12:04 marcelr it passes with me now
12:05 marcelr without your patch
12:05 koha-jenkins Project Koha_Master_D9 build #1932: STILL UNSTABLE in 1 hr 5 min: https://jenkins.koha-community[…]a_Master_D9/1932/
12:05 marcelr no wait depends on sql mode
12:13 koha-jenkins Project Koha_Master_D10 build #606: STILL UNSTABLE in 44 min: https://jenkins.koha-community[…]a_Master_D10/606/
12:19 oleonard Trying to test something in 21.05.13... "Can't load application from file "/kohadevbox/koha/api/v1/app.pl": Can't locate JSON/Validator/OpenAPI/Mojolicious.pm"
12:20 marcelr wondrous world of mojolicious and its deps
12:21 oleonard Where do I acquire this wonder
12:21 marcelr lets call tcohen
12:24 oleonard "Do not use this module directly. Use Mojolicious::Plugin::OpenAPI instead."
12:24 ashimema hehe.. yeah
12:24 oleonard "libmojolicious-plugin-openapi-perl set to manually installed."
12:24 ashimema we're a tad naughty
12:24 ashimema how are you running it right now oleonard
12:24 ashimema in k-t-d ?
12:24 marcelr we never read that far:)
12:25 oleonard k-t-d, trying to test v21.05.13
12:25 koha-jenkins Project Koha_Master_D12 build #130: NOW UNSTABLE in 37 min: https://jenkins.koha-community[…]a_Master_D12/130/
12:25 ashimema we switched versions recently.. I think you need a different version of the lib depending on the version of koha you have checked out..
12:25 ashimema there's a way to run up a k-t-d for each different branch version..
12:25 * ashimema tries to remember how
12:26 ashimema https://gitlab.com/koha-commun[…]equests/315/diffs
12:26 ashimema I think that explains it
12:27 oleonard So I have to start everything from scratch with the correct version of KTD
12:28 ashimema one sec.. just asking tcohen to dip in
12:28 oleonard He promised he would always be here for me... :(
12:29 ashimema did you already setup a bunch of test data and stuff?
12:29 ashimema we could probably downgrade the lib within the running k-t-d
12:29 ashimema cpanm Mojolicious::Plugin::OpenAPI@oldversion
12:30 magnuse__ joined #koha
12:31 tcohen hola
12:31 wahanui hi, tcohen
12:31 tcohen kd
12:31 tcohen export KOHA_IMAGE=21.05
12:31 tcohen kup
12:31 ashimema oleonard has a k-t-d already running at master level.. but has started to test a bug (so already setup test data and stuff I think)..
12:32 ashimema we can just downgrade the Mojolicious::Plugin::OpenAPI version inside the container so he can test right?
12:32 tcohen right
12:32 ashimema with `cpanm Mojolicious::Plugin::OpenAPI@2.16` and then restart_all
12:32 ashimema I think
12:32 tcohen we should provide a more flexible way to run several ktd at a time
12:32 * ashimema uses kul instead of ku or kup by default
12:33 ashimema that we should
12:33 ashimema though I can barely run one without running out of disk on this underspecced dev system of mine.. haha
12:33 tcohen alias kutl='cd ~/git/koha-testing-docker; docker compose -f docker-compose-light.yml -f docker-compose.es6.yml -f docker-compose.plugin.yml -p koha up'
12:33 tcohen that's the one I use
12:38 oleonard ashimema: Downgrading seems to have worked, thanks
12:38 ashimema glad I could help 🙂
12:38 * ashimema has made that mistake a few times
12:43 koha-jenkins Project Koha_Master_D11_My8 build #801: STILL UNSTABLE in 55 min: https://jenkins.koha-community[…]ster_D11_My8/801/
12:45 cait joined #koha
12:53 cait hm just translating, ashimema - didn#t we change that line in the acccount notice?
12:53 cait contact your Koha Administrator.
12:54 ashimema yes
12:54 ashimema I thought we did
12:54 cait it's in 21.11
12:55 ashimema no idea when things were pushed.. there was a gap between the first half of the tree and the second half
12:55 koha-jenkins Project Koha_Master build #1990: STILL UNSTABLE in 1 hr 5 min: https://jenkins.koha-community[…]Koha_Master/1990/
12:55 cait mostly asking because i wonder if a patch/bug was missed
12:56 kidclamp oleonard++
13:07 Joubu marcelr: have you seen bug 30532?
13:07 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=30532 critical, P1 - high, ---, koha-bugs, Needs Signoff , guided_reports.pl has a problem
13:07 marcelr no
13:07 Joubu khall: ^
13:08 Joubu khall: bug 30532 is blocker for 21.11
13:08 marcelr if no one else does, i look tomorrow
13:09 koha-jenkins Project Koha_Master_U21 build #151: STILL UNSTABLE in 1 hr 3 min: https://jenkins.koha-community[…]a_Master_U21/151/
13:09 marcelr Joubu i need a SO on the two followup reports of 2FA
13:10 marcelr 873/894
13:11 Joubu waiting for the QA step
13:13 marcelr ok i need to persuade martin
13:13 magnuse_ joined #koha
13:13 marcelr o/
13:14 Joubu kidclamp, lukeg can you ping khall please? I think he should not release 21.11.05 without 30532
13:15 ashimema bz is really slow today
13:15 cait bug 30532
13:15 wahanui i heard bug 30532 was blocker for 21.11
13:15 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=30532 blocker, P1 - high, ---, jonathan.druart+koha, Needs Signoff , guided_reports.pl has a problem
13:15 marcelr ashimema: gateway timeout
13:16 ashimema lol
13:16 ashimema marcelr.. I'm on those two right now.
13:16 ashimema just SO'd the fist
13:16 marcelr ok
13:16 marcelr great
13:16 ashimema sorry.. had to get something customer facing done this morning first 😉
13:16 marcelr logical
13:16 * cait is still on vacation, not really here
13:16 cait I'll be back next week
13:16 cait at least part time
13:16 marcelr ha cait do some qa its relaxing
13:16 * ashimema hasn't read the whole of the 2FA bug.. but wonders why we chose the module we did
13:16 marcelr or some signoffs
13:17 ashimema I had Authen::OATH for it in my head
13:17 cait just trying to catch up on soem mail is stressful already!
13:17 marcelr i remember that remark ashimema
13:17 marcelr you thought that before :)
13:17 khall Joubu what about bug 30525? That too?
13:17 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=30525 critical, P5 - low, ---, oleonard, Signed Off , Items batch modification broken
13:17 ashimema it's not really an issue.. they both do the same thing..
13:17 ashimema though I'm surprised by the need for this GD follow-up.. feels like a bug in the library we're using having to overload it 😉
13:18 ashimema I like modules that do one thing and one thing only
13:18 marcelr it is a vulnerability imo
13:18 ashimema I agree
13:18 marcelr it sends your secret with a GET to Google
13:18 ashimema I also have a level of trust for Olaf.. I've don't know Gryphon at all
13:19 marcelr and deprecated
13:19 ashimema yikes
13:19 ashimema so yeah.. not a great advert for the module
13:19 marcelr one day we will redo the whole thing lol
13:19 ashimema I should really read all the 2FA code again.. I'm glad it's pushed though.
13:19 ashimema haha
13:19 ashimema you guys did a great job seeing it through.
13:25 kidclamp would it be worth having a severity status  of 'performance' - like, they aren't bugs, but they aren't enhancements (i.e. they should be considered for backport)?
13:26 ashimema seems reasonable to me kidclamp
13:26 ashimema just remember things like that also affect the deshboard and stuff so need a little thought
13:26 * ashimema has made that mistake.
13:26 kidclamp I mena, without it I will just mark them all as 'normal'
13:26 Joubu khall: yes, 30525 is certainly one you will need for the release as well!
13:27 ashimema indeed
13:27 ashimema I do like having it distinct
13:27 ashimema I can add it for you kidclamp
13:27 kidclamp Joubu: should we merge those two into one?
13:29 Joubu kidclamp: we could, but the errors/fixes are different
13:30 tcohen hola Joubu !
13:30 Joubu tcohen: hola Tomas
13:38 ashimema marcelr.. my only negative thought on bug 29894 is the language used in the notice
13:38 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=29894 enhancement, P5 - low, ---, m.de.rooy, Needs Signoff , 2FA: Add few validations, clear secret, send register notice
13:38 ashimema is register/deregister the right term..
13:38 ashimema it feels like 'enable/disable' to me?
13:38 paxed joined #koha
13:38 ashimema other than that.. I like everything you've done here
13:38 * ashimema grabs tea
13:39 Joubu ashimema, tcohen why is bug 30536 blocking bug 30385? And not the reverse?
13:39 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=30536 enhancement, P5 - low, ---, martin.renvoize, Signed Off , Embeds should be defined in a single place
13:39 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=30385 enhancement, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Standardize our swagger yaml spec files
13:39 Joubu it's a mess to rebase, I won't spend more time on it
13:41 tcohen I don't remember
13:43 ashimema oh.. I was going to rebase that and forgot
13:44 ashimema well.. started and realised it was a mess so couldn't complete
13:44 ashimema we can reverse the deps
13:44 ashimema or I can rebase yours
13:44 ashimema leave it with me Joubu
13:46 Joubu thx
13:46 Joubu the big one should go asap I think
13:47 tcohen +1
13:47 ashimema both are very important
13:47 ashimema mine actually fixes bugs
13:47 ashimema actually.. I think both do
13:48 ashimema you're with yaml over multiple lines and mine with missing x-koha-embeds
13:48 ashimema let me just sign off marcelrs second bug and then I'll swing back round to these two
13:48 tcohen yours is easier to rebase, ashimema
13:48 ashimema indeed
14:03 cait has someone looked into the hold issue reported onthe mailing list?
14:03 cait 21.11.04 - can't place holds
14:04 cait https://lists.katipo.co.nz/pip[…]April/057588.html
14:04 lukeg joined #koha
14:09 oleonard-away Joubu++
14:09 oleonard-away kidclamp++
14:09 oleonard Thanks for moving 30532 along
14:17 tcohen oleonard: is your stuff sorted already?
14:17 tcohen bootstrap tabs, remove jqueryui
14:17 oleonard sorted?
14:19 tcohen all of them PQA
14:19 tcohen :-D
14:19 tcohen language
14:19 wahanui i heard language was fun :)
14:25 oleonard tcohen: Could you look at Bug 30031? It blocks 30304.
14:25 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=30031 enhancement, P5 - low, ---, lucas, Signed Off , Add lists to table settings
14:28 Joubu we should provide faster feedback to people on the ML saying Koha is totally broken...
14:29 cait it would be good
14:29 Joubu khall: one more: bug 30583
14:29 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=30583 blocker, P5 - low, ---, jonathan.druart+koha, ASSIGNED , Hold system broken for translated template
14:30 Joubu and 21.05
14:32 Joubu patch attached
14:33 Joubu not sure why we don't have more people complainingg about that one; it impacts latest 21.11 and 21.05
14:34 cait we have another odd one: Export tool failure Koha 21.11.03.000
14:35 cait could this have to do with background job stuff?
14:35 khall_ joined #koha
14:35 cait https://lists.katipo.co.nz/pip[…]April/057602.html
14:44 lukeg Joubu++
14:59 oleonard How do you use MARC modification templates to add multiple subfields to a tag?
15:02 kidclamp Joubu: bug 30584
15:02 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=30584 major, P5 - low, ---, koha-bugs, NEW , Cannot add field mappings to Elasticsearch configuration
15:06 lukeg joined #koha
15:09 cait oleonard: i think it's one of he add options that uses the existing field
15:10 oleonard I was able to get it to add a second subfield, but not a third
15:11 oleonard And it doesn't handle indicators at all?
15:13 cait i think that's true, indicators and controlfields
15:14 oleonard I never think of these things until an actual cataloger asks me :D
15:14 cait same
15:14 cait as our records are mostly cataloged 'elsewhere', we don't have a lot of requests about using the tool
15:17 reiveune left #koha
15:20 oleonard Cart export only exports up to 20 titles :(
15:21 oleonard Oh wait did I miss some when adding to the cart? Probably.
15:35 cait so all good?
15:36 oleonard Yes, false alarm
15:36 cait actually, I like those better than real bugs
16:00 oleonard How would one make changes to the sample MARC data?
16:04 kidclamp pull request on misc4dev
16:04 kidclamp or send the records to Joubu oleonard
16:07 Joubu oleonard: what kind of changes?
16:09 oleonard Maybe we have this already and I don't know it, but it would be nice to have records that can help demonstrate particular features, like  OPACFRBRizeEditions, html5media, component records
16:10 Joubu yes please
16:10 Joubu :)
16:10 Joubu that would be great
16:11 Joubu send me the MARC data and I will do what's needed
16:11 oleonard Okay will do.
16:23 ashimema erm
16:24 ashimema marcelr.. did you test the non QR code way of adding 2FA to your device?
16:24 ashimema i.e the 'Can't scan the code' option
16:24 ashimema I can't see how it can work
16:27 oleonard It worked when I tested, ashimema
16:28 oleonard Oh sorry, you said NON
16:28 ashimema indeed
16:28 ashimema I can't see how the fallback method can ever work
16:29 ashimema we don't actually display enough information
16:29 khall joined #koha
16:48 AndrewFH joined #koha
17:31 Joubu khall: and bug 30584!
17:31 huginn Bug https://bugs.koha-community.or[…]_bug.cgi?id=30584 critical, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Cannot add field mappings to Elasticsearch configuration
18:07 fridolin joined #koha
18:29 cait joined #koha
18:44 theminh joined #koha
18:45 theminh Hello! Does someone knows what this error means when I am runnig the QA test tool? :
18:45 theminh FAIL  critic # Variables::ProhibitUnusedVariables: Got 1 violation(s).
19:00 ashimema It means you declared a variable somewhere but then never used it
19:00 ashimema Look for a 'my $whatever' somewhere without any corresponding use of it
19:00 ashimema theminh^
19:01 ashimema With vv it would spit out a kind number from memory
19:02 ashimema That or run perkcritic against it manually
19:04 theminh Thank you:)
19:11 davidnind joined #koha
20:07 Atral joined #koha
20:07 Atral joined #koha
21:09 alexbuckley joined #koha
23:11 huginn News from kohagit: Bug 28786: Fix Patrons/Import.t <https://git.koha-community.org[…]517ea0ae34ce68c54>
23:43 huginn News from kohagit: Bug 30583: Fix hold system for translated templates <https://git.koha-community.org[…]c5de043a4ac5abada>
23:43 huginn News from kohagit: Bug 30532: (bug 29957 follow-up) Fix '$cookie->value' <https://git.koha-community.org[…]5315db32f76775b0a>
23:43 huginn News from kohagit: Bug 30525: Items batch modification broken <https://git.koha-community.org[…]6640dd99348f88c28>
23:43 huginn News from kohagit: Bug 30373: Add TYPEDOC authorised_values_category <https://git.koha-community.org[…]0660c8a51247f0d22>
23:43 huginn News from kohagit: Bug 30373: Fix visibility, authorised values and descriptions <https://git.koha-community.org[…]ae787b86e6dd490f2>
23:43 huginn News from kohagit: Bug 30373: Show 325$a <https://git.koha-community.org[…]aca35a263d861252a>
23:43 huginn News from kohagit: Bug 30373: Hide items.dateaccessioned from the editor <https://git.koha-community.org[…]4bca6cc6f2f057247>
23:43 huginn News from kohagit: Bug 30477: Add new UNIMARC installer translation files <https://git.koha-community.org[…]db1a97dc170d62390>
23:43 huginn News from kohagit: Bug 30373: Rewrite authorities_normal_unimarc to YAML <https://git.koha-community.org[…]9105f5e197f13c984>
23:43 huginn News from kohagit: Bug 30373: Add UNIMARC FA (fast add) framework <https://git.koha-community.org[…]47f1c27913b5d130b>
23:43 huginn News from kohagit: Bug 30373: Rewrite unimarc_framework_DEFAULT to YAML <https://git.koha-community.org[…]089e15d36211c2332>
23:43 huginn News from kohagit: Bug 30373: Enable translation of UNIMARC frameworks <https://git.koha-community.org[…]2f1b1d09fea73656b>
23:46 alohabot 🎁 🦄 Koha 'master' packages pushed to 'koha-staging' repo  🥑🍥🍆
23:48 koha-jenkins Yippee, build fixed!
23:48 koha-jenkins Project Koha_Master_U_Stable build #443: FIXED in 36 min: https://jenkins.koha-community[…]ter_U_Stable/443/
23:48 wahanui Congratulations!
23:58 koha-jenkins Yippee, build fixed!
23:58 koha-jenkins Project Koha_Master_U21 build #152: FIXED in 45 min: https://jenkins.koha-community[…]a_Master_U21/152/
23:58 wahanui Congratulations!

| Channels | #koha index | Today | | Search | Google Search | Plain-Text | plain, newest first | summary