| Time |
S |
Nick |
Message |
| 00:17 |
|
|
khall joined #koha |
| 00:24 |
|
|
inlibro joined #koha |
| 00:30 |
|
|
khall joined #koha |
| 00:34 |
|
koha-jenkins |
Project Koha_20.05_U2010 build #110: SUCCESS in 52 min: https://jenkins.koha-community[…]_20.05_U2010/110/ |
| 00:42 |
|
|
khall joined #koha |
| 00:48 |
|
|
matts joined #koha |
| 01:14 |
|
|
khall joined #koha |
| 01:19 |
|
|
lukeG1 joined #koha |
| 01:24 |
|
|
inlibro joined #koha |
| 01:27 |
|
tuxayo |
contender for the bug with the nicest dependency graph: https://bugs.koha-community.or[…]raph.cgi?id=18789 |
| 01:32 |
|
|
dpk_ joined #koha |
| 02:12 |
|
koha-jenkins |
Project Koha_19.11_U16 build #49: SUCCESS in 32 min: https://jenkins.koha-community[…]oha_19.11_U16/49/ |
| 02:18 |
|
koha-jenkins |
Project Koha_19.11_U18 build #294: SUCCESS in 38 min: https://jenkins.koha-community[…]ha_19.11_U18/294/ |
| 02:20 |
|
koha-jenkins |
Project Koha_19.11_D9 build #298: SUCCESS in 43 min: https://jenkins.koha-community[…]oha_19.11_D9/298/ |
| 02:21 |
|
koha-jenkins |
Project Koha_19.11_D8 build #366: SUCCESS in 40 min: https://jenkins.koha-community[…]oha_19.11_D8/366/ |
| 02:24 |
|
|
inlibro joined #koha |
| 02:25 |
|
koha-jenkins |
Project Koha_19.11_D10 build #130: SUCCESS in 47 min: https://jenkins.koha-community[…]ha_19.11_D10/130/ |
| 02:26 |
|
|
khall joined #koha |
| 02:29 |
|
koha-jenkins |
Project Koha_19.11_U20 build #192: UNSTABLE in 53 min: https://jenkins.koha-community[…]ha_19.11_U20/192/ |
| 03:04 |
|
|
khall_ joined #koha |
| 03:24 |
|
|
inlibro joined #koha |
| 03:32 |
|
|
khall joined #koha |
| 04:22 |
|
|
wizzyrea joined #koha |
| 04:25 |
|
|
inlibro joined #koha |
| 04:31 |
|
|
wizzycray joined #koha |
| 04:34 |
|
|
wizzyrea joined #koha |
| 05:25 |
|
|
inlibro joined #koha |
| 05:28 |
|
|
jsicot joined #koha |
| 05:32 |
|
|
eythian joined #koha |
| 06:19 |
|
|
fridolin joined #koha |
| 06:25 |
|
|
inlibro joined #koha |
| 06:35 |
|
|
jsicot joined #koha |
| 06:42 |
|
|
jsicot joined #koha |
| 06:45 |
|
|
wizzyrea joined #koha |
| 06:46 |
|
|
morrism joined #koha |
| 07:05 |
|
|
cait joined #koha |
| 07:06 |
|
|
did joined #koha |
| 07:23 |
|
|
cait joined #koha |
| 07:23 |
|
|
morrism joined #koha |
| 07:25 |
|
|
inlibro joined #koha |
| 07:30 |
|
|
cait1 joined #koha |
| 07:31 |
|
cait1 |
good morning #koha |
| 07:32 |
|
cait1 |
Joubu: the usual, please? ;) |
| 07:32 |
|
|
ere joined #koha |
| 07:36 |
|
|
alex_a joined #koha |
| 07:37 |
|
magnuse |
\o/ |
| 07:41 |
|
alex_a |
Bonjour |
| 07:41 |
|
wahanui |
privet, alex_a |
| 07:45 |
|
|
reiveune joined #koha |
| 07:45 |
|
reiveune |
hello |
| 08:00 |
|
|
lds joined #koha |
| 08:04 |
|
|
fridolin joined #koha |
| 08:10 |
|
ere |
Morning! :) |
| 08:11 |
|
ashimema |
Morning ere |
| 08:11 |
|
ashimema |
Morning #koha |
| 08:11 |
|
ere |
Hi ashimema |
| 08:11 |
|
ashimema |
humm.. I thought he'd set a cron job for restarting apache on the translate server |
| 08:21 |
|
Joubu |
cait1: I've set the restart 1h earlier |
| 08:22 |
|
* ashimema |
just started to read some of the scripts called in the cron |
| 08:22 |
|
ashimema |
I don't entirely understand at least some of them.. |
| 08:22 |
|
ashimema |
the frameworks one for instance.. it feels like it's missing a step to me |
| 08:23 |
|
ashimema |
we run sync_stores to get the latest translations from the database to file |
| 08:23 |
|
ashimema |
then we run a bunch of stuff against those files.. |
| 08:23 |
|
ashimema |
but I can't see any call to update_stores to then load those updated files back into the database for pootle. |
| 08:24 |
|
ashimema |
I'm hoping I'm just missing something obvious |
| 08:25 |
|
|
inlibro joined #koha |
| 08:45 |
|
|
ere joined #koha |
| 08:45 |
|
|
ere joined #koha |
| 08:56 |
|
|
ere joined #koha |
| 09:15 |
|
* ashimema |
thinks bug 27454 got forgotten |
| 09:15 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=27454 trivial, P5 - low, ---, martin.renvoize, Needs Signoff , Additional patron attributes change sequence on every reload of edit page |
| 09:22 |
|
|
ere joined #koha |
| 09:25 |
|
|
inlibro joined #koha |
| 09:32 |
|
|
alex_a joined #koha |
| 09:42 |
|
|
alex_a joined #koha |
| 09:45 |
|
|
morrism joined #koha |
| 10:26 |
|
|
inlibro joined #koha |
| 10:43 |
|
|
alex_a joined #koha |
| 10:50 |
|
|
khall joined #koha |
| 11:26 |
|
|
inlibro joined #koha |
| 11:35 |
|
|
alex_a joined #koha |
| 11:38 |
|
oleonard |
Hi #koha |
| 11:39 |
|
oleonard |
> <cait1> Joubu: the usual, please? |
| 11:39 |
|
oleonard |
Oh is Joubu bartending today? |
| 12:01 |
|
Joubu |
what's for you oleonard? |
| 12:02 |
|
Joubu |
something light as it's morning for you |
| 12:02 |
|
oleonard |
Still morning for me, so I guess I'll have a coffee and can uploads be accessed via a url? |
| 12:07 |
|
Joubu |
I don't think so |
| 12:09 |
|
oleonard |
No no luck tying audio alerts to uploads without some work :| |
| 12:14 |
|
|
Russ joined #koha |
| 12:14 |
|
Russ |
Hello |
| 12:15 |
|
Russ |
I am getting an error after installing ILL backends " Can't locate Koha/Illbackends/FreeForm/Base.pm in @INC (you may need to install the Koha::Illbackends::FreeForm::Base module) |
| 12:15 |
|
Russ |
Does anyboby have a way around it? |
| 12:20 |
|
oleonard |
Russ which instructions are you following? |
| 12:21 |
|
Russ |
https://wiki.koha-community.org/wiki/ILL_backends and https://github.com/PTFS-Europe/koha-ill-freeform |
| 12:21 |
|
Russ |
I do not where i went wrong |
| 12:22 |
|
Russ |
i do not know where i went wrong |
| 12:23 |
|
Russ |
I followed the instructions from https://wiki.koha-community.org/wiki/ILL_backends and https://github.com/PTFS-Europe/koha-ill-freeform |
| 12:23 |
|
oleonard |
Russ does the location where you cloned the FreeForm module match the path defined in koha-conf.xml ? |
| 12:24 |
|
* cait1 |
waves |
| 12:24 |
|
cait1 |
oleonard: try to catch kidclamp - he said it already works, so he might be able to tell how they do it for their partners? |
| 12:25 |
|
cait1 |
Russ: did you restart all the things after making your changes? |
| 12:25 |
|
cait1 |
all the things = plack, memcached |
| 12:25 |
|
cait1 |
it woudl also be good to know which patch you put into the koha-conf.xml, where you have the repo and if it's in the directory directly or symlinked to it |
| 12:26 |
|
|
inlibro joined #koha |
| 12:27 |
|
kidclamp |
oleonard: if you make the file accessible you should be able to get a URL, it's ugly, but the hash plus the filename, attach It to a bib to see the pattern, then you should be able to use that url for the sound |
| 12:28 |
|
oleonard |
Thanks kidclamp I'll give it a try |
| 12:28 |
|
Russ |
oleonard thats the path in the koha-conf.xml <backend_directory>__PERL_MODULE_DIR__/Koha/Illbackends</backend_directory> |
| 12:29 |
|
Russ |
cait1: okay i will restart everything and check again. |
| 12:30 |
|
cait1 |
Russ: either thew rong file or you need to replace the PERL_MODULE_DIR bit |
| 12:30 |
|
cait1 |
saying: that's not a valid path |
| 12:31 |
|
oleonard |
Russ: I would guess there is another koha-conf.xml |
| 12:31 |
|
cait1 |
yeah I think oleonard is right |
| 12:31 |
|
cait1 |
that's probably the "template" one |
| 12:32 |
|
cait1 |
if you have a package install, i think it will probably be in /etc/koha/sites... |
| 12:33 |
|
Russ |
the koha-conf.xml i have edited is in /etc/koha/sites/library/koha-conf.xml |
| 12:33 |
|
cait1 |
ok |
| 12:34 |
|
cait1 |
but you need to make sure the backend_directory has a real path |
| 12:34 |
|
cait1 |
__PERL_MODULE_DIR__ is only a placeholder for something local |
| 12:34 |
|
cait1 |
not meant to be copied |
| 12:35 |
|
cait1 |
as that part can vary depending on how koha was installed, we can't easily put the right thing there |
| 12:35 |
|
Russ |
okay can i replace the path with /usr/share/koha/lib/Koha/Illbackends/FreeForm (that's were i symlinked the files) |
| 12:35 |
|
cait1 |
yep |
| 12:35 |
|
cait1 |
that sounds about right |
| 12:35 |
|
Russ |
Thanks cait1 |
| 12:35 |
|
cait1 |
sure |
| 12:35 |
|
* cait1 |
wonders if cait1 cait and cait2 are the same person after all :) |
| 12:36 |
|
|
AndrewFH joined #koha |
| 12:36 |
|
ashimema |
all caits |
| 12:37 |
|
oleonard |
kidclamp: Oh so the link is the opac-retrieve-file.pl link |
| 12:38 |
|
kidclamp |
Yup |
| 12:41 |
|
|
fridolin joined #koha |
| 12:56 |
|
|
khall_ joined #koha |
| 13:01 |
|
|
morrism joined #koha |
| 13:23 |
|
oleonard |
When uploads are "marked as temporary," does that have any actual consequences? In what way are they temporary? |
| 13:26 |
|
|
inlibro joined #koha |
| 13:35 |
|
oleonard |
kidclamp do you know? ^^ |
| 13:36 |
|
AndrewFH |
I think cleanup_database can delete temporary files based on that flag? |
| 13:37 |
|
AndrewFH |
@ashimema do you remember the terrible truth you spoke the other day about Claims Returned and how it doesn't prevent overdues from generating if one does not charge the lost fee? Did you file a bug for that? |
| 13:37 |
|
huginn |
AndrewFH: I'll give you the answer just as soon as RDA is ready |
| 13:37 |
|
wahanui |
i already had it that way, huginn. |
| 13:38 |
|
ashimema |
humm |
| 13:39 |
|
ashimema |
I remember the conversation.. |
| 13:39 |
|
ashimema |
not sure I remember the bug |
| 13:40 |
|
AndrewFH |
no worries! I'm meeting with the other BWS trainers this morning to play around with that, figure out how best to deal with it in the meantime. I can file a bug based on our conversation and testing. I'll CC you on it, if you like |
| 13:45 |
|
oleonard |
Thanks AndrewFH you're right, cleanup_database can delete temp uploads |
| 13:46 |
|
* AndrewFH |
appreciates the chance to be right about something first thing in the morning |
| 13:47 |
|
oleonard |
:) |
| 13:49 |
|
|
geor joined #koha |
| 13:52 |
|
ashimema |
I detailed my findings in the POD on bug 25552 AndrewFH |
| 13:52 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=25552 normal, P5 - low, ---, kyle, Pushed to master , Add missing Claims Returned option to MarkLostItemsAsReturned |
| 13:52 |
|
ashimema |
looks like I didn't add a linked bug though :( |
| 13:53 |
|
geor |
good day, i am having problems, i copy here part of the log. this happened to someone, we were not doing anything special. this is [proxy_http:error] [pid 6667] (70007)The timeout specified has expired: [client 104.197.122.43:58706] AH01102: error reading status line from remote server httpd-UDS:0. thank you very much for your help! |
| 13:54 |
|
AndrewFH |
thanks @ashimema! |
| 13:55 |
|
ashimema |
http://irc.koha-community.org/[…]a;date=2021-01-22 was our conversation for reference |
| 13:56 |
|
|
Dyrcona joined #koha |
| 14:00 |
|
|
marie-luce joined #koha |
| 14:15 |
|
|
alex_a joined #koha |
| 14:20 |
|
|
khall joined #koha |
| 14:22 |
|
|
khall_ joined #koha |
| 14:24 |
|
|
khall joined #koha |
| 14:26 |
|
|
inlibro joined #koha |
| 14:34 |
|
tcohen |
is it still true that changing dateformat is dangerous? |
| 14:36 |
|
Joubu |
hum, shouldn't be |
| 14:36 |
|
Joubu |
*should* only be used for output |
| 14:36 |
|
Joubu |
(that's the theory) |
| 14:37 |
|
tcohen |
right, that's my understanding |
| 14:37 |
|
Joubu |
geor: you should try to extend Apache's timeout value |
| 14:42 |
|
|
jsicot joined #koha |
| 14:42 |
|
tcohen |
bug 26471 |
| 14:42 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=26471 normal, P5 - low, ---, oleonard, NEW , Datatables js error on missing pdfmake.min.js.map |
| 14:43 |
|
|
AndrewFH joined #koha |
| 14:44 |
|
Joubu |
magnuse: any chances to get a SO from you on bug 18984? |
| 14:44 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=18984 enhancement, P5 - low, ---, jonathan.druart, Needs Signoff , Remove support for NORMARC |
| 14:45 |
|
|
khall joined #koha |
| 14:47 |
|
oleonard-away |
tcohen were you trying to summon me? |
| 14:49 |
|
tcohen |
I just noticed its existence |
| 14:55 |
|
geor |
thanks, Joubu .finally it was a plugin that caused i |
| 14:59 |
|
|
lukeG joined #koha |
| 15:05 |
|
Joubu |
bug 20410 |
| 15:05 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20410 enhancement, P5 - low, ---, koha-bugs, Needs Signoff , Remove OpacGroupResults system preference and feature |
| 15:05 |
|
Joubu |
22 files changed, 24 insertions(+), 1615 deletions(-) |
| 15:06 |
|
oleonard |
Cool Joubu, thanks! |
| 15:06 |
|
|
lukeG1 joined #koha |
| 15:08 |
|
Joubu |
the NORMAL removal has a nice diff as well 55 files changed, 58 insertions(+), 13282 deletions(-) :D |
| 15:08 |
|
Joubu |
lol, NORMARC |
| 15:10 |
|
oleonard |
You're thinking of Bug 2020: "Remove all that is normal" |
| 15:10 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=2020 critical, PATCH-Sent (DO NOT USE), ---, gmcharlt, CLOSED FIXED, search.pl chokes on searches with "+and+" in the url |
| 15:10 |
|
oleonard |
No not that one huginn, it was a joke. |
| 15:11 |
|
oleonard |
What is the purpose of a temporary upload? |
| 15:14 |
|
tcohen |
you upload a marc file, you cancel the first import step |
| 15:15 |
|
oleonard |
Okay, follow-up question... :) |
| 15:15 |
|
oleonard |
What would be the use-case for uploading a temporary file via the upload tool? |
| 15:16 |
|
Joubu |
it's in the code oleonard! |
| 15:16 |
|
Joubu |
294 permanent => $self->{temporary}? 0: 1, |
| 15:16 |
|
Joubu |
obvious |
| 15:16 |
|
|
sophie_m joined #koha |
| 15:17 |
|
oleonard |
:P |
| 15:17 |
|
Joubu |
oleonard: actually, when I use tools/upload.pl the permanent flag in DB is 0 |
| 15:17 |
|
Joubu |
and the directory used to store the files is /var/lib/koha/kohadev/tmp/koha_kohadev_upload |
| 15:17 |
|
Joubu |
so the question for me is more "how to add a permanent upload?" |
| 15:18 |
|
oleonard |
It's in the code Joubu! |
| 15:18 |
|
oleonard |
68 <div class="hint">Note: No upload categories are defined. Add values to the UPLOAD authorized value category otherwise all uploads will be marked as temporary.</div> |
| 15:19 |
|
Joubu |
ha! |
| 15:20 |
|
Joubu |
so it's either linked to a AV and then it will be considered "permanent" and kept, or it will marked as temporary and removed when the cronjob will be run |
| 15:21 |
|
Joubu |
are you still trying to make the upload feature works with the audio alerts? |
| 15:23 |
|
Joubu |
cait1: Bernardo worked on the translation server today. The restart has been removed from the crontab. We will see this night/tomorrow how it behaves |
| 15:23 |
|
oleonard |
Joubu: I'm chipping away at it. Next I'm wondering if you can search uploads by category |
| 15:24 |
|
oleonard |
Joubu: I have confirmed that it's possible, following kidclamp's description |
| 15:24 |
|
Joubu |
are you going to add a specific category for audio? |
| 15:25 |
|
oleonard |
I guess we could add it as a default, or we could just direct the user to do so |
| 15:26 |
|
oleonard |
A default wouldn't be a bad idea since it would eliminate the step of creating the UPLOAD category itself. |
| 15:26 |
|
Joubu |
yes, definitely |
| 15:26 |
|
|
inlibro joined #koha |
| 15:27 |
|
Joubu |
and it will "show" the permanent/temporary feature |
| 15:27 |
|
Joubu |
it's quite hidden so far |
| 15:29 |
|
|
khall_ joined #koha |
| 15:35 |
|
|
wizzyrea joined #koha |
| 15:35 |
|
pastebot |
"oleonard" at 127.0.0.1 pasted "Is this dumb?" (10 lines) at http://paste.koha-community.org/27737 |
| 15:37 |
|
Joubu |
oleonard: why not a select with the different categories? |
| 15:38 |
|
oleonard |
Would you then take out the "like" stuff? |
| 15:43 |
|
Joubu |
it would be part of the query is an option is selected, but without like (with exact) |
| 15:43 |
|
Joubu |
if* |
| 15:58 |
|
reiveune |
bye |
| 15:58 |
|
|
reiveune left #koha |
| 16:00 |
|
|
liliputech_asu joined #koha |
| 16:09 |
|
|
morrism joined #koha |
| 16:12 |
|
ashimema |
cait still around? |
| 16:12 |
|
ashimema |
cait, cait1, cait2 |
| 16:13 |
|
fridolin |
Bug 27597 for a good regexp expert :) |
| 16:13 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=27597 normal, P5 - low, ---, koha-bugs, NEW , Searching "kw:term" does not work with Elasticsearch |
| 16:14 |
|
* oleonard |
looks at his regexp-related search history and quickly bows out |
| 16:22 |
|
|
liliputech_asu joined #koha |
| 16:27 |
|
|
inlibro joined #koha |
| 16:44 |
|
cait1 |
huh? |
| 16:44 |
|
cait1 |
ashimema ashimema ashimema |
| 16:44 |
|
* cait1 |
expects him to pop out of her mirror |
| 16:45 |
|
|
liliputech_asu joined #koha |
| 16:46 |
|
ashimema |
hello |
| 16:46 |
|
cait1 |
hi |
| 16:46 |
|
wahanui |
what's up, cait1 |
| 16:46 |
|
ashimema |
I was going to ask if you still intended to get back to the accounts notices bugs.. |
| 16:46 |
|
ashimema |
matts was asking about them.. but they've basically dropped off my radar now |
| 16:46 |
|
cait1 |
ame for me :( although i'd still like to have it a lot |
| 16:46 |
|
ashimema |
I'd love to see them progress.. but I think you were the one it was waiting on. |
| 16:47 |
|
cait1 |
most likely |
| 16:47 |
|
cait1 |
let's talk tomorrow maybe about some prio bugs? i don't want you to rebase and me not getting to tit |
| 16:47 |
|
cait1 |
to it |
| 16:47 |
|
cait1 |
i was about to leave and cook dinner |
| 16:48 |
|
|
cait joined #koha |
| 16:49 |
|
cait1 |
maybe back online later too |
| 16:49 |
|
|
cait1 left #koha |
| 16:51 |
|
|
lilipute1h_asu joined #koha |
| 16:51 |
|
* oleonard |
checks the dugout for cait2, cait3, and cait4 |
| 16:54 |
|
|
khall joined #koha |
| 17:01 |
|
|
paul_p joined #koha |
| 17:02 |
|
|
fridolin left #koha |
| 17:02 |
|
ashimema |
lol |
| 17:04 |
|
ashimema |
it's been one of those days.. I think I best clock off too before I start re-writing Koha in Jaa |
| 17:04 |
|
ashimema |
Java.. even |
| 17:06 |
|
ashimema |
lol.. or perhaps Velato.. that looks a cool language |
| 17:18 |
|
|
liliputech_asu joined #koha |
| 17:27 |
|
|
inlibro joined #koha |
| 17:58 |
|
cait |
ashimema: just don't use Blank |
| 17:58 |
|
cait |
or whitespace... or how thatis called |
| 18:07 |
|
|
khall_ joined #koha |
| 18:12 |
|
tcohen |
ashimema: Rust |
| 18:12 |
|
tcohen |
or Haskell |
| 18:22 |
|
cait |
:) |
| 18:27 |
|
|
inlibro joined #koha |
| 18:28 |
|
|
ere joined #koha |
| 18:50 |
|
oleonard |
tcohen: still around? |
| 19:05 |
|
tcohen |
sort of |
| 19:06 |
|
oleonard |
It can wait if you're busy. Need some Perl help. |
| 19:08 |
|
oleonard |
I've been hitting this with a rock but it still doesn't want to search by uploadcategorycode: https://git.koha-community.org[…]21c3;hb=HEAD#l153 |
| 19:11 |
|
oleonard |
It worked with "like" but I guess I don't know the right syntax to add it as an exact search http://paste.koha-community.org/27737 |
| 19:27 |
|
|
inlibro joined #koha |
| 19:32 |
|
tcohen |
oleonard-away: you are using an arrayref, things listed there are OR-ed. It feels like you want a big hash instead |
| 19:40 |
|
|
liliputech_asu joined #koha |
| 19:58 |
|
|
liliputech_asu joined #koha |
| 20:05 |
|
* cait |
waves |
| 20:12 |
|
caroline |
What does "Change service requested" mean in the HOLD sample notice? |
| 20:27 |
|
|
inlibro joined #koha |
| 20:33 |
|
|
khall joined #koha |
| 20:43 |
|
cait |
caroline: i asked the same recently and noone could explain |
| 20:44 |
|
caroline |
thanks cait |
| 20:44 |
|
cait |
not very helpful - just showing you are not alone :) |
| 20:44 |
|
caroline |
i'm kinda glad I'm not the only one who doesn't understand |
| 20:44 |
|
caroline |
:) |
| 20:44 |
|
caroline |
I wonder if I can git blame and find the person who added that line |
| 20:45 |
|
cait |
maybe :) |
| 20:45 |
|
cait |
or we could just kick it out of the template |
| 20:46 |
|
caroline |
OMG LOL! git blame says Katrin Fischer XD |
| 20:46 |
|
cait |
heh not true :) |
| 20:46 |
|
cait |
which commit? |
| 20:46 |
|
wahanui |
which commit are you trying to remove? |
| 20:46 |
|
caroline |
dc2c19bd515 |
| 20:47 |
|
cait |
only fixed capitalization there |
| 20:47 |
|
caroline |
its capitalization |
| 20:47 |
|
cait |
oyuneed to go further back |
| 20:47 |
|
caroline |
yeah, I'm not good enough with git |
| 20:48 |
|
cait |
jump to that commit |
| 20:48 |
|
cait |
and do the git blame again |
| 20:48 |
|
caroline |
ok i'll try that |
| 20:55 |
|
caroline |
... seems to be from a Jane Wagner... not sure who that is |
| 20:55 |
|
cait |
kptfs - the US one |
| 20:55 |
|
oleonard-away |
That would have been a LONG time ago |
| 20:56 |
|
caroline |
my hypothesis though is that it was a request to change from print to email maybe? |
| 20:56 |
|
caroline |
because it's only present in the HOLD_PRINT notice |
| 20:56 |
|
cait |
i would suggest we remove it |
| 20:56 |
|
caroline |
same |
| 20:56 |
|
cait |
it might have been taken from a template from a library or so |
| 20:56 |
|
cait |
and noone ever questioned it |
| 20:57 |
|
cait |
caroline: when are you merging my docs patches? :) |
| 20:57 |
|
caroline |
it's somewhere in my todo list |
| 20:59 |
|
caroline |
do you need them merged to translate? |
| 21:00 |
|
cait |
it's ok, just excited |
| 21:00 |
|
cait |
:) |
| 21:00 |
|
cait |
translting will happen again when you branch, just merge before oyu brnach heh |
| 21:00 |
|
caroline |
yes of course |
| 21:01 |
|
caroline |
I tried to work on the cookbook last night, but I didn't have much success |
| 21:11 |
|
|
Awazez joined #koha |
| 21:28 |
|
|
inlibro joined #koha |
| 21:28 |
|
caroline |
why are some strings without context or plurals in messages.po? what makes strings go in that one rather than staff-prog or opac-bootstrap? |
| 21:29 |
|
caroline |
maybe I should wait for Joubu to be around to ask that |
| 21:30 |
|
cait |
i tihnk there is a way to write these without giving context |
| 21:30 |
|
cait |
it's optional |
| 21:30 |
|
cait |
and you don't have to do the singular/pluarals |
| 21:31 |
|
cait |
i thin you got to blame oloenard :) |
| 21:31 |
|
cait |
a ton of the new ones are moving the strings out of templates into js, they go there |
| 21:31 |
|
caroline |
I already blamed you and Jane Wagner... might as well blame oleonard too while I'm at it ;) |
| 21:31 |
|
cait |
a lot of these were moved 1:1 - but could use plural/singular |
| 21:31 |
|
cait |
i thought it would make a nice follow-up in qa |
| 21:31 |
|
cait |
:) |
| 21:31 |
|
cait |
hehe |
| 21:33 |
|
caroline |
I was looking at this example |
| 21:34 |
|
caroline |
http://paste.koha-community.org/27739 |
| 21:34 |
|
caroline |
It looks like a regular string that could be in staff-prog.po |
| 21:35 |
|
caroline |
just wondering why it went into messages.po rather than staff-prog.po |
| 21:36 |
|
cait |
because all the javascript ones go into messages |
| 21:36 |
|
cait |
staff-prog was what they came from |
| 21:37 |
|
cait |
when they were in the tt |
| 21:37 |
|
caroline |
and what is the difference between messages and messages-js? |
| 21:39 |
|
cait |
huh |
| 21:39 |
|
cait |
now you got me |
| 21:39 |
|
cait |
messages-js hsoudl have the js ones actually... and messages hte ones using the new syntax from tt... i thought |
| 21:40 |
|
|
dpk joined #koha |
| 21:57 |
|
|
oleonard joined #koha |
| 22:28 |
|
|
inlibro joined #koha |
| 22:29 |
|
|
ere joined #koha |
| 23:28 |
|
|
inlibro joined #koha |
| 23:47 |
|
|
khall joined #koha |
