IRC log for #koha, 2020-11-05

All times shown according to UTC.

Time S Nick Message
00:10 inlibro joined #koha
01:05 koha-jenkins Project Koha_19.11_D10 build #88: SUCCESS in 37 min: https://jenkins.koha-community[…]oha_19.11_D10/88/
01:09 koha-jenkins Project Koha_19.11_D9 build #261: SUCCESS in 43 min: https://jenkins.koha-community[…]oha_19.11_D9/261/
01:09 koha-jenkins Project Koha_19.11_U16 build #14: SUCCESS in 44 min: https://jenkins.koha-community[…]oha_19.11_U16/14/
01:10 inlibro joined #koha
01:13 koha-jenkins Project Koha_19.11_U18 build #258: SUCCESS in 48 min: https://jenkins.koha-community[…]ha_19.11_U18/258/
01:22 AndrewFH joined #koha
01:42 koha-jenkins Project Koha_19.11_D10 build #89: UNSTABLE in 36 min: https://jenkins.koha-community[…]oha_19.11_D10/89/
01:45 koha-jenkins Project Koha_19.11_D8 build #334: SUCCESS in 35 min: https://jenkins.koha-community[…]oha_19.11_D8/334/
01:51 koha-jenkins Project Koha_19.11_D9 build #262: SUCCESS in 41 min: https://jenkins.koha-community[…]oha_19.11_D9/262/
02:01 koha-jenkins Project Koha_19.11_U18 build #259: SUCCESS in 47 min: https://jenkins.koha-community[…]ha_19.11_U18/259/
02:05 tuxayo > dcook wishes he was independently wealthy so that he could just work on Koha heh
02:05 tuxayo Meanwhile, negotiate less worktime? 😉
02:05 tuxayo For personal stuff mainly.
02:09 dcook tuxayo: If I had less work time, I'd probably have more family time :p
02:10 inlibro joined #koha
02:13 AndrewFH joined #koha
02:14 tuxayo That sounds good!
02:14 dcook_ joined #koha
02:28 koha-jenkins Project Koha_19.11_U20 build #155: SUCCESS in 42 min: https://jenkins.koha-community[…]ha_19.11_U20/155/
03:08 koha-jenkins Project Koha_19.11_U16 build #15: SUCCESS in 40 min: https://jenkins.koha-community[…]oha_19.11_U16/15/
03:11 inlibro joined #koha
03:39 koha-jenkins Project Koha_19.11_D8 build #335: UNSTABLE in 31 min: https://jenkins.koha-community[…]oha_19.11_D8/335/
04:11 inlibro joined #koha
04:19 koha-jenkins Project Koha_19.11_U20 build #156: SUCCESS in 39 min: https://jenkins.koha-community[…]ha_19.11_U20/156/
05:11 inlibro joined #koha
06:11 inlibro joined #koha
06:21 josef_moravec joined #koha
06:23 fridolin joined #koha
06:35 enkidu joined #koha
06:35 chriss joined #koha
06:39 did joined #koha
06:49 khall joined #koha
06:52 lds joined #koha
07:00 khall joined #koha
07:08 khall joined #koha
07:11 inlibro joined #koha
07:34 lmstrand joined #koha
07:51 alex_a joined #koha
07:51 alex_a Bonjour
07:52 lavamind joined #koha
07:59 cait joined #koha
08:02 cait1 joined #koha
08:07 fridolin joined #koha
08:12 inlibro joined #koha
08:15 dcook joined #koha
08:15 Joubu ashimema: I've fixed the failing test on bug 26935
08:15 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=26935 normal, P5 - low, ---, jonathan.druart, Needs Signoff , Incorrect basketid sent for claimacquisition and claimissues
08:17 nlegrand joined #koha
08:17 nlegrand gut morgn koha!
08:23 Joubu @later tell khall Did you see bug 26594 comment 14?
08:23 huginn Joubu: The operation succeeded.
08:23 Joubu Salut nlegrand!
08:23 liliputech_asu joined #koha
08:26 nlegrand Salut Joubu!
08:26 nlegrand I'm going to look at Bug 24412 this morning, thanks for your input :)
08:26 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=24412 enhancement, P5 - low, ---, nicolas.legrand, Failed QA , Attach waiting hold to desk
08:27 liliputech_asu hellow there :)
08:27 liliputech_asu oooh, cool bug nlegrand, omoshiroï! :)
08:28 liliputech_asu (probably useful for "biblio-drive" feature most wanted those days)
08:29 nlegrand totemo omoshiroï, demo... muzukashii desu!
08:29 nlegrand hey liliputech_asu :)
08:31 Joubu nlegrand: let me know if you need help
08:32 Joubu I'd like ashimema's input for 4.
08:41 nlegrand Joubu: thanks! (I have no idea for 4 right now, I need to read again the code)
08:46 ashimema morning
08:47 nlegrand salut ashimema!
08:48 * ashimema is reading back.. looks like I have a few tasks already :)
08:53 ashimema yikes.. good catch on point 2 for bug 24412 Joubu.. how did I miss that.. Doh!
08:53 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=24412 enhancement, P5 - low, ---, nicolas.legrand, Failed QA , Attach waiting hold to desk
08:56 Joubu mtj: could you have a look at how hard/easy Locale::XGettext::TT2 can be packaged (from 20.11 ideally) - see bug 25067
08:56 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=25067 enhancement, P5 - low, ---, julian.maurice, Passed QA , Move PO file manipulation code into gulp tasks
08:58 liliputech_asu joined #koha
09:03 ashimema are you happy fixing those issues nlegrand?
09:03 ashimema shout if you need a hand anyways
09:06 * cait1 waves
09:07 Joubu cait1: looks like we have a 20.11 project on pootle - https://translate.koha-communi[…]g/projects/20.11/
09:08 Joubu I didn't get Bernardo's confirmation it's ready yet, but looks like it's getting close
09:08 Joubu I bet he will send an email to the koha-translation ML
09:12 inlibro joined #koha
09:12 ashimema just getting to grips with bug 26935 Joubu.. surprised the tests failed.. I ran them and had them all passing before I submitted them
09:12 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=26935 normal, P5 - low, ---, jonathan.druart, Needs Signoff , Incorrect basketid sent for claimacquisition and claimissues
09:13 ashimema though it sounds like you think they highlight an issue elsewhere which is good.
09:13 ashimema just not sure how the failure crept in
09:14 ashimema the way externalid is passed around though is really weird.. you're patch looks solid to me
09:15 ashimema minor thing I wonder about is whether it's worth setting the right table for each differnt use of externalid in this set of alerts
09:15 ashimema but perhaps that's another bug
09:17 Joubu yeah, as I wrote in the commit message, this patch is really about making the test passes, nothing else
09:18 Joubu the whole sub is crappy
09:18 Joubu the externalid handling is wrong, and the basket's info are not retrieved when needed...
09:18 Joubu this is definitely from another bug report
09:19 nlegrand hey cait1
09:19 ashimema okies
09:20 nlegrand ashimema: I'm looking at it right now, will shout soon :)
09:24 khall joined #koha
09:26 alex_a joined #koha
09:28 * ashimema is now on a rebase mission
09:40 alex_a joined #koha
09:53 fridolin Bug 26687 whoooo
09:53 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=26687 enhancement, P5 - low, ---, fridolin.somers, Pushed to master , Add a Font Awesome icon for superlibrarian patrons
09:53 fridolin 20.11 will be super nice
09:53 davidnind fridolin++
09:53 jonrog joined #koha
10:03 fridolin davidnind: thanks a lot for all your tests
10:04 fridolin your fingerprints are all over Koha ;)
10:08 fridolin ashimema: around ?
10:08 davidnind no problem! (hopefully in a good way, good test plans make it easy to test!)
10:08 fridolin ashimema:  see my warn on Bug 25462 please
10:08 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=25462 enhancement, P5 - low, ---, david.roberts, Signed Off , Shelving location should be on a new line in holdings table
10:08 ashimema around ish
10:09 ashimema I'm in a call
10:10 ashimema I used that bug in a live demo of how to SO fridolin... comment taken though and I think it should be thought a bit more about during QA :)
10:12 inlibro joined #koha
10:12 fridolin ashimema: oki cool ;)
10:13 ashimema I thought I'd take a look at all the pages you detail to check they look sensible too
10:13 ashimema deffo thanks for raising it.. so much going on these days I was bound to drop the ball
10:28 severine_q joined #koha
10:28 severine_q hi #koha !!
10:38 khall_ joined #koha
10:44 dpk joined #koha
10:48 davidnind left #koha
11:03 Joubu khall_: Can you have a look at bug 26627 comment 8 please?
11:03 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=26627 normal, P5 - low, ---, kyle, Pushed to master , Print and confirming a hold can cause an infinite loop
11:04 khall joined #koha
11:06 oleonard Hi #koha
11:07 severine_q hello oleonard !
11:08 * cait1 waves
11:08 cait1 bbl :)
11:09 oleonard Joubu if you get a moment I wonder if you could look at the last couple of comments on Bug 24223
11:09 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=24223 enhancement, P5 - low, ---, oleonard, Failed QA , Convert OpacNav system preference to news block
11:09 cait1 Joubu: German has over 10.000 things to translate... that's more than we had in a while
11:09 cait1 so i better get started soon ugh.
11:09 cait1 gone now :)
11:09 cait1 left #koha
11:09 ashimema I blame you for that cait1 ;)
11:10 ashimema you kept finding things for me to fix with translations :P
11:12 Joubu @later tell cait is that caused by the framework's strings?
11:12 huginn Joubu: The operation succeeded.
11:12 inlibro joined #koha
11:12 oleonard ashimema do you understand Bug 26913? The last comment confuses me.
11:12 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=26913 minor, P5 - low, ---, oleonard, NEW , More than one title element on homepage when news item is displayed
11:14 khall joined #koha
11:14 Joubu oleonard: commented on the bug, it's a qa-test-tools bug
11:15 oleonard Thanks Joubu!
11:19 ashimema good question oleonard
11:19 Joubu oleonard: it's fixed and merged
11:20 Joubu @later tell khall Can you have a look at bug 26627 comment 8 please?
11:20 huginn Joubu: The operation succeeded.
11:23 khall joined #koha
11:41 khall Joubu added a followup to bug 26627
11:41 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=26627 normal, P5 - low, ---, kyle, Pushed to master , Print and confirming a hold can cause an infinite loop
11:43 lds joined #koha
11:49 magnuse a file like nb-NO-installer-MARC21.po is just the names of fields and subfields in the frameworks, right?
11:51 cait joined #koha
11:59 khall_ joined #koha
12:05 cait tcohen: what's the current recommendation when testing REST? i think you mentioned a firefox plugin in th epast (asking for my coworker :) )
12:07 cait Joubu: i thnk part of it is to blame on me for the fixes on sysprefs, have to take a closer look to tell. installer is completely separate
12:07 khall joined #koha
12:08 cait yep 6.000 in pref, 2600 in staff - it looks about right :)
12:08 Joubu Postman
12:08 oleonard cait: Postman is free but not FOSS
12:08 Joubu tha
12:08 Joubu thanks khall!
12:09 cait it looks a bit complex - more than just for testing i guess? https://www.postman.com/
12:12 inlibro joined #koha
12:12 oleonard It has a bit of a learning curve to get started but you don't have to get too deep into it to get what you need for testing.
12:12 tcohen cait there are some REST clients for Firefox
12:13 tcohen but Postman lets you save some setups
12:13 tcohen and does OAuth
12:13 tcohen so it has more options
12:13 tcohen one thing I like about it, is it generates (if you want) the curl command for the request
12:15 cait do you install it locally? we will be working with patron data
12:15 AndrewFH joined #koha
12:16 oleonard Yes
12:17 tcohen snap install postman
12:18 tcohen in order to use it, I suggest you enable Basic auth
12:18 tcohen in Koha
12:23 fridolin joined #koha
12:30 cait i didn't see docs about the auth methods
12:30 cait only the list in the wiki, is that hiding somewhere else?
12:40 khall joined #koha
12:56 Null404 joined #koha
12:57 Joubu kidclamp or tcohen: could you QA bug 26935?
12:57 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=26935 normal, P5 - low, ---, jonathan.druart, Signed Off , Incorrect basketid sent for claimacquisition and claimissues
12:57 Null404 hello
12:59 ashimema we're still waiting for a reply from aliesha on bug 24488 aren't we
12:59 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=24488 normal, P5 - low, ---, aleisha, Signed Off , Holds to Pull sometimes shows the wrong 'first patron' details
12:59 Null404 There is a option in Koha to block fee for hold book too long only to active patrons who borrow book on this year?
13:00 ashimema I see what you patch does there.. it's interesting in so much as it does the same optimisation in effect that I was discussing with kohaputti yesterday Joubu.
13:00 Joubu ashimema: regarding comment 50? I think we don't need to, the code does not make sense
13:00 ashimema okies.. cool
13:00 ashimema so it's just benchmarking that's outstanding then
13:00 Joubu unless you think it does!
13:00 Joubu yep!
13:01 ashimema haha.. I've not read it closely enough to judge that block.. it does look a bit nonsense to me
13:01 ashimema as for benchmarking
13:01 ashimema it's a hard call.. I think it's going to end up a trade off between being memory bound vs being io bound..
13:02 ashimema you're version will grab all the data into memory in the first call and then sort it in memory.. great if you have enough memory
13:02 ashimema aliesha's version will do db hits inside the loop.. so if you have a decent ssd hosting the db.. also probably OK..
13:02 ashimema not sure I can benchmark sensibly.. :|
13:03 ashimema I totally see where you're coming from though
13:03 * ashimema goes for a quick lunch and mulls it over
13:04 liliputech_asu joined #koha
13:07 tcohen heydevs, do we have a rule for localstorage use? privacy concerns?
13:07 tcohen I recall some discussion
13:08 oleonard It needs to be documented
13:08 Joubu we flush it on logout
13:08 oleonard ...like cookies are
13:11 oleonard I think there needs to be discussion of how to handle localstorage which would be useful to keep across sessions: Like UI settings which don't contain private information
13:11 magnuse do we use localstorage for offline circ?
13:12 inlibro joined #koha
13:27 tcohen I've just noticed DataTables uses it but it doesn't ge tadvertised
13:27 ashimema ooh.. didn't know that
13:27 josef_moravec joined #koha
13:28 tcohen https://datatables.net/reference/option/stateSave
13:28 tcohen me neither
13:28 tcohen was working on a follow-up for bug 20212 and got confused because some query I made for testing purposes
13:28 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=20212 enhancement, P5 - low, ---, tomascohen, Failed QA , Slowness in receiving in acquisitions
13:29 tcohen kept getting in the middle no matter what I did
13:30 ashimema tcohen++
13:30 ashimema battling on..
13:33 ashimema talking datatables..
13:33 ashimema do we have any feelings/standards/guidelines on preventing flashes of unstyled content?
13:34 ashimema i.e. that slot of time when the table loads but the JS hasn't finished loading yet
13:34 ashimema oleonard ^ ?
13:35 oleonard No guidelines I know of ashimema.
13:35 oleonard Are you thinking in particular of the OPAC or staff interface?
13:35 ashimema either really
13:36 AndrewFH joined #koha
13:36 ashimema on some of the more complex tables it's getting a bit more noticeable of late.
13:36 ashimema and is easily fixed
13:36 ashimema i.e. load the page with the table hidden and then display it only on the final JS init
13:37 tcohen that's a good thing to explore
13:39 magnuse +1
13:40 ashimema me has a patch for one table he was thinking of
13:41 ashimema just about to upload it
13:42 marie-luce joined #koha
13:43 khall joined #koha
13:48 ashimema bug 26938
13:48 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=26938 minor, P5 - low, ---, martin.renvoize, Needs Signoff , Prevent flash of unstyled content on sales table
13:48 ashimema but we could in theory apply it to all KohaTables reasonably easily I reckon..
13:49 Joubu yes ashimema, I would provide a global solution instead
13:50 ashimema yup.. hence my questioning :)
13:51 ashimema probably not this cycle though.. at this point :)
13:58 khall joined #koha
14:05 lukeG joined #koha
14:13 inlibro joined #koha
14:22 lukeG1 joined #koha
14:27 huginn News from kohagit: Bug 25334: MTT is itiva not talkingtech <http://git.koha-community.org/[…]a0ffe23e0e0c50dc7>
14:27 huginn News from kohagit: Bug 25334: DBRev 20.06.00.060 <http://git.koha-community.org/[…]d3c87458b4e74333d>
14:27 huginn News from kohagit: Bug 26172: Compiled CSS <http://git.koha-community.org/[…]6904b1c9e7bf7949e>
14:27 huginn News from kohagit: Bug 25334: (QA follow-up) Update overduerules.tt <http://git.koha-community.org/[…]5859f3d01d3c39d3a>
14:27 huginn News from kohagit: Bug 25334: (QA follow-up) Update opac messaging <http://git.koha-community.org/[…]c557512b8da1ded97>
14:27 huginn News from kohagit: Bug 26172: Replace _result[set] calls <http://git.koha-community.org/[…]355498f71a8cd938a>
14:27 huginn News from kohagit: Bug 26148: OpenLibrary "Preview" link target is unclear to patrons <http://git.koha-community.org/[…]29b396cd68d8a105d>
14:27 huginn News from kohagit: Bug 26582: (QA follow-up) Rename closed => is_closed <http://git.koha-community.org/[…]59c5112602bc13490>
14:27 huginn News from kohagit: Bug 26172: (QA follow-up) Add tests for previous cashups <http://git.koha-community.org/[…]c5e02841184df0dbb>
14:27 huginn News from kohagit: Bug 26172: Fix return value for ->register <http://git.koha-community.org/[…]23f485d8c352fa778>
14:27 huginn News from kohagit: Bug 26172: (QA follow-up) Add Unit Test <http://git.koha-community.org/[…]66619c07f88e7157c>
14:27 huginn News from kohagit: Bug 26172: (QA follow-up) Fix order of summary <http://git.koha-community.org/[…]d16716135ceae1a9a>
14:27 huginn News from kohagit: Bug 26172: (QA follow-up) Add missing filter <http://git.koha-community.org/[…]619e7b6a34d30bc97>
14:27 huginn News from kohagit: Bug 26584: Remove unused C4::Acquisition::CloseBasket function <http://git.koha-community.org/[…]151521e5f03a994c8>
14:27 huginn News from kohagit: Bug 26582: Add Koha::Acquisition::Basket->close <http://git.koha-community.org/[…]4299cea65e3be0ea2>
14:27 huginn News from kohagit: Bug 26172: (follow-up) Add print option <http://git.koha-community.org/[…]3c5a8c796ad3b75f3>
14:27 huginn News from kohagit: Bug 26172: (follow-up) Summary by payment_type <http://git.koha-community.org/[…]47791e5fba78e921a>
14:27 huginn News from kohagit: Bug 26172: Add cashup summary view modal <http://git.koha-community.org/[…]c05c674e82b3f2728>
14:27 huginn News from kohagit: Bug 25650: Add location and itype descriptions in ILS-DI GetRecords <http://git.koha-community.org/[…]ce6744939ee574e22>
14:27 huginn News from kohagit: Bug 25334: Add generic 'phone' message transport type <http://git.koha-community.org/[…]1757770b6aa53d6e9>
14:58 tcohen ashimema khall I've added a follow-up for bug 14708, and I'm still wondering if 403 is the right code for the exception condition. I feel like 409 fits better (https://www.restapitutorial.co[…]statuscodes.html)
14:58 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=14708 normal, P5 - low, ---, kyle.m.hall, Passed QA , The patron set as the anonymous patron should not be deletable
15:01 ashimema school run.. will take a look upon my return
15:02 fridolin Bug 26941 found some dead code, shout it
15:02 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=26941 minor, P5 - low, ---, fridolin.somers, Needs Signoff , Missing OPAC password recovery error messages
15:07 cait left #koha
15:13 inlibro joined #koha
15:18 koha-jenkins Project Koha_Master_D9_MDB_Latest build #432: STILL UNSTABLE in 50 min: https://jenkins.koha-community[…]9_MDB_Latest/432/
15:20 koha-jenkins Project Koha_Master_U20 build #134: STILL UNSTABLE in 51 min: https://jenkins.koha-community[…]a_Master_U20/134/
15:22 koha-jenkins Project Koha_Master_D9 build #1487: STILL UNSTABLE in 53 min: https://jenkins.koha-community[…]a_Master_D9/1487/
15:22 Dyrcona joined #koha
15:29 koha-jenkins Project Koha_Master_D9_My8 build #454: STILL UNSTABLE in 1 hr 2 min: https://jenkins.koha-community[…]aster_D9_My8/454/
15:30 huginn News from kohagit: Bug 16696: Fix search_utf8.t <http://git.koha-community.org/[…]5f048b1a0aa7b5496>
15:42 fridolin joined #koha
15:48 cait joined #koha
15:50 cait1 joined #koha
16:07 koha-jenkins Project Koha_Master_D10_Deps build #127: STILL UNSTABLE in 44 min: https://jenkins.koha-community[…]ter_D10_Deps/127/
16:10 koha-jenkins Project Koha_Master_D10 build #396: STILL UNSTABLE in 49 min: https://jenkins.koha-community[…]a_Master_D10/396/
16:10 oleonard In the OPAC the "lang" template variable seems to be available on most but not all pages and I can't figure out why.
16:10 koha-jenkins Project Koha_Master_U18 build #937: STILL UNSTABLE in 52 min: https://jenkins.koha-community[…]a_Master_U18/937/
16:11 oleonard On opac-readingrecord.pl for instance the value is incorrect
16:11 oleonard "default" instead of "en" in my system.
16:11 vfernandes joined #koha
16:11 vfernandes hi #koha
16:12 ashimema weird
16:12 vfernandes how we can override the renewals limite?
16:12 oleonard vfernandes there is a  AllowRenewalLimitOverride system preference
16:13 caroline If it's enabled, there's a small checkbox beneath the loans table that you have to check
16:13 inlibro joined #koha
16:13 caroline it's not very apparent, but it's there
16:14 vfernandes thanks oleonard and caroline
16:14 vfernandes the systempreference was set to 'allow' but i couldn't found checkbox
16:19 caroline vfernandes: https://snipboard.io/OnaATM.jpg
16:21 caroline like I said, it's not easy to find it, but it's there :)
16:23 oleonard ashimema any idea why?
16:23 oleonard Or maybe I should ask... How do I find out where a variable comes from when I don't see it set in the code
16:25 ashimema just trying to work that out
16:25 ashimema the 'why' that is..
16:25 ashimema as for the 'how to find it'.. that's harder
16:25 ashimema I was just looking at C4/Auth.pm as that's usually the culprit..
16:25 ashimema but in this case it seems not
16:26 koha-jenkins Project Koha_Master_U16 build #119: STILL UNSTABLE in 57 min: https://jenkins.koha-community[…]a_Master_U16/119/
16:26 ashimema looks like it comes form C4/Templates.pm
16:28 ashimema aha.. that's interesting
16:28 ashimema ok.. I think I undertand what 'might' be happening
16:29 ashimema I think C4/Templates.pm is responsible for setting a lang template param for all pages... but.. it appears there's a few places that then also set it themselves and end up nuking the global one..
16:29 ashimema that's my hunch
16:29 ashimema tools/koha-news.pl certainly looks like a culprit for example
16:29 fridolin left #koha
16:29 ashimema though it might be right there.. I've not dug deep enough yet
16:32 oleonard ashimema: $template->param(%{$borr});
16:32 ashimema good call
16:32 oleonard It was a guess but it seems to be the culprit
16:32 ashimema that will be nuking the lang from C4/Templates.pm I reckon
16:36 oleonard My pref-to-news patches seem to always have new bugs come up :(
16:36 ashimema so you probably just want to call `delete $borr{'lang'};` directly above the line you pasted above
16:37 ashimema at least.. that'll be the simplest fix
16:37 cait1 oleonard: i feel you
16:37 cait1 sometimes you just want to do that small thing and everything around it seems to fall apart
16:37 ashimema preferably if the template really needs all the borrower data passed into it.. I'd pass it nested myself.. i.e. $template->param( borrower -> $borr );
16:38 ashimema then adapt the template prepending borrower. to all the relevant variables
16:38 ashimema variable overlap is horrible here
16:38 ashimema think we all know that feeling cait1, oleonard..
16:38 oleonard That's my idea ashimema. I'm just double-checking that it's even required.
16:38 ashimema I have a habbit of ending up deep in such holes
16:39 oleonard My other question is: the "branchcode" variable seems to also be set inconsistently, and I'm wondering if I need to modify all scripts in the OPAC or whether it's more sensible to set it globally, like in Auth.pm
16:40 oleonard In opac-main.pl: http://git.koha-community.org/[…]6997d;hb=HEAD#l51
16:40 ashimema yikes.. you'll likely have the same sort of issue.. though probably even more prevalent
16:44 ashimema hmm
16:44 ashimema opac-main is a little weird I suppose.. if you're not logged in we don't really know what branch to show you.
16:45 oleonard The news blocks should try to use the logged-in branch if possible, and those blocks can be on any page.
16:52 koha-jenkins Project Koha_Master_D11 build #134: STILL UNSTABLE in 45 min: https://jenkins.koha-community[…]a_Master_D11/134/
16:53 cait1 left #koha
16:57 khall joined #koha
16:58 koha-jenkins Yippee, build fixed!
16:58 wahanui Congratulations!
16:58 koha-jenkins Project Koha_Master_U2010 build #41: FIXED in 48 min: https://jenkins.koha-community[…]_Master_U2010/41/
17:00 oleonard Looks like it's already set globally as logged_in_user.branchcode
17:06 tuxayo hi #koha o/
17:07 tuxayo How could be named the hold rules based on branch, category and type as opposed to the hold policy which is based on branch and category?
17:07 oleonard Hi tuxayo
17:11 tuxayo Like main circulation rule and hold policy?
17:12 * tuxayo tries to not add more confusion in Reserves.pm and request.pl
17:13 inlibro joined #koha
17:13 enkidu joined #koha
17:15 koha-jenkins Project Koha_Master_D9_My8 build #455: STILL UNSTABLE in 1 hr 4 min: https://jenkins.koha-community[…]aster_D9_My8/455/
17:17 ashimema oleonard.. branchcode wise.. can you not switch branch ?
17:17 oleonard In the OPAC the only branch-switching you can do is on the main page with the News.
17:17 ashimema sorry, that wasn't clear
17:18 ashimema what about cgi-bin/koha/opac-library.pl
17:18 ashimema is that the news your talking about?
17:19 oleonard That's an example of a page where the current templates have unwanted variable collisions
17:19 ashimema hehe
17:19 ashimema thought it might be
17:20 * ashimema needs to clock off.. kids are tearing each others hair out.
17:20 oleonard I'm going to switch calls to KohaNews to use logged_in_user.branchcode... Unless someone can think of a reason I shouldn't.
17:20 ashimema I think for opac side that sounds very reasonable
17:20 ashimema for staff side where you can change branch the context method makes more sense
17:20 ashimema but it sounds like you're already aware of that
17:21 ashimema right.. see ya later
17:21 oleonard Thanks ashimema , see ya
17:26 cait joined #koha
17:26 koha-jenkins Project Koha_Master_D9_MDB_Latest build #433: STILL UNSTABLE in 1 hr 0 min: https://jenkins.koha-community[…]9_MDB_Latest/433/
17:37 magnuse should i be able to upgrade to koha 20.05.05 on Ubuntu 16.04.7?
17:38 magnuse not according to https://wiki.koha-community.org/wiki/Ubuntu dang.
17:40 koha-jenkins Yippee, build fixed!
17:40 wahanui Congratulations!
17:40 koha-jenkins Project Koha_Master_U20 build #135: FIXED in 47 min: https://jenkins.koha-community[…]a_Master_U20/135/
17:48 magnuse huh? "apt-get upgrade" says koha-common libcryptx-perl libmojolicious-plugin-openapi-perl have been kept back. "apt-get dist-upgrade" says libmojolicious-plugin-openapi-perl has been kept back. but neither will do anything about it. and "do-dist-upgrade" says "Please install all available updates for your release before upgrading".
17:50 koha-jenkins Yippee, build fixed!
17:50 wahanui Congratulations!
17:50 koha-jenkins Project Koha_Master_D9 build #1488: FIXED in 52 min: https://jenkins.koha-community[…]a_Master_D9/1488/
18:03 koha-jenkins Yippee, build fixed!
18:03 wahanui Congratulations!
18:03 koha-jenkins Project Koha_Master_D10_Deps build #128: FIXED in 47 min: https://jenkins.koha-community[…]ter_D10_Deps/128/
18:13 inlibro joined #koha
18:21 koha-jenkins Yippee, build fixed!
18:21 wahanui Congratulations!
18:21 koha-jenkins Project Koha_Master_D10 build #397: FIXED in 55 min: https://jenkins.koha-community[…]a_Master_D10/397/
18:23 mtj hi magnuse,  koha 20.05.05 on Ubuntu 16.04.7 seems to install ok
18:27 koha-jenkins Yippee, build fixed!
18:27 wahanui Congratulations!
18:27 koha-jenkins Project Koha_Master_U18 build #938: FIXED in 47 min: https://jenkins.koha-community[…]a_Master_U18/938/
18:29 mtj magnuse: you can see a successful install here -> https://gitlab.com/mjames/ktd-[…]/-/jobs/832629355
18:30 amoyano left #koha
18:35 mtj https://wiki.koha-community.or[…]ersions_of_Debian.2FUbuntu_.28Debian_8.2C_Ubu​ntu_18.04.2C_Ubuntu_16.04.29
18:39 koha-jenkins Yippee, build fixed!
18:39 wahanui Congratulations!
18:39 koha-jenkins Project Koha_Master_U16 build #120: FIXED in 49 min: https://jenkins.koha-community[…]a_Master_U16/120/
18:41 josef_moravec joined #koha
18:49 magnuse mtj: thanks, but i seem to have run into some kind of catch 22. libmojolicious-plugin-openapi-perl is always kept back
18:49 magnuse when i try to go with the 19.11.11 i now have, plack is complaining about "Can't locate JSON/Validator/OpenAPI/Mojolicious.pm in @INC"
18:51 magnuse i got stuck on libmojolicious-plugin-openapi-perl and thought the solution would be to upgrade the ubuntu version
18:51 mtj hi magnuse, you have the correct apt repo line?
18:51 magnuse deb http://debian.koha-community.org/koha 19.11 main?
18:51 mtj 'deb http://debian.koha-community.org/koha 20.05 main xenial' etc?
18:52 magnuse uh oh, am i missing the version at the end then?
18:52 mtj magnuse: yeah ^
18:54 magnuse and it works! mtj, you are a hero!
18:54 magnuse mtj++
19:00 mtj no probs
19:13 inlibro joined #koha
19:16 enkidu joined #koha
19:58 hayley joined #koha
20:14 inlibro joined #koha
20:41 davidnind joined #koha
21:07 alexbuckley joined #koha
21:14 inlibro joined #koha
22:03 tuxayo oops
22:14 inlibro joined #koha
22:39 pastebot "davidnind" at 127.0.0.1 pasted "alexbuckley: for bug 25560 still one test failure for prove -v t/db_dependent/Circulation/issue.t" (10 lines) at http://paste.koha-community.org/26032
22:39 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=25560 enhancement, P5 - low, ---, alexbuckley, Needs Signoff , Exclude itemtypes from UpdateNotForLoanStatusOnCheckin
22:51 alexbuckley thank you for testing bug 25560 again davidnind!
22:51 huginn Bug http://bugs.koha-community.org[…]_bug.cgi?id=25560 enhancement, P5 - low, ---, alexbuckley, Needs Signoff , Exclude itemtypes from UpdateNotForLoanStatusOnCheckin
22:52 davidnind no problem, thanks for your perseverance! If the test failure is okay, happy to sign off
23:00 alexbuckley all good! I'd like to get that test failure fixed up. I'll run through it again
23:05 * dcook waves
23:07 alexbuckley hey dcook !
23:07 dcook allo haven't seen you around in ages
23:09 alexbuckley yeah we've been hammered with client work recently :( but since kohacon been trying to make time to get back into community work!
23:09 dcook I know the feeling
23:10 dcook I have so many things I want to do, but finding the time/energy...
23:12 alexbuckley yeah exactly too much to do - too little time! How are you going otherwise?
23:13 dcook Yeah pretty good overall. How about you?
23:14 inlibro joined #koha
23:14 alexbuckley glad to hear it! yeah I'm good thanks , I have enjoyed my remote working this year from the south island. you know what they say a change is as good as a rest and it was good spending time with family down there :)
23:15 dcook Aww that's really good to hear
23:15 dcook Yeah we have some changes in the works here as well
23:15 dcook I didn't get much remote working unfortunately, but it looks like we're getting a new office
23:16 dcook So I figure that change might be as good as a rest too heh
23:17 alexbuckley heh yeah that will be nice! whereabouts in Australia are you based?
23:17 dcook We're over in Sydney
23:17 dcook I hadn't realized that Catalyst had bought Calyx earlier this year either. I just learned about that at Kohacon
23:18 alexbuckley ahh thank goodness you missed out on the Victoria lockdowns
23:18 dcook Oh yeah very fortunate there
23:18 dcook Sydney really has had it quite good
23:19 dcook I think we had "lockdown" for... maybe 2 months?
23:19 dcook I actually liked working from home and going for exercise before and after work heh
23:19 dcook Working in the office now I'm not as fit but *shrug*
23:20 dcook Are you usually in Wellington too?
23:20 alexbuckley hehe same for me, did lots of walks when working from home but now not so much!
23:20 alexbuckley yeah usually work in the wellington catalyst office
23:21 alexbuckley yeah we had around a 7 week strict lockdown here , sad to see europe is going back into a second lockdown :(
23:25 dcook Agreed. I look at numbers in North America and Europe and it's sad making.
23:25 dcook Glad that I live in Australia but the rest of the world outside Oceania... yikes
23:26 dcook I say the rest of the world... but that's an assumption >_>
23:31 alexbuckley yeah pretty scary watching what's going on elsewhere, but you're right that is an assumption that we're identifying all the cases here in Oceania !
23:31 dcook Yeah there's that too
23:31 dcook Fortunately, most of the things I enjoy doing don't require other people heh
23:31 dcook I think I've actually been healthier thanks to quarantine as well
23:32 dcook Both in terms of physical fitness and general sickness
23:32 dcook I actually hope that many of the hygiene changes are maintained through the future even post-pandemic >_>
23:32 * dcook likes hand sanitizer and personal space in public
23:33 alexbuckley yeah it will be really interesting to see if hand sanitising continues once a vaccine is available, hope so - these are habits we should of had before!
23:34 dcook Absolutely

| Channels | #koha index | Today | | Search | Google Search | Plain-Text | plain, newest first | summary