| Time |
S |
Nick |
Message |
| 00:19 |
|
|
bdonnahue1 joined #koha |
| 00:30 |
|
|
inlibro joined #koha |
| 01:13 |
|
|
bdonnahue1 joined #koha |
| 01:30 |
|
|
inlibro joined #koha |
| 02:30 |
|
|
inlibro joined #koha |
| 03:30 |
|
|
inlibro joined #koha |
| 04:30 |
|
|
inlibro joined #koha |
| 04:43 |
|
|
davidnind joined #koha |
| 05:03 |
|
|
chriss joined #koha |
| 05:11 |
|
|
kathryn joined #koha |
| 05:31 |
|
|
inlibro joined #koha |
| 05:55 |
|
|
fridolin joined #koha |
| 06:02 |
|
|
lds joined #koha |
| 06:10 |
|
|
lmstrand joined #koha |
| 06:16 |
|
|
did joined #koha |
| 06:31 |
|
|
inlibro joined #koha |
| 06:35 |
|
|
reiveune joined #koha |
| 06:35 |
|
reiveune |
hello |
| 06:38 |
|
|
kathryn joined #koha |
| 06:39 |
|
|
magnuse joined #koha |
| 06:48 |
|
|
alex_a joined #koha |
| 06:49 |
|
alex_a |
Bonjour |
| 06:49 |
|
wahanui |
kia ora, alex_a |
| 07:07 |
|
|
magnuse joined #koha |
| 07:13 |
|
magnuse |
~o~ |
| 07:14 |
|
ashimema[m] |
Mornin' #koha |
| 07:16 |
|
magnuse |
hiya ashimema[m] |
| 07:31 |
|
|
inlibro joined #koha |
| 07:37 |
|
|
kathryn joined #koha |
| 07:46 |
|
|
alex_a_ joined #koha |
| 08:31 |
|
|
inlibro joined #koha |
| 08:35 |
|
|
cait joined #koha |
| 09:08 |
|
|
severine_q joined #koha |
| 09:26 |
|
|
rkrimme1 joined #koha |
| 09:30 |
|
rkrimme1 |
Hi, is anyone currently working on https://bugs.koha-community.or[…]_bug.cgi?id=14957 ? It says it's not compatible to be merged to current master. |
| 09:30 |
|
huginn |
Bug 14957: enhancement, P5 - low, ---, glasklas, Patch doesn't apply , Write protecting MARC fields based on source of import |
| 09:31 |
|
|
enkidu joined #koha |
| 09:31 |
|
|
inlibro joined #koha |
| 09:32 |
|
cait |
sadly, not that i know of |
| 09:32 |
|
cait |
do you mean it doesn't apply cleanly atm? |
| 09:33 |
|
cait |
glasglas has been great about rebasing it when asked, but he might be more inclined to do so when someone promises testing |
| 09:33 |
|
ashimema[m] |
glasglas.. is that his irc nick |
| 09:34 |
|
cait |
i am not sure |
| 09:34 |
|
ashimema[m] |
I can't remember what was holding that one back |
| 09:34 |
|
cait |
testing |
| 09:34 |
|
ashimema[m] |
I tried to help get it moving again, but I thought something was blocking it.. |
| 09:34 |
|
ashimema[m] |
but I can't see what |
| 09:34 |
|
cait |
i think basically it needs the testing - sign off and QA |
| 09:34 |
|
ashimema[m] |
ah yes.. |
| 09:35 |
|
ashimema[m] |
blocked by bug 25539 apparently |
| 09:35 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=25539 normal, P3, ---, glasklas, In Discussion , Remove AddBiblio "defer_marc_save" option |
| 09:35 |
|
ashimema[m] |
so you suggested cait |
| 09:36 |
|
ashimema[m] |
hmm |
| 09:36 |
|
|
fridolin joined #koha |
| 09:36 |
|
ashimema[m] |
looks like David put that one into discussion.. not sure why |
| 09:37 |
|
huginn |
News from kohagit: Bug 26145: Compiled CSS <http://git.koha-community.org/[…]001d287eb9210f594> |
| 09:37 |
|
huginn |
News from kohagit: Bug 26519: Compiled CSS <http://git.koha-community.org/[…]6ce427dbd12990062> |
| 09:37 |
|
huginn |
News from kohagit: Bug 26145: DBIC schema changes <http://git.koha-community.org/[…]0723918f6bf0bead8> |
| 09:37 |
|
huginn |
News from kohagit: Bug 26145: DBRev 20.06.00.049 <http://git.koha-community.org/[…]d5f5f3dcc09d8a7ee> |
| 09:37 |
|
huginn |
News from kohagit: Bug 26145: Add the new column to the column settings yml file <http://git.koha-community.org/[…]24116b6f2a8ed72a1> |
| 09:37 |
|
huginn |
News from kohagit: Bug 26145: (QA follow-up) Add missing filters <http://git.koha-community.org/[…]c03bfbc1c0f2aac1b> |
| 09:37 |
|
huginn |
News from kohagit: Bug 26503: Add limit for standing orders to acq advanced search <http://git.koha-community.org/[…]81b50978d88e94762> |
| 09:37 |
|
huginn |
News from kohagit: Bug 26503: Add unit tests <http://git.koha-community.org/[…]81fc2472e8fdb323c> |
| 09:37 |
|
huginn |
News from kohagit: Bug 26145: Correctly preserve itemnumber value <http://git.koha-community.org/[…]d29fb2f593d08879d> |
| 09:37 |
|
huginn |
News from kohagit: Bug 26145: Add the "Cover image" column to the table settings <http://git.koha-community.org/[…]f57cad6193effa460> |
| 09:37 |
|
huginn |
News from kohagit: Bug 26145: Hide 'Upload image' if no CoverImage pref is set <http://git.koha-community.org/[…]3358e97a5d73487c5> |
| 09:37 |
|
huginn |
News from kohagit: Bug 26145: Fix image tag <http://git.koha-community.org/[…]e078d306c104d446d> |
| 09:37 |
|
huginn |
News from kohagit: Bug 26145: Allow multi covers per item <http://git.koha-community.org/[…]6a73d13f3169d9ab4> |
| 09:37 |
|
huginn |
News from kohagit: Bug 26154: Remove the use of jquery.checkboxes plugin from batch item deletion and... <http://git.koha-community.org/[…]048cb1b12f653f7cf> |
| 09:37 |
|
huginn |
News from kohagit: Bug 26152: Remove the use of jquery.checkboxes plugin from serial collection page <http://git.koha-community.org/[…]b38ab7ac96df32945> |
| 09:37 |
|
huginn |
News from kohagit: Bug 26145: Refactoring - Move C4::Images to Koha::CoverImages <http://git.koha-community.org/[…]f6123b2ea02ef6d60> |
| 09:37 |
|
huginn |
News from kohagit: Bug 26145: Refactoring - Rename table biblioimages to cover_images <http://git.koha-community.org/[…]4d6e021e4d3c64e15> |
| 09:37 |
|
huginn |
News from kohagit: Bug 26145: Refactoring - Add tests <http://git.koha-community.org/[…]66a7527c7fd5b17a2> |
| 09:37 |
|
huginn |
News from kohagit: Bug 26145: Display the cover image at the OPAC <http://git.koha-community.org/[…]d2a2bfa178dbd9be6> |
| 09:37 |
|
huginn |
News from kohagit: Bug 26145: Add the ability to upload a cover image per item <http://git.koha-community.org/[…]5d2cf43dc9ee27c88> |
| 09:37 |
|
huginn |
News from kohagit: Bug 26145: DB changes - Add biblioimages.imagenumber <http://git.koha-community.org/[…]8107dc9f70778c49c> |
| 09:39 |
|
ashimema[m] |
I've poked the dependency to try and get an idea of what's holding it up :) |
| 09:39 |
|
ashimema[m] |
it's certainly a good one to get working |
| 09:40 |
|
cait |
thx ashimema[m] - i missed the dependency one |
| 09:40 |
|
ashimema[m] |
No worries |
| 09:41 |
|
ashimema[m] |
I've been following that one fairly closely.. although I'm not an expert in the code there I have been poking the right people to look at it whenever it seems ready to be looked at.. hehe |
| 09:41 |
|
ashimema[m] |
ere++, kidclamp++ |
| 09:48 |
|
* ashimema[m] |
is tired this morning |
| 09:48 |
|
rkrimme1 |
cait: We would be willing to test it, but we may need to setup some things first for running a patched master |
| 09:50 |
|
ashimema[m] |
I think it works.. it's more the dependency that's causing a hold up.. |
| 09:51 |
|
ashimema[m] |
making sure there aren't any unintended side effects is hard |
| 09:51 |
|
ashimema[m] |
:( |
| 09:56 |
|
cait |
testing would still give it a push |
| 09:56 |
|
ashimema[m] |
indeed |
| 09:56 |
|
cait |
rkrimme1: did you see the documentation page they wrote? it's really helpful |
| 09:56 |
|
cait |
rkrimme1: https://gitlab.com/gnucifer/ko[…]b2f350df00fec661f |
| 09:56 |
|
cait |
easy ot miss that in the many comments on the bug |
| 09:58 |
|
cait |
i got to step away for a bit, will be back later |
| 09:59 |
|
cait |
rkrimme1: for testing kohadevbox or koha-testing-docker are great |
| 09:59 |
|
cait |
i think most prefer koha-testing-docker at this point, I am still stuck on my old ways :) |
| 10:06 |
|
rkrimme1 |
Thanks alot1 |
| 10:06 |
|
rkrimme1 |
Thanks alot! |
| 10:08 |
|
|
alex_a joined #koha |
| 10:09 |
|
|
kohaputti joined #koha |
| 10:10 |
|
kohaputti |
Hi, do you also notice that this line looks wrong: https://github.com/Koha-Commun[…]culation.pm#L2834 Shouldn't it be next unless CanItemBeReserved($borrowernumber,$itemnumber)->{status} eq 'OK'; ? |
| 10:14 |
|
kohaputti |
We just bumped into this issue that you could renew items even if there was holds and it seems to be caused by this. |
| 10:15 |
|
* ashimema[m] |
will read momentarily |
| 10:16 |
|
kohaputti |
at least our library user reports doing this code fix blocks now renewals |
| 10:17 |
|
kohaputti |
but this bug has been here for many years so I'm uncertain because why would nobody else have bumped into this? |
| 10:19 |
|
ashimema[m] |
hmm |
| 10:19 |
|
ashimema[m] |
certainly looks like your right to me kohaputti |
| 10:19 |
|
Joubu |
yes kohaputti, looks like the line is wrong |
| 10:19 |
|
ashimema[m] |
how strange |
| 10:19 |
|
kohaputti |
ok, will file bug and attach the patch :) |
| 10:19 |
|
ashimema[m] |
indeed.. the line is wrong.. and kohaputti's suggested fix is right :) |
| 10:19 |
|
ashimema[m] |
bet it's a code path that's not tested ;) |
| 10:22 |
|
kohaputti |
ashimema[m], the other day I found code with Koka:: in it (supposed to be Koha::) |
| 10:22 |
|
kohaputti |
ashimema[m], gotta file a bug report for that too when I get to it... |
| 10:22 |
|
ashimema[m] |
:'( |
| 10:23 |
|
koha-jenkins |
Project Koha_Master_D9 build #1448: UNSTABLE in 44 min: https://jenkins.koha-community[…]a_Master_D9/1448/ |
| 10:25 |
|
Joubu |
koha-jenkins: link it with 15524 |
| 10:25 |
|
koha-jenkins |
Joubu did you mean me? Unknown command 'link' |
| 10:25 |
|
koha-jenkins |
Use '!koha-jenkins help' to get help! |
| 10:25 |
|
Joubu |
kohaputti: link it with 15524 |
| 10:25 |
|
ashimema[m] |
ooh |
| 10:25 |
|
ashimema[m] |
didn't realise koha-jenkins could talk |
| 10:25 |
|
|
cait joined #koha |
| 10:28 |
|
koha-jenkins |
Project Koha_Master_D9_MDB_Latest build #406: UNSTABLE in 50 min: https://jenkins.koha-community[…]9_MDB_Latest/406/ |
| 10:29 |
|
|
AnkeB joined #koha |
| 10:29 |
|
ashimema[m] |
bug 15524 |
| 10:30 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=15524 enhancement, P5 - low, ---, kyle, RESOLVED FIXED, Set limit on maximum possible holds per patron by category |
| 10:30 |
|
koha-jenkins |
Project Koha_Master_U20 build #111: UNSTABLE in 51 min: https://jenkins.koha-community[…]a_Master_U20/111/ |
| 10:31 |
|
|
inlibro joined #koha |
| 10:34 |
|
Joubu |
oops |
| 10:37 |
|
koha-jenkins |
Project Koha_Master_D9_My8 build #431: UNSTABLE in 1 hr 0 min: https://jenkins.koha-community[…]aster_D9_My8/431/ |
| 10:37 |
|
huginn |
News from kohagit: Bug 26145: Add exec flag on .t file <http://git.koha-community.org/[…]529e38504125715cf> |
| 10:37 |
|
huginn |
News from kohagit: Bug 26145: (follow-up) DBIC schema changes <http://git.koha-community.org/[…]0dfc8dc56ee5ee4d7> |
| 10:38 |
|
|
oleonard joined #koha |
| 11:06 |
|
koha-jenkins |
Project Koha_Master_U18 build #911: UNSTABLE in 42 min: https://jenkins.koha-community[…]a_Master_U18/911/ |
| 11:14 |
|
koha-jenkins |
Project Koha_Master_D10_Deps build #91: UNSTABLE in 46 min: https://jenkins.koha-community[…]ster_D10_Deps/91/ |
| 11:21 |
|
koha-jenkins |
Project Koha_Master_D10 build #367: UNSTABLE in 50 min: https://jenkins.koha-community[…]a_Master_D10/367/ |
| 11:32 |
|
|
inlibro joined #koha |
| 11:33 |
|
koha-jenkins |
Project Koha_Master_U16 build #80: STILL UNSTABLE in 56 min: https://jenkins.koha-community[…]ha_Master_U16/80/ |
| 11:47 |
|
|
TimothyAlexis joined #koha |
| 11:47 |
|
koha-jenkins |
Project Koha_Master_D11 build #105: UNSTABLE in 41 min: https://jenkins.koha-community[…]a_Master_D11/105/ |
| 11:50 |
|
kohaputti |
filed bug 26659 for the renwal issue |
| 11:50 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=26659 normal, P5 - low, ---, koha-bugs, NEW , An item can be renewed even if there are holds waiting to be filled |
| 11:50 |
|
kohaputti |
Gotta still come up with a test plan. |
| 11:51 |
|
kohaputti |
The issue happened in quite complex scenario |
| 12:05 |
|
koha-jenkins |
Project Koha_Master_D9_MDB_Latest build #407: STILL UNSTABLE in 50 min: https://jenkins.koha-community[…]9_MDB_Latest/407/ |
| 12:10 |
|
koha-jenkins |
Project Koha_Master_U2010 build #22: UNSTABLE in 48 min: https://jenkins.koha-community[…]_Master_U2010/22/ |
| 12:16 |
|
koha-jenkins |
Project Koha_Master_U18 build #912: FAILURE in 6 min 3 sec: https://jenkins.koha-community[…]a_Master_U18/912/ |
| 12:29 |
|
koha-jenkins |
Project Koha_Master_U20 build #112: STILL UNSTABLE in 55 min: https://jenkins.koha-community[…]a_Master_U20/112/ |
| 12:31 |
|
koha-jenkins |
Project Koha_Master_D9 build #1449: STILL UNSTABLE in 44 min: https://jenkins.koha-community[…]a_Master_D9/1449/ |
| 12:32 |
|
|
inlibro joined #koha |
| 12:48 |
|
Joubu |
hum... |
| 12:49 |
|
Joubu |
I've been pretty this morning trying to fix the failures! |
| 12:49 |
|
|
fridolin joined #koha |
| 12:49 |
|
koha-jenkins |
Project Koha_Master_D10_Deps build #92: ABORTED in 19 min: https://jenkins.koha-community[…]ster_D10_Deps/92/ |
| 12:49 |
|
koha-jenkins |
Project Koha_Master_D10 build #368: ABORTED in 17 min: https://jenkins.koha-community[…]a_Master_D10/368/ |
| 12:49 |
|
koha-jenkins |
Project Koha_Master_D9_My8 build #432: ABORTED in 44 min: https://jenkins.koha-community[…]aster_D9_My8/432/ |
| 12:49 |
|
koha-jenkins |
Project Koha_Master_U16 build #81: ABORTED in 9 min 2 sec: https://jenkins.koha-community[…]ha_Master_U16/81/ |
| 12:50 |
|
huginn |
News from kohagit: Bug 26529: (follow-up) Remove warning <http://git.koha-community.org/[…]7e9f42c62f2e3348b> |
| 12:50 |
|
huginn |
News from kohagit: Bug 26145: (follow-up 2) DBIC schema changes <http://git.koha-community.org/[…]ab571b1b8afaca475> |
| 12:53 |
|
koha-jenkins |
Project Koha_Master_U16 build #82: FAILURE in 2 min 28 sec: https://jenkins.koha-community[…]ha_Master_U16/82/ |
| 12:54 |
|
koha-jenkins |
Project Koha_Master_D11 build #106: FAILURE in 3 min 2 sec: https://jenkins.koha-community[…]a_Master_D11/106/ |
| 13:11 |
|
kohaputti |
ashimema[m], ooh, huge thanks for the QA in bug 12556 :P |
| 13:11 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=12556 enhancement, P5 - low, ---, joonas.kylmala, Passed QA , SelfCheck machine starts the hold instantly with an email sent out |
| 13:11 |
|
ashimema[m] |
pleasure |
| 13:11 |
|
ashimema[m] |
thanks for taking it on.. |
| 13:15 |
|
kohaputti |
now if this get pushed there is a follow-up bug for this regarding holds in transfer state, currently anybody can "steal" others' holds that are on transfer. |
| 13:16 |
|
ashimema[m] |
indeed. |
| 13:16 |
|
ashimema[m] |
transfers has all sorts of issues to be honest.. |
| 13:16 |
|
ashimema[m] |
hence I've been working through it on a big tree of bugs |
| 13:16 |
|
ashimema[m] |
but there's still a little way to go |
| 13:16 |
|
kohaputti |
it needs some refactoring there so I will add some patches for it :) |
| 13:16 |
|
ashimema[m] |
the more I fix, the more I find broken :( |
| 13:16 |
|
ashimema[m] |
trasnfers you mean? |
| 13:16 |
|
kohaputti |
yes |
| 13:17 |
|
ashimema[m] |
or the holds in transfer |
| 13:17 |
|
kohaputti |
the transfer handling in sip, sco, intranet |
| 13:17 |
|
kohaputti |
holds in transfer I guess |
| 13:17 |
|
ashimema[m] |
ooh |
| 13:17 |
|
ashimema[m] |
indeed |
| 13:17 |
|
ashimema[m] |
one moment |
| 13:19 |
|
kohaputti |
ashimema[m], the instant notification bug had patch for preventing the checkouts of holds in processing, the same way holds in waiting were blocked, it would be one line change to block now holds in transfer too in SIP |
| 13:19 |
|
ashimema[m] |
ah, yeah.. |
| 13:19 |
|
ashimema[m] |
OK |
| 13:19 |
|
ashimema[m] |
I was worried you were going to dig deep into Transfers in general |
| 13:20 |
|
ashimema[m] |
if you were, I'd have said please take a look at my work in progress tree: https://github.com/Koha-Commun[…]envoize:bug_22569 |
| 13:20 |
|
kohaputti |
I think I will, I hate that SIP has it's own handling, and that sco and intranet are not handled the same |
| 13:20 |
|
kohaputti |
I will take a look before proceeding, thanks :) |
| 13:20 |
|
ashimema[m] |
I agree |
| 13:21 |
|
ashimema[m] |
it's likely way out of scope.. and I'm happy to rebase atop whatever you do |
| 13:21 |
|
ashimema[m] |
I ended up down a rabbit hole.. trying to move transfers code into Koha:: and fix a bunch of bugs in it at the same time |
| 13:21 |
|
kohaputti |
hmm, ok, I think I want to go the refactoring way, let me know when ready for qa :) |
| 13:22 |
|
kohaputti |
actually, I will add myself in CC |
| 13:22 |
|
ashimema[m] |
brill, that would be great :) |
| 13:22 |
|
ashimema[m] |
that's given me the motivation to pick it back up again.. I had been struggling for a few days to find that motivation again |
| 13:24 |
|
kohaputti |
just got report from library that the syspref cache clearing fix in bug 23640 doesn't work anymore, gotta investigate that too |
| 13:24 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=23640 major, P5 - low, ---, jonathan.druart, Pushed to oldstable , L1 cache too long in SIP Server |
| 13:29 |
|
kohaputti |
hmm, maybe the cache is cleared on every connection, but it should probably be on every SIP message. |
| 13:32 |
|
|
inlibro joined #koha |
| 13:33 |
|
|
cait joined #koha |
| 13:37 |
|
koha-jenkins |
Yippee, build fixed! |
| 13:37 |
|
wahanui |
Congratulations! |
| 13:37 |
|
koha-jenkins |
Project Koha_Master_D9_MDB_Latest build #408: FIXED in 43 min: https://jenkins.koha-community[…]9_MDB_Latest/408/ |
| 13:39 |
|
koha-jenkins |
Yippee, build fixed! |
| 13:39 |
|
wahanui |
Congratulations! |
| 13:39 |
|
koha-jenkins |
Project Koha_Master_U2010 build #23: FIXED in 48 min: https://jenkins.koha-community[…]_Master_U2010/23/ |
| 13:44 |
|
koha-jenkins |
Yippee, build fixed! |
| 13:44 |
|
wahanui |
Congratulations! |
| 13:44 |
|
koha-jenkins |
Project Koha_Master_D9 build #1450: FIXED in 50 min: https://jenkins.koha-community[…]a_Master_D9/1450/ |
| 13:54 |
|
koha-jenkins |
Yippee, build fixed! |
| 13:54 |
|
wahanui |
Congratulations! |
| 13:54 |
|
koha-jenkins |
Project Koha_Master_D9_My8 build #433: FIXED in 1 hr 2 min: https://jenkins.koha-community[…]aster_D9_My8/433/ |
| 14:13 |
|
ashimema[m] |
anyone got any thoughts on bug 26593 |
| 14:13 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=26593 normal, P5 - low, ---, koha-bugs, NEW , Rental discounts are applied in wrong precedence order |
| 14:14 |
|
ashimema[m] |
It feels like an accidental error, but I'm wondering if anyone is seeing it as a feature |
| 14:16 |
|
cait |
can you explain in a few words? |
| 14:17 |
|
ashimema[m] |
basically the circ rules pertaining to IssuingCharges are not consistent, with the way they fallback through defaults etc, with any of the other circ rules |
| 14:17 |
|
ashimema[m] |
the first comment on the bug is pretty clear |
| 14:18 |
|
ashimema[m] |
the fix is easy.. but it'll change the precedence for existing installs |
| 14:18 |
|
koha-jenkins |
Project Koha_Master_U20 build #113: STILL UNSTABLE in 41 min: https://jenkins.koha-community[…]a_Master_U20/113/ |
| 14:23 |
|
cait |
i think it sounds like a bug - they shoudl follow the same rules |
| 14:23 |
|
cait |
the current precendence is undcomented... so I feel a release notes comment might be ok in that case? |
| 14:25 |
|
ashimema[m] |
:) |
| 14:25 |
|
ashimema[m] |
cool.. i was hoping that would be the case |
| 14:28 |
|
koha-jenkins |
Yippee, build fixed! |
| 14:28 |
|
wahanui |
Congratulations! |
| 14:28 |
|
koha-jenkins |
Project Koha_Master_U18 build #913: FIXED in 48 min: https://jenkins.koha-community[…]a_Master_U18/913/ |
| 14:30 |
|
koha-jenkins |
Yippee, build fixed! |
| 14:30 |
|
wahanui |
Congratulations! |
| 14:30 |
|
koha-jenkins |
Project Koha_Master_D10 build #369: FIXED in 45 min: https://jenkins.koha-community[…]a_Master_D10/369/ |
| 14:32 |
|
|
inlibro joined #koha |
| 14:47 |
|
koha-jenkins |
Yippee, build fixed! |
| 14:47 |
|
wahanui |
Congratulations! |
| 14:47 |
|
koha-jenkins |
Project Koha_Master_D10_Deps build #93: FIXED in 53 min: https://jenkins.koha-community[…]ster_D10_Deps/93/ |
| 15:00 |
|
koha-jenkins |
Yippee, build fixed! |
| 15:00 |
|
wahanui |
Congratulations! |
| 15:00 |
|
koha-jenkins |
Project Koha_Master_D11 build #107: FIXED in 41 min: https://jenkins.koha-community[…]a_Master_D11/107/ |
| 15:09 |
|
|
fridolin left #koha |
| 15:15 |
|
koha-jenkins |
Yippee, build fixed! |
| 15:15 |
|
wahanui |
Congratulations! |
| 15:15 |
|
koha-jenkins |
Project Koha_Master_U16 build #83: FIXED in 47 min: https://jenkins.koha-community[…]ha_Master_U16/83/ |
| 15:18 |
|
koha-jenkins |
Project Koha_Master_U18 build #914: SUCCESS in 47 min: https://jenkins.koha-community[…]a_Master_U18/914/ |
| 15:21 |
|
kohaputti |
Joubu, are you aware that Circulation.t fails currently? |
| 15:22 |
|
Joubu |
pull |
| 15:23 |
|
kohaputti |
I have the latest version, nothing new to fetch from git |
| 15:24 |
|
kohaputti |
I have to go now unfortunately, I will continue debugging tomorrow if still persist, could be something I have messed up in my configs |
| 15:25 |
|
Joubu |
kohaputti: t/db_dependent/Circulation.t passes for me |
| 15:26 |
|
Joubu |
c12ede482f Bug 26529: (follow-up) Remove warning |
| 15:26 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=26529 major, P5 - low, ---, nick, Pushed to master , Holds rules enforced incorrectly when not set at library level |
| 15:26 |
|
Joubu |
(you need this last commit or Circulation.t will fail) |
| 15:26 |
|
kohaputti |
Joubu, do I need misc4devel updates? |
| 15:26 |
|
Joubu |
no |
| 15:26 |
|
kohaputti |
ok, I have that last commit |
| 15:27 |
|
kohaputti |
will try reset_all once more |
| 15:29 |
|
kohaputti |
Joubu, issue in my configuration, I ran git revert HEAD~1 instead of git revert HEAD with my own changes for bug 26659 |
| 15:29 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=26659 major, P5 - low, ---, joonas.kylmala, Needs Signoff , An item can be renewed even if there are holds waiting to be filled |
| 15:29 |
|
kohaputti |
it seems to break a whole lot of things |
| 15:31 |
|
Joubu |
yes, silly mistake from me.. |
| 15:32 |
|
|
inlibro joined #koha |
| 15:36 |
|
kohaputti |
Joubu, hmm, if the change from bug 26659 breaks so many tests from Circulation.t then there might be a big issue here |
| 15:36 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=26659 major, P5 - low, ---, joonas.kylmala, ASSIGNED , An item can be renewed even if there are holds waiting to be filled |
| 15:37 |
|
kohaputti |
or maybe the tests are just missing some circulation rules |
| 15:39 |
|
kohaputti |
well, I will investigate tomorrow --> |
| 15:39 |
|
Joubu |
yes, that seems bad |
| 15:39 |
|
Joubu |
or maybe the tests don't init the data correctly |
| 15:39 |
|
Joubu |
bye kohaputti, have a great evening! |
| 15:39 |
|
kohaputti |
yes, hopefully just that |
| 15:39 |
|
kohaputti |
you too, bye! |
| 16:33 |
|
|
inlibro joined #koha |
| 16:43 |
|
reiveune |
bye |
| 16:43 |
|
|
reiveune left #koha |
| 16:51 |
|
cait |
without looking at the code... there are cases where holds don't block renewals - if there are other available items |
| 16:52 |
|
cait |
pref thing |
| 17:33 |
|
|
inlibro joined #koha |
| 18:33 |
|
|
inlibro joined #koha |
| 19:13 |
|
|
kathryn joined #koha |
| 19:20 |
|
|
deb-CSPL joined #koha |
| 19:33 |
|
|
inlibro joined #koha |
| 19:46 |
|
|
hayley joined #koha |
| 19:56 |
|
|
alexbuckley joined #koha |
| 20:15 |
|
|
enkidu joined #koha |
| 20:23 |
|
aleisha |
hello |
| 20:25 |
|
|
enkidu1 joined #koha |
| 20:33 |
|
|
inlibro joined #koha |
| 21:33 |
|
|
inlibro joined #koha |
| 22:09 |
|
|
aleisha_ joined #koha |
| 22:34 |
|
|
inlibro joined #koha |
| 23:34 |
|
|
inlibro joined #koha |
| 23:35 |
|
dcook |
hola aleisha |
| 23:35 |
|
* dcook |
just glares at the authority code for a bit heh |
| 23:36 |
|
aleisha |
hi dcook :) |
| 23:47 |
|
dcook |
tfw you find a bug and really don't want to fix it lol.. |
| 23:50 |
|
|
kathryn_ joined #koha |
