| Time |
S |
Nick |
Message |
| 00:08 |
|
|
alexbuckley_ joined #koha |
| 00:16 |
|
|
alexbuckley joined #koha |
| 00:23 |
|
|
inlibro joined #koha |
| 00:48 |
|
|
cait1 joined #koha |
| 00:53 |
|
|
aleisha_ joined #koha |
| 01:23 |
|
|
inlibro joined #koha |
| 02:23 |
|
|
inlibro joined #koha |
| 03:23 |
|
|
inlibro joined #koha |
| 04:08 |
|
|
alexbuckley joined #koha |
| 04:23 |
|
|
inlibro joined #koha |
| 04:59 |
|
aleisha_ |
recalls is ready for testing, yet again :) |
| 04:59 |
|
aleisha_ |
bug 19532 |
| 04:59 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=19532 new feature, P1 - high, ---, aleisha, Needs Signoff , Recalls for Koha |
| 05:06 |
|
|
chriss joined #koha |
| 05:24 |
|
|
inlibro joined #koha |
| 05:31 |
|
|
did joined #koha |
| 05:59 |
|
ashimema |
mornin' #koha |
| 06:05 |
|
|
marcelr joined #koha |
| 06:05 |
|
marcelr |
hi #koha |
| 06:15 |
|
|
lmstrand joined #koha |
| 06:24 |
|
|
inlibro joined #koha |
| 06:34 |
|
|
reiveune joined #koha |
| 06:34 |
|
reiveune |
hello |
| 06:54 |
|
magnuse |
aleisha++ |
| 06:54 |
|
magnuse |
@karma |
| 06:54 |
|
huginn |
magnuse: Highest karma: "Joubu" (872), "cait" (804), and "ashimema" (554). Lowest karma: "-" (-63), "failed" (-43), and "ie" (-38). You (magnuse) are ranked 16 out of 1052. |
| 06:55 |
|
ashimema |
ie-- |
| 07:00 |
|
|
cait joined #koha |
| 07:01 |
|
|
JBoyer joined #koha |
| 07:04 |
|
|
lds joined #koha |
| 07:06 |
|
|
fridolin joined #koha |
| 07:07 |
|
Joubu |
@later tell lukeG I don't think you need 26138 for 20.05, Koha::Plugins->call does not exist |
| 07:07 |
|
huginn |
Joubu: The operation succeeded. |
| 07:17 |
|
|
magnuse joined #koha |
| 07:24 |
|
|
inlibro joined #koha |
| 07:33 |
|
Joubu |
Can someone point me out where is the code to unset itemlost when an item is checked in? |
| 07:34 |
|
Joubu |
ha! C4::Items::ModDateLastSeen |
| 07:34 |
|
Joubu |
lol |
| 07:34 |
|
cait |
ouch |
| 07:34 |
|
cait |
bbl for qa |
| 08:24 |
|
|
inlibro joined #koha |
| 08:26 |
|
ashimema |
lol |
| 08:26 |
|
ashimema |
morning Joubu |
| 08:26 |
|
ashimema |
I see you're back on bug 18501 |
| 08:27 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=18501 major, P5 - low, ---, jonathan.druart, In Discussion , Automatic refunds need protection from failure |
| 08:27 |
|
ashimema |
it's a mess isn't it :( |
| 08:27 |
|
ashimema |
sorry.. didn't mean to send you into that rabbit hole.. it all sounded half reasonable when I scratched the surface |
| 08:28 |
|
Joubu |
@later mtj can you have a look at https://tree.taiga.io/project/koha-ils/task/78 and give me an answer please? |
| 08:28 |
|
huginn |
Joubu: I suck |
| 08:28 |
|
Joubu |
@later tell mtj can you have a look at https://tree.taiga.io/project/koha-ils/task/78 and give me an answer please? |
| 08:28 |
|
huginn |
Joubu: The operation succeeded. |
| 08:28 |
|
Joubu |
me too |
| 08:28 |
|
ashimema |
I'm wondering if we aught to stick to your original patchset, get 18501 + 23091 in and then do the cleanup/refactor piece as a new bug... |
| 08:28 |
|
ashimema |
though I'd love to just 'get it done'.. I'm not sure how important the initial bug is to 'just get fixed' to start with |
| 08:28 |
|
Joubu |
ashimema: it depends, do you think there is a reasonable solution to guess if there was a refund? |
| 08:28 |
|
Joubu |
seen my last patch, from this morning? |
| 08:28 |
|
wahanui |
I haven't seen 'my', Joubu |
| 08:29 |
|
ashimema |
just seen it come in, but not looked at it yet |
| 08:29 |
|
ashimema |
was still reviewing the initial stuff |
| 08:29 |
|
Joubu |
if we handle that, we are sure to handle 100% of the cases. So it feels the way to go |
| 08:30 |
|
ashimema |
super scary that 'DateLastSeen' is used to undset the itemlost |
| 08:30 |
|
ashimema |
weird action at a distance. |
| 08:31 |
|
ashimema |
as for the refunded.. that's where I reckon we come back to fluent interfaces |
| 08:33 |
|
ashimema |
i.e. we continue to just return the updated Koha::Item object from ->store but we have set an internal variable in the trigger so we can get back if it triggered a refund via an additional accessor |
| 08:33 |
|
ashimema |
I was on the case for that with the prior version before we diverted to triggers.. shouldn't be too hard |
| 08:33 |
|
Joubu |
seen the search query I am trying to build? |
| 08:33 |
|
wahanui |
I haven't seen 'the', Joubu |
| 08:34 |
|
Joubu |
+ #my $refunded = Koha::Account::Lines->search{(itemnumber => $item->itemnumber, type => 'LOST_FOUND', # FIXME which other parameters to know it has been refunded? |
| 08:34 |
|
ashimema |
yeah.. I'm not so sure about that approach |
| 08:34 |
|
ashimema |
there is a query I believe.. got a feeling it's already embedded within the old _FixAccountForLostAndReturned method to attempt to prevent dupes |
| 08:35 |
|
ashimema |
but I still reckon setting an internal attribute in the Koha::Object is clearer |
| 08:35 |
|
Joubu |
yes but here we are after the refund |
| 08:36 |
|
ashimema |
balls.. ModDateLastSeen doesn't give back an updated Koha::Item! |
| 08:36 |
|
Joubu |
ashimema: ok, I am good with the internal variable. But it's risky, we need to retrieve the flag after the correct store |
| 08:36 |
|
ashimema |
now I see where it falls down |
| 08:36 |
|
Joubu |
and be sure there won't be a fetch in the meanwhile |
| 08:36 |
|
ashimema |
does a fetch in the meantime matter? |
| 08:37 |
|
* ashimema |
tries to remember how our re-fetching works.. |
| 08:37 |
|
Joubu |
if $item is modified, you will loose the internal var |
| 08:37 |
|
ashimema |
we just rebuild the internal _result don't we.. so as long as the variable is set at the same level as _result instead of within _result then we should be OK |
| 08:38 |
|
Joubu |
yes, but $item = something_else() and... |
| 08:38 |
|
ashimema |
in this case.. yes |
| 08:38 |
|
ashimema |
it does |
| 08:38 |
|
Joubu |
sorry but getting back to the query |
| 08:38 |
|
Joubu |
http://paste.koha-community.org/25184 |
| 08:38 |
|
Joubu |
it's the debit then credit |
| 08:39 |
|
Joubu |
shouldn't we have issue_id on the credit? |
| 08:39 |
|
Joubu |
well, the debit for the library. id=2 |
| 08:39 |
|
Joubu |
that would help a lot |
| 08:39 |
|
ashimema |
probably |
| 08:39 |
|
wahanui |
i think probably is too hard. |
| 08:40 |
|
ashimema |
likely it was just an oversight not to record it.. |
| 08:40 |
|
Joubu |
it's not obvious how those 2 lines are linked together |
| 08:40 |
|
ashimema |
they clearly tried with the weird way they add it into description |
| 08:40 |
|
ashimema |
I think issue_id didn't exist as it's own field when the code was originally written around there.. and just never got updated |
| 08:41 |
|
Joubu |
it's the barcode, it's not enough for unicity |
| 08:41 |
|
ashimema |
it's the barcod if you pass a barcode |
| 08:41 |
|
ashimema |
which in my memory was almost never |
| 08:41 |
|
ashimema |
in most cases it fell back to itemnumber |
| 08:41 |
|
ashimema |
oh.. which is also not the same. |
| 08:41 |
|
wahanui |
okay, ashimema. |
| 08:41 |
|
ashimema |
lol |
| 08:42 |
|
Joubu |
- my $item_id = @_ ? shift : $itemnumber; # Send the barcode if you want that logged in the description |
| 08:42 |
|
ashimema |
I'm sure we can add issue_id in.. |
| 08:42 |
|
Joubu |
are you talking about that? |
| 08:42 |
|
Joubu |
I ignored it when I moved _FixAccountForLostAndFound, because I don't think we pass the barcode |
| 08:42 |
|
ashimema |
yeah.. my fingers were typing faster than my brain was thinking it through ;) |
| 08:42 |
|
ashimema |
yeah.. I agree with you on ignoring that |
| 08:42 |
|
Joubu |
we call add_credit with item_id => $itemnumber from this sub |
| 08:43 |
|
Joubu |
ok |
| 08:43 |
|
ashimema |
anywho.. it would be easy enough to get the issue_id in the credit |
| 08:43 |
|
Joubu |
I am not confident here :-/ |
| 08:43 |
|
ashimema |
issue_id => $accountline->issue_id |
| 08:44 |
|
Joubu |
and... third question... did you investigate holdingbranch? |
| 08:44 |
|
Joubu |
where does it come from? |
| 08:44 |
|
ashimema |
it assumes that the issue_id was properly set |
| 08:44 |
|
ashimema |
I did.. I can't see that holdingbranch was ever actually used anywhere |
| 08:44 |
|
ashimema |
ooh.. I have a meeting |
| 08:45 |
|
Joubu |
enjoy ;) |
| 08:45 |
|
ashimema |
I can mostly just listen in |
| 08:45 |
|
ashimema |
I'll have a dig around |
| 08:47 |
|
ashimema |
I wasn't entirely sure about your trigger for the trigger btw.. |
| 08:47 |
|
ashimema |
we're trying to trigger on found.. but it looks like you have the logic reversed.. |
| 08:48 |
|
ashimema |
i.e `$updated_columns{itemlost} >= 1` looks reversed |
| 08:48 |
|
ashimema |
shouldn't it be checking for NOT 1 or greater than 1 (i.e '0' or 'unset') |
| 08:49 |
|
ashimema |
I also wasn't entirely sure about resetting paidfor.. was that always an effect of unsetting itemlost? |
| 08:50 |
|
Joubu |
it's coming from the original sub |
| 08:50 |
|
Joubu |
$accountline->item->paidfor('')->store({ log_action => 0 }); |
| 08:50 |
|
ashimema |
oh cool |
| 08:50 |
|
ashimema |
ta |
| 08:51 |
|
ashimema |
and what about the condition.. ? |
| 08:52 |
|
Joubu |
2 new patches attached |
| 08:53 |
|
ashimema |
ooh.. cool |
| 08:54 |
|
|
dcook joined #koha |
| 08:54 |
|
ashimema |
looks good to me |
| 08:54 |
|
ashimema |
I can have a bit of a testing run today |
| 08:55 |
|
ashimema |
generally it looks reasonable as a whole |
| 08:55 |
|
* ashimema |
is also trying to keep bug 23091 in the back of his mind with all this |
| 08:55 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=23091 enhancement, P5 - low, ---, martin.renvoize, Signed Off , Add options to charge new or restore forgiven overdues when a lost item is returned |
| 09:15 |
|
ashimema |
dare I ask the question.. are there ever any reasons librarians would want to NOT refund and so have been using the cataloging way of marking an item as unlost to deliberately circumvent a refund? |
| 09:15 |
|
|
kohaputti joined #koha |
| 09:18 |
|
kohaputti |
wouldn't it make sense to merge biblio and biblio_metadata tables? Now we create this complex glue in koha objects to make it appear as one single object, but with it all being in one biblio table it would be so much simpler. |
| 09:18 |
|
kohaputti |
Could it have been performance reasons why it was split? |
| 09:19 |
|
Joubu |
yes |
| 09:20 |
|
Joubu |
it also brings the ability to define several "metadata", we could store several representation of the record |
| 09:20 |
|
Joubu |
which we don't do so far |
| 09:20 |
|
|
cait joined #koha |
| 09:20 |
|
Joubu |
see bug 17196 comment 0 |
| 09:20 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=17196 enhancement, P5 - low, ---, jonathan.druart, CLOSED FIXED, Move marcxml out of the biblioitems table |
| 09:24 |
|
|
inlibro joined #koha |
| 09:26 |
|
kohaputti |
Joubu, thanks for the background. I wonder why is it so that there is performance hit, maybe I need to learn more about databases. |
| 09:28 |
|
ashimema |
I think it's because we hardly every limit which fields we pull back so we're always returning huge globs from the marcxml field |
| 09:28 |
|
ashimema |
Even when often time's we weren't actually refering to the data in them |
| 09:29 |
|
ashimema |
Now we only actually grab the data at the point of needing it |
| 09:29 |
|
kohaputti |
ashimema, in the bug report Joubu linked there was the example "SELECT publicationyear, count(publicationyear) FROM biblioitems GROUP BY publicationyear;" which was orders of magnitude slower without the split |
| 09:29 |
|
kohaputti |
so there is something else |
| 09:30 |
|
ashimema |
interseting.. I forget.. it was a while ago now ;) |
| 09:31 |
|
kohaputti |
https://stackoverflow.com/ques[…]-filesystem-cache |
| 09:32 |
|
kohaputti |
the solution answer there is exactly what we have :D |
| 09:35 |
|
ashimema |
Joubu |
| 09:35 |
|
ashimema |
ModDateLastSeen is called in CanBookBeIssued.. and it doesn't forbid the itemlost update |
| 09:36 |
|
ashimema |
that seems a bit scary and odd and could have repercussions here couldn't it? |
| 09:39 |
|
Joubu |
hard to say |
| 09:40 |
|
ashimema |
mm |
| 09:40 |
|
Joubu |
I think it's correct |
| 09:40 |
|
Joubu |
it's used for "stats" |
| 09:40 |
|
ashimema |
yeah |
| 09:40 |
|
Joubu |
but the item is "found" I'd say |
| 09:40 |
|
Joubu |
cannot remember the use case actually |
| 09:41 |
|
ashimema |
I find the whole idea that one can update the 'date last seen' without actually marking the item as found a bit nuts |
| 09:41 |
|
ashimema |
locally is flawed |
| 09:42 |
|
Joubu |
coming from bug 4369 |
| 09:42 |
|
huginn |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=4369 normal, P5 - low, ---, koha.sekjal, CLOSED FIXED, Local use does not update datelastseen |
| 09:43 |
|
Joubu |
if the $leave_item_lost is on, that's what you mean? |
| 09:43 |
|
ashimema |
feels like it should still rely on 'BlockReturnOfLostItems' pref to me |
| 09:43 |
|
ashimema |
yup |
| 09:43 |
|
ashimema |
that's what I mean |
| 09:43 |
|
Joubu |
Bug 21231: BlockReturnofLostItems does not prevent lost items being found |
| 09:43 |
|
Joubu |
|
| 09:43 |
|
Joubu |
When the syspref BlockReturnOfLostItems is set to Block, the item is blocked from being returned, but is still considered found -- it's set to lost=0 and a refund is applied to the patron (if circ rules allo |
| 09:43 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=21231 major, P5 - low, ---, kyle, CLOSED FIXED, BlockReturnofLostItems does not prevent lost items being found |
| 09:44 |
|
Joubu |
w). The item can then be checked in a second time and returned as it is no longer lost. |
| 09:45 |
|
Joubu |
it does what you want, but ModDateLastSeen is called from other places |
| 09:46 |
|
ashimema |
indeed |
| 09:46 |
|
ashimema |
there are logical holes |
| 09:46 |
|
ashimema |
grr |
| 09:47 |
|
ashimema |
offline circ also returns the item regardless |
| 09:48 |
|
ashimema |
I feel like in all cases we should flag to the user that the item was marked as lost and ask them what to do |
| 09:48 |
|
ashimema |
mwah.. that's for another bug |
| 09:56 |
|
marcelr |
bug 18958 |
| 09:56 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=18958 major, P5 - low, ---, kyle, Failed QA , If patron has multiple record level holds on one record transferring first hold causes next hold to become item level |
| 09:57 |
|
marcelr |
holds are fun ;) |
| 09:57 |
|
marcelr |
bye #koha |
| 10:08 |
|
ashimema |
I've tested those patches so far Joubu and am happy with them |
| 10:09 |
|
ashimema |
are you taking care of the remaining unit tests or would you like me to have a stab? |
| 10:13 |
|
Joubu |
I need a break from this one actually :) |
| 10:13 |
|
Joubu |
but I can come back to it later |
| 10:14 |
|
Joubu |
I think we will need to ask tcohen and kidclamp for help/review |
| 10:14 |
|
ashimema |
I'm happy to correct the unit tests whilst me head is in it. |
| 10:14 |
|
tcohen |
morning |
| 10:14 |
|
ashimema |
so feel free to break from it Joubu |
| 10:24 |
|
|
inlibro joined #koha |
| 10:35 |
|
|
khall joined #koha |
| 10:39 |
|
|
fridolin joined #koha |
| 10:54 |
|
cait |
hi all |
| 10:55 |
|
magnuse |
hiya cait |
| 10:57 |
|
cait |
hi all |
| 10:57 |
|
cait |
repeating myself... *blames vacation* |
| 10:57 |
|
ashimema |
mornin' cait |
| 10:57 |
|
cait |
late morning :) |
| 11:00 |
|
|
khall joined #koha |
| 11:02 |
|
oleonard |
Hi all |
| 11:04 |
|
cait |
hi oleonard :) |
| 11:18 |
|
cait |
ashimema: if you have time a bit later... could you guide me for are rebase with sha1 missing... i've never done one of those |
| 11:18 |
|
ashimema |
ah.. those are a pain |
| 11:19 |
|
cait |
that's not helping yet :) |
| 11:19 |
|
ashimema |
is it a bug you wrote and you still have a branch? |
| 11:19 |
|
ashimema |
or someone elses bug? |
| 11:19 |
|
cait |
i fixed my patches, although they need another rease |
| 11:19 |
|
cait |
it's david nind's follow-up i struggle with :( |
| 11:19 |
|
ashimema |
so.. you don't have his followup on your branch? |
| 11:19 |
|
cait |
no |
| 11:20 |
|
ashimema |
and you get sha1 when you try to apply it via git bz? |
| 11:20 |
|
cait |
https://bugs.koha-community.or[…]_bug.cgi?id=25630 |
| 11:20 |
|
huginn |
Bug 25630: enhancement, P5 - low, ---, katrin.fischer, Patch doesn't apply , More capitalization and terminology fixes for system preferences |
| 11:20 |
|
cait |
his follow-up is at the momen tthe top patch, shoudl be the last in sequence |
| 11:21 |
|
ashimema |
can you checkout a new branch and apply them via git bz apply (picking the interactive option and putting his patch at the bottom after all yours in the resultant menu)? |
| 11:21 |
|
ashimema |
that might work |
| 11:21 |
|
cait |
that's because i had reattached my patches after the last rebase |
| 11:21 |
|
cait |
didn't work i think |
| 11:21 |
|
cait |
i followed the suggestions and couldn't get them to apply |
| 11:21 |
|
cait |
well "it" |
| 11:22 |
|
ashimema |
okies |
| 11:22 |
|
ashimema |
you can perhaps fallback to a apply patch.. I always have to google the syntax.. one moment |
| 11:25 |
|
|
khall_ joined #koha |
| 11:25 |
|
|
inlibro joined #koha |
| 11:30 |
|
cait |
i am also struggling a bit with bug 26023 |
| 11:30 |
|
wahanui |
okay, cait. |
| 11:30 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=26023 major, P5 - low, ---, martin.renvoize, Signed Off , Incorrect permissions handling for cashup actions on the library level registers summary page |
| 11:30 |
|
cait |
5/ Login as a user with the 'cashup' permission 6/ You should still be able to access the above page 7/ You should not see the cashup actions |
| 11:30 |
|
cait |
... if i have the cashup perm... shoudl i not see them? |
| 11:30 |
|
cait |
also... if i only have refund perm- i can't access the page it all now i tseems |
| 11:30 |
|
ashimema |
:( |
| 11:31 |
|
* ashimema |
needs more tea |
| 11:31 |
|
cait |
wonder if i got the right permissions |
| 11:33 |
|
|
khall joined #koha |
| 11:34 |
|
cait |
i commented, check later (with tea) |
| 11:39 |
|
|
Sarah joined #koha |
| 11:41 |
|
cait |
ashimema: i have now rebased all of my patches on current master |
| 11:41 |
|
cait |
missing david's still |
| 11:41 |
|
ashimema |
okies |
| 11:42 |
|
ashimema |
how big is his.. might just be easiest to replicate it and pretend to be him on commit with --author |
| 11:42 |
|
cait |
quite big :( |
| 11:42 |
|
cait |
https://bugs.koha-community.or[…]ent.cgi?id=106266 |
| 11:42 |
|
cait |
i have thought about htat, but was not sure if there wasn't a better git based way |
| 11:43 |
|
cait |
it's a ton of quite small changes |
| 11:43 |
|
cait |
i can do it, but he probably would need to check them again |
| 11:45 |
|
Joubu |
I'd checkout an older commit, where the patches applied, then rebase origin/master |
| 11:46 |
|
* ashimema |
is happy we have unit tests.. you broke a case Joubu :) |
| 11:46 |
|
ashimema |
Just fixing it now |
| 11:47 |
|
|
khall_ joined #koha |
| 11:47 |
|
ashimema |
actually.. you didn't |
| 11:48 |
|
cait |
Joubu: not sure what the commit was david did this with |
| 11:48 |
|
cait |
his patch never applied for me |
| 11:48 |
|
ashimema |
Kyles patch introducing time limited refunds did |
| 11:49 |
|
ashimema |
hmm |
| 11:55 |
|
* cait |
gets herself a cookie before redoing david's monster patch |
| 11:56 |
|
cait |
(not meant badly, just will need a really close look) ugh. :) |
| 11:59 |
|
Joubu |
cait: try to apply it with --reject |
| 12:00 |
|
cait |
how does that work? |
| 12:03 |
|
* oleonard |
also would like to know |
| 12:03 |
|
cait |
Joubu: ok, that did something, but not sure how to continue |
| 12:03 |
|
cait |
http://paste.koha-community.org/25186 |
| 12:04 |
|
cait |
do i need to check all the error ones? |
| 12:05 |
|
Joubu |
it lists the hunks where things have not been applied, the 'error:' lines |
| 12:05 |
|
cait |
ok |
| 12:05 |
|
Joubu |
a .rej should have been created to give you info |
| 12:05 |
|
cait |
i got 4 |
| 12:05 |
|
Joubu |
like the first one is "prefs-menu.inc", you should have a prefs-menu.inc.rej |
| 12:05 |
|
|
khall joined #koha |
| 12:06 |
|
cait |
and an untracked file... hm |
| 12:06 |
|
cait |
hm ok, the untracked one is a renamed file |
| 12:06 |
|
cait |
i will try and see if i can work through them |
| 12:07 |
|
cait |
do i just delete the rej after making changed to the file? |
| 12:07 |
|
Joubu |
rename koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/{staff_client.pref => staff_interface.pref} (99%) |
| 12:07 |
|
Joubu |
it's the renamed one |
| 12:07 |
|
Joubu |
you will have to git rm and git add (maybe git rm is not needed actually) |
| 12:07 |
|
cait |
how do i fix the reanmed one? |
| 12:07 |
|
Joubu |
check if staff_client.pref exists, if it exists you git mv staff_client.pref staff_interface.pref |
| 12:07 |
|
cait |
if i git add... won't there be a staff_client and a staff_interface one? |
| 12:08 |
|
Joubu |
if it's removed already, you git add staff_interface.pref |
| 12:08 |
|
cait |
i think i'd feel a bit safer removing the renamed extra and rename the now file |
| 12:08 |
|
Joubu |
I mixed up the names... |
| 12:08 |
|
cait |
yep i will try the git mv |
| 12:08 |
|
Joubu |
no I did not |
| 12:08 |
|
cait |
i think i did, but i think I see what you mean |
| 12:10 |
|
ashimema |
erm |
| 12:10 |
|
cait |
git mv koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_interface.pref |
| 12:10 |
|
cait |
fatal: bad source, source=koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref, destination=koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_interface.pref |
| 12:10 |
|
cait |
hmpf? |
| 12:10 |
|
cait |
oh |
| 12:10 |
|
cait |
yeah it was deleted... ok. i see. |
| 12:11 |
|
cait |
I think i know -th |
| 12:11 |
|
cait |
x |
| 12:11 |
|
Joubu |
then just add the untracked one |
| 12:12 |
|
Joubu |
it will be marked as moved in the patch |
| 12:14 |
|
cait |
it looks right now |
| 12:14 |
|
cait |
i think :) |
| 12:14 |
|
cait |
work on the .rej |
| 12:14 |
|
cait |
that has been really helpful |
| 12:14 |
|
cait |
much better than having to redo all the changes |
| 12:15 |
|
Joubu |
yes, it's painful but way less than having to rewrite the whole thing :) |
| 12:16 |
|
cait |
yeah, and in this case risk is no thigh, as it's all small independent changes |
| 12:16 |
|
cait |
ashimema++ Joubu++ |
| 12:20 |
|
|
khall joined #koha |
| 12:25 |
|
|
inlibro joined #koha |
| 12:39 |
|
cait |
.... all rebased. - only needs QA now ;) |
| 12:39 |
|
cait |
Also need some help on bug 24055 from someone who understands our paypal feature a bit more than me |
| 12:40 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=24055 trivial, P5 - low, ---, katrin.fischer, Failed QA , Description of PayPalReturnURL system preference is unclear |
| 12:40 |
|
|
khall joined #koha |
| 12:41 |
|
Joubu |
anybody familiar with UpdateItemLocationOnCheckin? |
| 12:41 |
|
Joubu |
https://lists.katipo.co.nz/pip[…]ugust/055034.html |
| 12:41 |
|
Joubu |
I've tested on master, and permanent_location is null if was null before the item is in CART |
| 12:42 |
|
cait |
that does not seem wrng |
| 12:42 |
|
cait |
permanent_location = location i think, until something like CART happens |
| 12:42 |
|
cait |
coudl it be a data problem? |
| 12:42 |
|
cait |
i remember our old instances don't always have permanent_location set |
| 12:43 |
|
cait |
i think we fixed that... but not sure how and when |
| 12:44 |
|
Joubu |
ok, trying to answer |
| 12:46 |
|
|
Marie-Luce joined #koha |
| 12:53 |
|
* ashimema |
closes eyes and pretends he's in Marseille whilst he eats some super stinky cheese for lunch |
| 12:53 |
|
|
khall joined #koha |
| 12:53 |
|
cait |
heh |
| 12:54 |
|
cait |
and also fixed up bug 13535... :) |
| 12:54 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=13535 enhancement, P5 - low, ---, katrin.fischer, Needs Signoff , Table alert is missing FK and not deleted with the patron |
| 13:00 |
|
* cait |
would also really love the person who signed off on Bug 25129 - Update German (de-DE) web installer files for 20.05 - these are supposed to go into stable versions |
| 13:00 |
|
cait |
they have been sitting since end of may |
| 13:11 |
|
|
khall joined #koha |
| 13:20 |
|
|
bdonnahue1 joined #koha |
| 13:25 |
|
|
inlibro joined #koha |
| 13:25 |
|
ashimema |
bug 25129 |
| 13:25 |
|
huginn |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=25129 enhancement, P5 - low, ---, katrin.fischer, Needs Signoff , Update German (de-DE) web installer files for 20.05 |
| 13:26 |
|
ashimema |
gotta finish this work first.. then can try to come back for that cait.. |
| 13:26 |
|
cait |
that woudl be great |
| 13:26 |
|
cait |
there is also one for the frameworks |
| 13:26 |
|
ashimema |
if I've not done it today.. remind my Monday.. unless someone beats me to it of course ;) |
| 13:26 |
|
ashimema |
hugs |
| 13:26 |
|
cait |
thx :) |
| 13:26 |
|
cait |
i have another 2 patches to rebase, then back to QA |
| 13:27 |
|
ashimema |
:) |
| 13:28 |
|
|
wizzycray joined #koha |
| 13:32 |
|
Joubu |
cait: what about removing the de-DE installer files? |
| 13:32 |
|
Joubu |
for 20.11 |
| 13:33 |
|
cait |
i want that |
| 13:33 |
|
cait |
another reason to get the fixes in for 20.05 |
| 13:33 |
|
cait |
so i can then move the fixed files to the new 'system' |
| 13:34 |
|
ashimema |
Unit tests are awesome.. catching all sorts of little things I missed 😀 |
| 13:35 |
|
ashimema |
Makes me less grumpy about writing them when I later find they prevent regressions I would have introduced.. lol |
| 13:35 |
|
ashimema |
Current my thanks past me |
| 13:36 |
|
cait |
Joubu: i want them backported to 20.05 so the installers there are up to date first :) |
| 13:44 |
|
Joubu |
yes sure! |
| 13:53 |
|
oleonard |
"The AutomaticItemReturn system preference must be set to “Don’t automatically transfer items to their home library when they are returned†for rotating collections to function properly." |
| 13:53 |
|
oleonard |
Why?? Because we haven't built in a check that takes rotating collections into account when checking in? |
| 13:57 |
|
lukeG |
Good morning |
| 13:58 |
|
oleonard |
Hi lukeG |
| 13:59 |
|
cait |
brb, got to pick up something |
| 14:08 |
|
|
fridolin left #koha |
| 14:19 |
|
ashimema |
there's loads of weird checks actually oleonard.. |
| 14:20 |
|
* oleonard |
loves weird checks if they're made out to him |
| 14:20 |
|
ashimema |
but.. transfers are generally a mess with them getting cancelled via various routes and never readded |
| 14:20 |
|
ashimema |
stock rotation also falls fowl of issues there |
| 14:20 |
|
ashimema |
I have a big branch of bugs that attempts to fix it.. |
| 14:21 |
|
ashimema |
still a work in progress but lots of the bugs are already there and ready to play with |
| 14:24 |
|
vfernandes |
which is the best way to translate this expression? https://translate.koha-communi[…]category=critical |
| 14:24 |
|
vfernandes |
error: Python brace placeholders |
| 14:25 |
|
|
inlibro joined #koha |
| 14:30 |
|
cait |
back |
| 14:30 |
|
cait |
keep the {count} |
| 14:30 |
|
cait |
it is replaced with the naumber |
| 14:30 |
|
cait |
ah |
| 14:30 |
|
cait |
i think you translated it corectly, it's pootle not liking the {} |
| 14:31 |
|
cait |
i thnk it will still work, even if it shows in red here |
| 14:33 |
|
vfernandes |
ok, thanks cait |
| 14:50 |
|
ashimema |
reading the code it looks like if you lose an item.. then find it.. then lose it again.. we don't update the itemlost_on field to contain the latest lose date |
| 14:51 |
|
ashimema |
same for withdrawn items |
| 14:52 |
|
ashimema |
oh.. no.. we do reset it.. |
| 14:52 |
|
ashimema |
this code is weird :( |
| 14:57 |
|
oleonard |
@quote add <ashimema> this code is weird :( |
| 14:57 |
|
huginn |
oleonard: Error: You must be registered to use this command. If you are already registered, you must either identify (using the identify command) or add a hostmask matching your current hostmask (using the "hostmask add" command). |
| 14:58 |
|
oleonard |
@quote add <ashimema> this code is weird :( |
| 14:58 |
|
wahanui |
i already had it that way, oleonard. |
| 14:58 |
|
huginn |
oleonard: Error: You must be registered to use this command. If you are already registered, you must either identify (using the identify command) or add a hostmask matching your current hostmask (using the "hostmask add" command). |
| 14:58 |
|
oleonard |
*shrug* |
| 14:58 |
|
|
khall joined #koha |
| 14:59 |
|
ashimema |
@quote add <ashimema> this code is weird :( |
| 14:59 |
|
huginn |
ashimema: Error: You must be registered to use this command. If you are already registered, you must either identify (using the identify command) or add a hostmask matching your current hostmask (using the "hostmask add" command). |
| 14:59 |
|
wahanui |
i already had it that way, ashimema. |
| 15:00 |
|
ashimema |
lol |
| 15:00 |
|
ashimema |
I thought I was |
| 15:00 |
|
reiveune |
bye |
| 15:00 |
|
|
reiveune left #koha |
| 15:00 |
|
* oleonard |
too! |
| 15:12 |
|
* cait |
hands out icecream to everyone around |
| 15:13 |
|
oleonard |
Thanks cait, I was actually hoping that what you went out to pick up was ice cream |
| 15:13 |
|
cait |
;) |
| 15:14 |
|
ashimema |
ice cream :P |
| 15:19 |
|
|
khall joined #koha |
| 15:25 |
|
|
inlibro joined #koha |
| 16:26 |
|
|
inlibro joined #koha |
| 16:31 |
|
ashimema |
time to go cook.. have a good weekend all |
| 17:16 |
|
oleonard |
this code? |
| 17:16 |
|
oleonard |
wahanui: this code? |
| 17:16 |
|
wahanui |
oleonard: i don't know |
| 17:26 |
|
|
inlibro joined #koha |
| 17:47 |
|
|
caroline joined #koha |
| 18:11 |
|
|
did joined #koha |
| 18:26 |
|
|
inlibro joined #koha |
| 18:47 |
|
oleonard |
cait still around? |
| 18:47 |
|
cait |
yes |
| 18:49 |
|
oleonard |
Ah never mind I figured it out :) |
| 18:49 |
|
* oleonard |
trying to trigger various error messages for testing |
| 18:53 |
|
cait |
ok :) |
| 19:26 |
|
|
inlibro joined #koha |
| 20:26 |
|
|
inlibro joined #koha |
| 21:26 |
|
|
inlibro joined #koha |
| 21:42 |
|
koha-jenkins |
Project Koha_20.05_D9 build #67: SUCCESS in 40 min: https://jenkins.koha-community[…]Koha_20.05_D9/67/ |
| 21:49 |
|
koha-jenkins |
Yippee, build fixed! |
| 21:49 |
|
wahanui |
Congratulations! |
| 21:49 |
|
koha-jenkins |
Project Koha_20.05_U18 build #55: FIXED in 46 min: https://jenkins.koha-community[…]oha_20.05_U18/55/ |
| 21:52 |
|
koha-jenkins |
Project Koha_20.05_D9_My8 build #58: SUCCESS in 50 min: https://jenkins.koha-community[…]_20.05_D9_My8/58/ |
| 21:59 |
|
koha-jenkins |
Project Koha_20.05_U16 build #52: SUCCESS in 56 min: https://jenkins.koha-community[…]oha_20.05_U16/52/ |
| 22:07 |
|
koha-jenkins |
Project Koha_20.05_U20 build #52: SUCCESS in 1 hr 4 min: https://jenkins.koha-community[…]oha_20.05_U20/52/ |
| 22:19 |
|
koha-jenkins |
Project Koha_20.05_D10 build #63: SUCCESS in 37 min: https://jenkins.koha-community[…]oha_20.05_D10/63/ |
| 22:27 |
|
|
inlibro joined #koha |
| 22:38 |
|
koha-jenkins |
Project Koha_20.05_D9 build #68: SUCCESS in 48 min: https://jenkins.koha-community[…]Koha_20.05_D9/68/ |
| 22:39 |
|
koha-jenkins |
Project Koha_20.05_U18 build #56: SUCCESS in 46 min: https://jenkins.koha-community[…]oha_20.05_U18/56/ |
| 22:49 |
|
koha-jenkins |
Project Koha_20.05_U20 build #53: FAILURE in 42 min: https://jenkins.koha-community[…]oha_20.05_U20/53/ |
| 22:52 |
|
koha-jenkins |
Project Koha_20.05_U20 build #54: STILL FAILING in 2 min 17 sec: https://jenkins.koha-community[…]oha_20.05_U20/54/ |
| 22:55 |
|
lukeG |
dang you U20 |
| 22:59 |
|
koha-jenkins |
Project Koha_20.05_U16 build #53: SUCCESS in 39 min: https://jenkins.koha-community[…]oha_20.05_U16/53/ |
| 23:00 |
|
koha-jenkins |
Project Koha_20.05_D9_My8 build #59: SUCCESS in 1 hr 0 min: https://jenkins.koha-community[…]_20.05_D9_My8/59/ |
| 23:21 |
|
koha-jenkins |
Project Koha_20.05_D10 build #64: SUCCESS in 43 min: https://jenkins.koha-community[…]oha_20.05_D10/64/ |
| 23:26 |
|
koha-jenkins |
Project Koha_20.05_D9 build #69: SUCCESS in 46 min: https://jenkins.koha-community[…]Koha_20.05_D9/69/ |
| 23:27 |
|
|
inlibro joined #koha |
| 23:39 |
|
koha-jenkins |
Project Koha_20.05_U18 build #57: UNSTABLE in 40 min: https://jenkins.koha-community[…]oha_20.05_U18/57/ |
| 23:56 |
|
koha-jenkins |
Project Koha_20.05_U16 build #54: SUCCESS in 56 min: https://jenkins.koha-community[…]oha_20.05_U16/54/ |
