IRC log for #koha, 2020-01-07

All times shown according to UTC.

Time S Nick Message
00:02 inlibro joined #koha
00:04 aleisha joined #koha
00:09 koha-jenkins Project Koha_19.05_D9 build #84: UNSTABLE in 43 min: https://jenkins.koha-community[…]Koha_19.05_D9/84/
01:02 inlibro joined #koha
01:13 wizzyrea joined #koha
01:31 khall joined #koha
02:02 inlibro joined #koha
02:42 wizzyrea did you all know that our double submit bug and double hold messages are really a chrome bug
02:42 wizzyrea https://bugs.chromium.org/p/ch[…]/detail?id=977882
03:02 inlibro joined #koha
04:02 inlibro joined #koha
05:02 inlibro joined #koha
05:59 chris joined #koha
06:03 inlibro joined #koha
06:32 cait joined #koha
07:03 inlibro joined #koha
07:42 reiveune joined #koha
07:42 reiveune hello
07:42 wahanui bonjour, reiveune
07:51 andreashm joined #koha
07:52 alex_a joined #koha
07:52 alex_a Bonjour
07:53 andreash_ joined #koha
07:54 andreashm joined #koha
07:54 andreash_ joined #koha
07:55 fridolin joined #koha
07:57 fridolin hi
07:57 wahanui bonjour, fridolin
07:57 fridolin wahanui: de même mon cher
07:57 wahanui fridolin: huh?
07:59 kohaputti joined #koha
08:00 greenjimll joined #koha
08:03 inlibro joined #koha
08:05 paul_p joined #koha
08:10 thomas joined #koha
08:12 thomas left #koha
08:16 cait joined #koha
08:31 sophie_m joined #koha
08:31 magnuse joined #koha
09:01 cait happy to report there are 4 19.11 demos already: https://koha-community.org/demo/
09:03 inlibro joined #koha
09:09 sjamso joined #koha
09:10 sjamso Hello... I am not able to upgrade koha 18.11 to koha 19.11. When I restore the database I get this error.. ERROR 1005 (HY000) at line 12449: Can't create table `koha_library`.`tags_approval` (errno: 150 "Foreign key constraint is incorrectly formed"). Please help me
09:11 ashimema[m] what SQL server are you using sjamso?
09:11 sjamso Ubuntu 18.4
09:12 sjamso with mariadb 10.4.11
09:12 ashimema[m] hmm..
09:12 ashimema[m] let me try and replicate it here
09:13 sjamso thank you ashimema!
09:14 ashimema[m] as a note though.. support for that version of mariadb is experimental at the moment..
09:15 ashimema[m] we regularly test against mysql 5.5 and maraidb 10.3..
09:15 ashimema[m] but we've only very recently started to look at mysql 8 and mariadb 10.4
09:16 ashimema[m] in fact.. maraidb 10.1 is recommended..
09:16 ashimema[m] 10.3 support is a little experimental at the moment too
09:17 sjamso ohh.. ok.. Thank you. If there is no solution for this. I think I will have to downgrade my SQL server to mariadb 10.3 or to some lower version
09:19 ashimema[m] hmm, the line number in the error you posted is wierd..
09:19 ashimema[m] what was the last successful update performed in the db.. what point release does your DB think it is at
09:22 sjamso Currently I am running Koha 18.11 with Mariadb 10.0.36 and now looking to upgrade to koha 19.11 on Ubuntu 18.4
09:25 ashimema[m] so.. I'm hoping this is a test system your trialing the upgrade on?
09:26 ashimema[m] did you fun the dbupdate from the command line or through the browser..
09:26 sjamso yes.. its a test system ashimema
09:26 ashimema[m] what was the last `Update to ` line you say before the error?
09:26 ashimema[m] just trying to find the errant area of code
09:28 sjamso I am upgrading the database by restoring the database dumped from my live server. Database restoration completes with 100% but with the error I told you earlier
09:30 SoniaB joined #koha
09:40 cait how are you restoring your database?
09:40 cait did you run the web installer before restoring?
09:49 sjamso joined #koha
09:50 * ashimema[m] has to go into a meeting.. will be back shortly
09:50 ashimema[m] sorry
09:50 ashimema[m] oh.. so it's during the restore
09:51 ashimema[m] rather than when running updatedatabase
09:51 ashimema[m] that makes sense as to why the line numer made no sense to me.
09:51 sjamso Yes. It’s during restoration
09:52 ashimema[m] sounds like somehow you're table aren't consistent with their CHARSET and COLLATE values
09:52 ashimema[m] the only FK in the tags_approval table is the borrower number
09:53 ashimema[m] I'd check what collation and charset it's attempting to create the borrowes table as and then set the tags_aproval table to match in your restore file
09:53 ashimema[m] that's my best guess
09:53 * ashimema[m] goes into meeting now
09:54 sjamso I am just dumping the backup database. So don’t know how the inconsistency occured
09:55 ashimema[m] it's probably there in the old system.. but mariadb 10.4 is stricter ;)
09:55 sjamso Thank you so much for you help. I will try with mariadb 10.3 once and see if I get the same issue.
09:55 ashimema[m] that's the general trend.. mariadb is getting structer and more consistent with every version
09:55 ashimema[m] good idea
09:56 sjamso Thank you so much for the help ashimema
10:02 magnuse ashimema++
10:03 inlibro joined #koha
10:08 kohaputti joined #koha
10:40 kohaputti joined #koha
10:50 fridolin left #koha
10:50 fridolin joined #koha
10:51 fridolin Bug 15148 needs a high level gamer
10:53 cait bug 14158
10:53 huginn` Bug http://bugs.koha-community.org[…]_bug.cgi?id=14158 normal, P5 - low, ---, jonathan.druart, CLOSED FIXED, t/db_dependent/www/search_utf8.t hangs if error is returned
10:53 cait hm case sensitive much, huginn?
11:04 inlibro joined #koha
11:05 kohaputti joined #koha
11:17 ashimema[m] bug 15148
11:17 huginn` Bug http://bugs.koha-community.org[…]_bug.cgi?id=15148 normal, P5 - low, ---, nick, Patch doesn't apply , Serials: Test prediction pattern starts at First issue date, not Subscription start date
11:19 khall joined #koha
11:30 paxed ohh...
11:30 paxed virtualbox isn't available for debian 10
11:34 kohaputti joined #koha
11:39 khall joined #koha
11:50 tcohen bonjour
11:50 wahanui kia ora, tcohen
11:51 * tcohen sets Marseille mode on
11:57 cait tcohen: what's that?
11:57 wahanui somebody said that was what blou added in his patch
11:59 tcohen cait: I'm already having Pastis with dinner
11:59 tcohen haha
12:01 cait tcohen: oooh I'd like that
12:01 khall joined #koha
12:04 inlibro joined #koha
12:04 kohaputti joined #koha
12:20 oleonard joined #koha
12:21 oleonard Hi all
12:31 kohaputti joined #koha
12:35 tcohen hi oleonard
12:35 wahanui hi oleopard
12:50 magnuse tcohen: are you coming to marseille
12:50 magnuse ?
12:55 kohaputti joined #koha
13:04 inlibro joined #koha
13:08 tcohen magnuse: hopefully
13:09 fridolin joined #koha
13:11 * magnuse crosses fingers
13:13 Dyrcona joined #koha
13:20 caroline_catlady good morning!
13:21 Joubu ashimema[m]: bug 24361
13:21 huginn` Bug http://bugs.koha-community.org[…]_bug.cgi?id=24361 normal, P5 - low, ---, jonathan.druart, Needs Signoff , Fix warnings (or failing tests) from bug 24217
13:24 ashimema[m] ta
13:24 oleonard spoiler alert: caroline_catlady escaped
13:24 caroline_catlady I did not, but they let us out because we were so shameful...
13:25 oleonard I didn't know that was a valid strategy!
13:26 caroline_catlady you can try puppy dog eyes too, few can resist those
13:34 kohaputti joined #koha
13:36 caroline_catlady oleonard: is the calendar supposed to be this small? I'm wondering if it's just my installation or my browser
13:36 caroline_catlady https://snipboard.io/bnzK9D.jpg
13:36 oleonard Bug 24181 has had unintended consequences :(
13:36 huginn` Bug http://bugs.koha-community.org[…]_bug.cgi?id=24181 enhancement, P5 - low, ---, jonathan.druart, Pushed to master , Make our datepicker inputs sexy
13:38 caroline_catlady ok, I'll report it then
13:41 khall joined #koha
13:41 oleonard ashimema[m]: I would vote that it be reverted :(
13:44 cait :(
13:47 cait kidclamp: bug 24350
13:47 huginn` Bug http://bugs.koha-community.org[…]_bug.cgi?id=24350 blocker, P5 - low, ---, jonathan.druart, Needs Signoff , Can't place holds
13:47 cait ah sorry, not that one
13:47 cait bug 24362
13:47 huginn` Bug http://bugs.koha-community.org[…]_bug.cgi?id=24362 normal, P5 - low, ---, koha-bugs, RESOLVED DUPLICATE, Elasticsearch - Sorting by title does not ignore leading articles
13:48 cait my brain currently is in deduplicating mode for bugzilla - it's almost all loaded in my brain now (or it feels like, in reality I stopped in 2015)
13:53 huginn` News from kohagit: Bug 24150: Add missing koha_object[s]_class methods and skip for deletedborrowers <http://git.koha-community.org/[…]655c927a20b86b705>
13:57 kohaputti joined #koha
14:00 oleonard Got stuck on a particular patch a few months ago... Now when I test it I can't find anything broken... What am I missing??
14:00 oleonard I may have to submit it and just wait for the public humiliation
14:03 huginn` News from kohagit: Bug 24361: (bug 24217 follow-up) Fix several warnings in C4 modules <http://git.koha-community.org/[…]364694b88442e03cf>
14:03 huginn` News from kohagit: Bug 24361: Fix warning in C4::Record line 435 <http://git.koha-community.org/[…]8a7a08a107e4fd835>
14:04 inlibro joined #koha
14:08 caroline_catlady oleonard: do you have an easy bug that needs a sign off? I have new interns twho know 0 Koha and 0 git and need to practise on something easy
14:10 oleonard In terms of the complexity of testing, maybe Bug 23915?
14:10 huginn` Bug http://bugs.koha-community.org[…]_bug.cgi?id=23915 enhancement, P5 - low, ---, oleonard, Needs Signoff , Replace OPAC list sort menu with Bootstrap menu button
14:27 kohaputti joined #koha
14:31 cait caroline_catlady: say hi to the interns :)
14:32 wizzyrea joined #koha
14:32 koha-jenkins Project Koha_Master_D9 build #1050: STILL UNSTABLE in 38 min: https://jenkins.koha-community[…]a_Master_D9/1050/
14:39 koha-jenkins Project Koha_Master_D8 build #582: NOW UNSTABLE in 36 min: https://jenkins.koha-community[…]ha_Master_D8/582/
14:46 bdonnahue joined #koha
14:47 koha-jenkins Project Koha_Master_D9_MDB_Latest build #28: NOW UNSTABLE in 44 min: https://jenkins.koha-community[…]D9_MDB_Latest/28/
14:52 oleonard Is there a known issue with searches that contain parentheses?
14:52 oleonard opac-search.pl?q=au,wrdl:Copyright Collection (Library of Congress)
14:53 oleonard Is that supposed to be encoded first?
14:55 kohaputti joined #koha
14:55 caroline_catlady maybe bug 1807?
14:55 huginn` Bug http://bugs.koha-community.org[…]w_bug.cgi?id=1807 major, P3, ---, gmcharlt, NEW , search () give odd results
14:57 caroline_catlady I know I have problems with colons too. If you click on a title with a colon, there will be no search results
14:57 oleonard Thanks caroline_catlady, a 12-year-old bug definitely counts as "known issue" :P
14:57 caroline_catlady lol!
15:01 caroline_catlady AndyBoze++ for 1st contribution to the manual! :D
15:03 cait oleonard: i know we remove () from some strings - but it shoudl lso be url encoded now
15:03 cait oleonard: my usual test is - search for it in koha opac itself
15:03 cait see if it causes trouble there
15:03 cait and then check the encodinng
15:04 inlibro joined #koha
15:08 oleonard Well the really great news is that JavaScript has an "encodeURI" function which... doesn't encode parentheses.
15:08 huginn` News from kohagit: Bug 24365: (bug 24217 follow-up) Fix encoding issue for translator script <http://git.koha-community.org/[…]ce7ab3d8071b38366>
15:08 cait oleonard: maybe it doesn't have to? not sure
15:08 cait i know we removet hem from 780/785 links
15:08 cait i have just been there doing a fix in ours yesterday
15:09 caroline_catlady cait you remove them automatically from 780/785?
15:09 cait in xslt it's something like translate($f780,'()','')
15:09 cait koha standard does in this case
15:09 cait but i don't think we do it consistently everywhere
15:09 cait i just assume someone did that becaus of reason
15:09 oleonard I'm trying to build a search string in JS
15:09 cait ah ok
15:13 caroline_catlady It was in a 78X field that I had problems with the colon, trying to find the actual bug report
15:13 koha-jenkins Project Koha_Master_U18 build #522: NOW UNSTABLE in 40 min: https://jenkins.koha-community[…]a_Master_U18/522/
15:24 kohaputti joined #koha
15:30 oleonard Don't know if anyone is using the feature, but I'm working on Bug 13327
15:30 huginn` Bug http://bugs.koha-community.org[…]_bug.cgi?id=13327 normal, P5 - low, ---, oleonard, ASSIGNED , OPACPopupAuthorsSearch doesn't work with XSLT views
15:31 koha-jenkins Project Koha_Master_D9_My8 build #58: NOW UNSTABLE in 52 min: https://jenkins.koha-community[…]Master_D9_My8/58/
15:31 sjamso joined #koha
15:31 koha-jenkins Project Koha_Master_D9 build #1051: STILL UNSTABLE in 44 min: https://jenkins.koha-community[…]a_Master_D9/1051/
15:43 fridolin left #koha
15:45 koha-jenkins Project Koha_Master_D8 build #583: STILL UNSTABLE in 32 min: https://jenkins.koha-community[…]ha_Master_D8/583/
15:46 paul_p joined #koha
15:46 mtompset joined #koha
15:49 SoniaB left #koha
15:53 kohaputti joined #koha
15:56 huginn` News from kohagit: Bug 24328: Fix bibliographic frameworks install (linkid) <http://git.koha-community.org/[…]3e064f2d7d3de0d24>
15:56 huginn` News from kohagit: Bug 24314: Update de-DE MARC21 frameworks for updates 28+29 (May and November 2019) <http://git.koha-community.org/[…]d4431e320c78603be>
15:56 huginn` News from kohagit: Bug 24312: Update MARC21 frameworks to Updates 28+29 (May and November 2019) <http://git.koha-community.org/[…]df84cf22f9e5bc5e9>
16:03 reiveune bye
16:03 reiveune left #koha
16:04 ashimema[m] oleonard still around?
16:04 inlibro joined #koha
16:05 ashimema[m] still think bug 24181 should be reverted.. or is the followup on bug 24363 enough to resolve it..
16:05 huginn` Bug http://bugs.koha-community.org[…]_bug.cgi?id=24181 enhancement, P5 - low, ---, jonathan.druart, Pushed to master , Make our datepicker inputs sexy
16:05 huginn` Bug http://bugs.koha-community.org[…]_bug.cgi?id=24363 enhancement, P5 - low, ---, lucas, Needs Signoff , Datepicker calendar is not sexy on additem.pl
16:05 * ashimema[m] hasn't tested yet.. but would probably prefer a fix to a revert if there is one.
16:06 caroline_catlady I'm currently testing it. It aligns it which is good, but it's still small
16:06 oleonard caroline_catlady: Smaller than usual?
16:06 caroline_catlady And I haven't been able to track down all the pages where that icon appears
16:06 caroline_catlady it's the same size as my screen capture from before
16:07 caroline_catlady I find that it is small
16:07 caroline_catlady but I'll compare to some other icon
16:07 oleonard caroline_catlady: Anywhere with a datepicker: Add item, add patron, reports, overdues
16:07 caroline_catlady personally, I would find it more pleasing if it was the height of the input box
16:08 caroline_catlady (a little bit less than the input box height so that it fits nicely inside and isn't crowded at the top
16:09 caroline_catlady not sure what was the original objective behind the first bug
16:09 ashimema[m] so it's not looking as intended originally then: https://snipboard.io/zOPV4F.jpg
16:10 oleonard Right now we have two alternatives: One where the image is a background to the input, but the input style is slightly off (before this patch); Or the image is an image positioned to look like it's inside the input but looks slightly off sometimes
16:10 caroline_catlady ashimema[m]: that one looks nice!
16:12 ashimema[m] aha..
16:12 ashimema[m] it's taken me a moment to work out how it changed in the first place
16:12 cait oleonard: we never tried the feature since we have always been using XSLT - but it looked interesting (to answer your earlier question :) )
16:12 caroline_catlady this is what it looks like with the new patch https://snipboard.io/Z1y8Xm.jpg
16:13 caroline_catlady it's tiny
16:13 ashimema[m] ah.. that's not so nice
16:13 caroline_catlady but in Lucas' defense, he did just align it as I asked :)
16:13 oleonard caroline_catlady: What browser is that? Is the zoom scaled up or down, or at 100%?
16:14 caroline_catlady it's better than whi'm in FF 71 no zoom
16:14 caroline_catlady oops! two messages in one sorry!
16:14 * ashimema[m] goes back to fixing tests and leaves this one with you guys :)
16:15 caroline_catlady so I was saying it's better than it was before, because it's now aligned
16:16 koha-jenkins Project Koha_Master_U18 build #523: STILL UNSTABLE in 44 min: https://jenkins.koha-community[…]a_Master_U18/523/
16:16 caroline_catlady and answering the browser question Firefox (version 71), on Ubuntu 18.04, no zoom
16:18 caroline_catlady oleonard: do you think it would be doable to make it bigger so that it fills the input box? or it's not possible because we're using the 2nd option?
16:18 oleonard The image is a bitmap so it can't scale nicely
16:18 caroline_catlady ah...
16:19 kohaputti joined #koha
16:21 koha-jenkins Project Koha_Master_D9_MDB_Latest build #29: STILL UNSTABLE in 49 min: https://jenkins.koha-community[…]D9_MDB_Latest/29/
16:23 ashimema[m] so.. where are we at with the followup on bug 21684 Joubu.. must admit I've got slightly lost in the final comments
16:23 huginn` Bug http://bugs.koha-community.org[…]_bug.cgi?id=21684 minor, P5 - low, ---, jonathan.druart, Pushed to master , Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones
16:24 koha-jenkins Project Koha_Master_D9_My8 build #59: STILL UNSTABLE in 39 min: https://jenkins.koha-community[…]Master_D9_My8/59/
16:26 lisettelatah joined #koha
16:26 lukeG joined #koha
16:28 huginn` News from kohagit: Bug 24150: Prevent random failure comparing updated_on <http://git.koha-community.org/[…]73a8085b6447fb2b9>
16:28 oleonard If we went back to a background image we could use "background-size:contain" in the CSS and a scalable SVG... But I don't know if that solves anything
16:32 caroline_catlady well, it would solve my issue, but I don't know for the first one since I'm not sure what Joubu meant by "not sexy" and what was the purpose of his patch
16:33 ashimema[m] take a close look at the actual 'input field'
16:33 caroline_catlady this is a compromise https://snipboard.io/DTxl6G.jpg
16:33 ashimema[m] the box is differently styled
16:34 caroline_catlady ah ok! you mean the original input boxes for dates were thinner?
16:34 ashimema[m] yup
16:35 ashimema[m] well..
16:35 caroline_catlady it would be nice to keep them as they are now, i.e. same size as the rest
16:35 ashimema[m] longer and thinner and without a nice rounded box border
16:35 ashimema[m] yeah..
16:35 ashimema[m] be nice to get the image back to being nice too
16:36 oleonard Applying a background-image via CSS "resets" the style of the input back to a state without the browser's built-in form style.
16:36 oleonard It's difficult to style it *back* to the browser's default because it differs from browser to browser.
16:36 kohaputti joined #koha
16:36 oleonard That's why the background-image solution makes the input look different
16:36 caroline_catlady ok I understand
16:37 caroline_catlady so do you think we can make them centered like in this case? https://snipboard.io/DTxl6G.jpg
16:37 caroline_catlady or it wouls vary from page to page?
16:39 oleonard I don't know if it's possible to center it using the current inline image method
16:39 huginn` News from kohagit: Bug 21684: Fix Hold.t <http://git.koha-community.org/[…]23b75285a05dc0383>
16:39 huginn` News from kohagit: Bug 21684: Koha::Object->delete must return a Koha::Object <http://git.koha-community.org/[…]4d9124b3371129419>
16:39 huginn` News from kohagit: Bug 21684: Fix UploadedFile[s]->delete <http://git.koha-community.org/[…]3e9a4bfa8e0275ef2>
16:46 ashimema[m] cait
16:46 ashimema[m] I think you got the wrong dupe on bug 24350 ?
16:46 huginn` Bug http://bugs.koha-community.org[…]_bug.cgi?id=24350 blocker, P5 - low, ---, jonathan.druart, Needs Signoff , Can't place holds
16:46 cait fixed already
16:46 cait left #koha
16:47 oleonard MIC DROP
16:51 caroline_catlady just signed off bug 24350 btw :)
16:51 huginn` Bug http://bugs.koha-community.org[…]_bug.cgi?id=24350 blocker, P5 - low, ---, jonathan.druart, Signed Off , Can't place holds
16:53 ashimema[m] :)
16:57 koha-jenkins Project Koha_Master_D8 build #584: STILL UNSTABLE in 36 min: https://jenkins.koha-community[…]ha_Master_D8/584/
17:00 koha-jenkins Project Koha_Master_D9 build #1052: STILL UNSTABLE in 44 min: https://jenkins.koha-community[…]a_Master_D9/1052/
17:02 kohaputti joined #koha
17:02 huginn` News from kohagit: Bug 24350: Fix Branches.pickup_locations <http://git.koha-community.org/[…]ac5202d0706ef505f>
17:05 inlibro joined #koha
17:05 koha-jenkins Project Koha_Master_U18 build #524: STILL UNSTABLE in 40 min: https://jenkins.koha-community[…]a_Master_U18/524/
17:12 vfernandes joined #koha
17:30 cait joined #koha
17:37 koha-jenkins Project Koha_Master_D8 build #585: STILL UNSTABLE in 31 min: https://jenkins.koha-community[…]ha_Master_D8/585/
17:43 kohaputti joined #koha
17:47 koha-jenkins Project Koha_Master_D9_My8 build #60: STILL UNSTABLE in 46 min: https://jenkins.koha-community[…]Master_D9_My8/60/
17:47 koha-jenkins Project Koha_Master_D9_MDB_Latest build #30: STILL UNSTABLE in 50 min: https://jenkins.koha-community[…]D9_MDB_Latest/30/
17:48 ribasushi joined #koha
17:55 caroline_catlady is there a reason there is no default claim notice for late serial issues?
17:56 oleonard I came to the conclusion since that the parentheses-encoding problem predated my patch I should go ahead and submit it.
17:56 oleonard Bug 13327
17:56 huginn` Bug http://bugs.koha-community.org[…]_bug.cgi?id=13327 normal, P5 - low, ---, oleonard, Needs Signoff , OPACPopupAuthorsSearch doesn't work with XSLT views
17:58 oleonard caroline_catlady: Because Bug 4398 has been "NEW" for 10 years
17:58 huginn` Bug http://bugs.koha-community.org[…]w_bug.cgi?id=4398 enhancement, P5 - low, ---, koha-bugs, NEW , Example notice for 'claims notice' in Serials
17:58 caroline_catlady ok lol!
17:58 oleonard We're digging up all the old stuff today. Must be cait's influence.
17:59 caroline_catlady looks like it will be worked on at the next Catalyst Academy
18:00 oleonard That was 2018 :(
18:01 caroline_catlady oh right... I'm still getting used to the new year
18:01 oleonard To be fair it's a junk new year
18:02 kohaputti joined #koha
18:04 oleonard With 13327 submitted my list of "in progress" git branches goes from 72 to 71. I may have a problem.
18:05 inlibro joined #koha
18:05 caroline_catlady omg there are so many datepickers in Koha... *pulls out hair*
18:15 oleonard Are you testing ALL of them caroline_catlady??
18:16 koha-jenkins Project Koha_Master_D9 build #1053: STILL UNSTABLE in 39 min: https://jenkins.koha-community[…]a_Master_D9/1053/
18:25 kohaputti joined #koha
18:25 cait what am I to blame for this time? :)
18:26 bdonnahue joined #koha
18:26 oleonard You've stirred up all the old Bugzilla ghosts
18:27 cait sorry not sorry :)
18:32 koha-jenkins Project Koha_Master_U18 build #525: STILL UNSTABLE in 44 min: https://jenkins.koha-community[…]a_Master_U18/525/
18:38 koha-jenkins Project Koha_Master_D9_My8 build #61: STILL UNSTABLE in 51 min: https://jenkins.koha-community[…]Master_D9_My8/61/
18:43 kohaputti joined #koha
18:48 caroline_catlady I was trying to find all of them... half are still wonky
18:49 lisettelatah joined #koha
18:50 caroline_catlady there has to be a better way to make them look nice without having to change the css one by one?
18:52 oleonard We definitely will not be changing them one by one.
18:53 caroline_catlady lucas' patch is useless since it fixes only the one in additem
18:55 oleonard His patch affects all the datepickers... So it sounds like the fix isn't globally applicable
18:56 koha-jenkins Project Koha_Master_D9_MDB_Latest build #31: STILL UNSTABLE in 39 min: https://jenkins.koha-community[…]D9_MDB_Latest/31/
18:57 cait probably our formatting is not as standardized as it shoudl be yet?
19:04 lukeG Do we need to change just the datpickers in additems.tt? I can submit a new patch
19:05 caroline_catlady hi lukeG! I just sumbitted a comment
19:05 caroline_catlady I'm not sure how you want to go about it
19:05 inlibro joined #koha
19:05 caroline_catlady bug 24363
19:05 huginn` Bug http://bugs.koha-community.org[…]_bug.cgi?id=24363 enhancement, P5 - low, ---, lucas, Failed QA , Datepicker calendar is not sexy on additem.pl
19:05 lukeG Thanks Caroline for pointing them all out
19:06 caroline_catlady oleonard says you should have to change them one by one
19:06 oleonard Should *not*
19:07 kohaputti joined #koha
19:07 lukeG hehe
19:07 caroline_catlady yes sorry! sould not!
19:07 caroline_catlady misquoted there!
19:10 lukeG caroline_catlady: I will attempt another patch this afternoon
19:10 caroline_catlady thanks so much!
19:15 * oleonard still votes revert
19:16 caroline_catlady I'm starting to agree with you
19:16 oleonard But on my system the issue being solved by 24181 was barely noticeable. I don't know under what circumstances it is noticeable.
19:18 caroline_catlady you mean the input boxes don't look better on your system?
19:19 oleonard I mean before Bug 24181 was pushed I didn't see much of a difference between datepicker input fields and others
19:19 huginn` Bug http://bugs.koha-community.org[…]_bug.cgi?id=24181 enhancement, P5 - low, ---, jonathan.druart, Pushed to master , Make our datepicker inputs sexy
19:21 caroline_catlady this is what they look like on my 19.05 installation https://snipboard.io/SaLkVZ.jpg
19:21 oleonard This is how it looked in Firefox on Windows 10: https://zivotdesign.com/p/view[…]?p=15784248501570
19:22 oleonard caroline_catlady: Those text inputs are radically different than mine
19:22 caroline_catlady you're right, yours don't look very different...
19:23 cait i am seeing some issues in 18.11 on the suggestions filters
19:23 cait if you want to check those for reference maybe
19:23 caroline_catlady these are on my master https://snipboard.io/sOBKrx.jpg it looks much more uniform
19:24 oleonard caroline_catlady: And you don't have any custom CSS applied?
19:24 caroline_catlady not that I know of
19:24 caroline_catlady I don't have a FF theme
19:24 caroline_catlady I did change my Ubuntu theme from orange to blue
19:25 kohaputti joined #koha
19:26 mtompset joined #koha
19:48 kohaputti joined #koha
19:50 caroline_catlady Joubu or ashimema[m] around?
19:52 caroline_catlady I'm trying to modify .gitlab-ci.yml for the new 19.11 manual branch. In the issue, Joubu says to change from 19.05 to 19.11, but in the file, it's written 20.05...
19:52 caroline_catlady am I looking in the wrong place?
19:55 hayley joined #koha
20:05 inlibro joined #koha
20:07 bdonnahue joined #koha
20:07 hayley joined #koha
20:11 kohaputti joined #koha
20:40 kohaputti joined #koha
20:48 lukeG1 joined #koha
21:05 inlibro joined #koha
21:07 kohaputti joined #koha
21:36 kohaputti joined #koha
22:02 kohaputti joined #koha
22:05 inlibro joined #koha
22:09 ashimema[m] It's different per branch caroline_catlady
22:10 ashimema[m] I thought I'd updated them all already though..
22:10 caroline_catlady yeah bernardo explained it to me :)
22:10 caroline_catlady It was updated, but there was no 19.11 branch
22:11 caroline_catlady Now all is good and we will document like there's no tomorrow!
22:11 caroline_catlady lol!
22:13 cait caroline_catlady++ bgkriegel++
22:13 cait :)
22:33 kohaputti joined #koha
23:00 kohaputti joined #koha
23:06 inlibro joined #koha
23:07 lukeG joined #koha
23:11 koha-jenkins Project Koha_19.05_D8 build #84: SUCCESS in 32 min: https://jenkins.koha-community[…]Koha_19.05_D8/84/
23:11 koha-jenkins Project Koha_19.05_U18 build #85: SUCCESS in 34 min: https://jenkins.koha-community[…]oha_19.05_U18/85/
23:42 kohaputti joined #koha
23:44 koha-jenkins Yippee, build fixed!
23:44 wahanui Congratulations!
23:44 koha-jenkins Project Koha_19.05_D9 build #85: FIXED in 39 min: https://jenkins.koha-community[…]Koha_19.05_D9/85/
23:44 koha-jenkins Project Koha_19.05_D8 build #85: UNSTABLE in 32 min: https://jenkins.koha-community[…]Koha_19.05_D8/85/
23:47 koha-jenkins Project Koha_19.05_U18 build #86: SUCCESS in 35 min: https://jenkins.koha-community[…]oha_19.05_U18/86/

| Channels | #koha index | Today | | Search | Google Search | Plain-Text | plain, newest first | summary