| Time |
S |
Nick |
Message |
| 00:19 |
|
|
valterbarreira[m] joined #koha |
| 00:38 |
|
|
JesseM joined #koha |
| 00:44 |
|
|
dpk__ joined #koha |
| 00:58 |
|
|
inlibro joined #koha |
| 01:51 |
|
mtompset |
Have a great day (24 hour period), #koha |
| 01:58 |
|
|
inlibro joined #koha |
| 02:23 |
|
|
irma_ joined #koha |
| 02:58 |
|
|
inlibro joined #koha |
| 03:58 |
|
|
inlibro joined #koha |
| 04:22 |
|
|
killer_bee[m] joined #koha |
| 04:22 |
|
|
tuxayo joined #koha |
| 04:22 |
|
|
SlackIntegration[m] joined #koha |
| 04:22 |
|
|
ashimema joined #koha |
| 04:49 |
|
|
fridolin joined #koha |
| 04:58 |
|
|
inlibro joined #koha |
| 05:57 |
|
|
cait joined #koha |
| 05:58 |
|
|
inlibro joined #koha |
| 06:21 |
|
|
josef_moravec left #koha |
| 06:21 |
|
|
Minna joined #koha |
| 06:26 |
|
|
reiveune joined #koha |
| 06:37 |
|
|
AndrewIsh joined #koha |
| 06:41 |
|
|
laurence joined #koha |
| 06:46 |
|
|
valterbarreira[m] joined #koha |
| 06:56 |
|
|
alex_a joined #koha |
| 06:57 |
|
alex_a |
bonjour |
| 06:57 |
|
wahanui |
bidet, alex_a |
| 06:59 |
|
|
inlibro joined #koha |
| 07:19 |
|
paxed |
has anyone gotten settings tags:true for any of the jquery select2 inputs in marc edit? |
| 07:20 |
|
paxed |
got working* |
| 07:20 |
|
|
cait joined #koha |
| 07:22 |
|
paxed |
this works $('input[id^="tag_651_subfield_2"]').select2({ tags: true }); ... EXCEPT if the field has authorized values. |
| 07:23 |
|
paxed |
... which isthe whole point of turning on tags for some inputs. |
| 07:31 |
|
|
kohaputti joined #koha |
| 07:37 |
|
paxed |
ohhhh, FFS. |
| 07:37 |
|
paxed |
because addbiblio.tt does not have input element for the field at all if there's an authorised value for it. |
| 07:38 |
|
paxed |
AAANND you cannot set tags for select2 if it's attached to a select element. |
| 07:38 |
|
paxed |
*headdesk* |
| 07:51 |
|
|
magnuse joined #koha |
| 07:59 |
|
|
inlibro joined #koha |
| 08:00 |
|
|
paul_p joined #koha |
| 08:17 |
|
cait |
fridolin: who is repsonsible for hea on biblibre's side? |
| 08:19 |
|
cait |
or someone else? alex_a, matts? |
| 08:19 |
|
matts |
hi cait |
| 08:19 |
|
matts |
Is there a problem with hea ? |
| 08:20 |
|
cait |
the map is broken for a month... Joubu fixed it, but it seems noone is reviewing the merge requests |
| 08:20 |
|
cait |
https://gitlab.com/koha-commun[…]/merge_requests/1 |
| 08:21 |
|
|
ashimema joined #koha |
| 08:21 |
|
ashimema |
https://gitlab.com/koha-commun[…]/merge_requests/1 matts |
| 08:21 |
|
cait |
and it needs to be put on the server too if it works... just looking to see who we can talk to? |
| 08:24 |
|
matts |
cait, I'm not sure actually |
| 08:24 |
|
cait |
matts: that's not good :) |
| 08:25 |
|
matts |
cait, I don't have rights on this repo. |
| 08:27 |
|
cait |
matts: how can we find out who canß |
| 08:27 |
|
cait |
? |
| 08:28 |
|
matts |
I'm looking into it |
| 08:29 |
|
cait |
thank you |
| 08:36 |
|
jajm |
cait, it looks like i have been given access to this repository one week ago (https://gitlab.com/koha-commun[…]/project_members), i'm not sure what i can do, but i cannot accept merge requests. It looks like only tcohen rangi and Joubu can |
| 08:37 |
|
ashimema |
lol |
| 08:37 |
|
cait |
oh my |
| 08:38 |
|
cait |
jajm: thx for checking |
| 08:38 |
|
cait |
are you the one to verfiy it works on the actual hea server? |
| 08:38 |
|
cait |
Joubu: tcohen? |
| 08:38 |
|
wahanui |
tcohen is probably the man you want to thank |
| 08:38 |
|
cait |
well... or ask this time |
| 08:47 |
|
|
magnuse joined #koha |
| 08:57 |
|
huginn` |
News from kohagit: Bug 21073: (QA follow-up) Fix typo in class name <http://git.koha-community.org/[…]9b429fe80f34d8283> |
| 08:59 |
|
|
inlibro joined #koha |
| 09:03 |
|
|
alex_a_ joined #koha |
| 09:08 |
|
|
BobB joined #koha |
| 09:18 |
|
|
alex_a joined #koha |
| 09:27 |
|
|
davidnind joined #koha |
| 09:27 |
|
koha-jenkins |
Yippee, build fixed! |
| 09:27 |
|
wahanui |
Congratulations! |
| 09:27 |
|
koha-jenkins |
Project Koha_Master_D9 build #772: FIXED in 28 min: https://jenkins.koha-community[…]ha_Master_D9/772/ |
| 09:36 |
|
koha-jenkins |
Project Koha_Master_U18 build #267: STILL UNSTABLE in 36 min: https://jenkins.koha-community[…]a_Master_U18/267/ |
| 09:41 |
|
koha-jenkins |
Yippee, build fixed! |
| 09:41 |
|
wahanui |
Congratulations! |
| 09:41 |
|
koha-jenkins |
Project Koha_Master_D8 build #284: FIXED in 43 min: https://jenkins.koha-community[…]ha_Master_D8/284/ |
| 09:59 |
|
|
inlibro joined #koha |
| 10:11 |
|
|
m23 joined #koha |
| 10:32 |
|
|
khall joined #koha |
| 10:35 |
|
|
davidnind left #koha |
| 10:38 |
|
|
laurence joined #koha |
| 10:47 |
|
koha-jenkins |
Project Koha_Master_U18 build #268: STILL UNSTABLE in 35 min: https://jenkins.koha-community[…]a_Master_U18/268/ |
| 10:48 |
|
ashimema |
hmm |
| 10:55 |
|
|
laurence left #koha |
| 10:59 |
|
|
inlibro joined #koha |
| 11:01 |
|
|
magnuse joined #koha |
| 11:04 |
|
|
killer_bee[m] joined #koha |
| 11:04 |
|
|
tuxayo joined #koha |
| 11:04 |
|
|
SlackIntegration[m] joined #koha |
| 11:23 |
|
koha-jenkins |
Project Koha_Master_U18 build #269: STILL UNSTABLE in 36 min: https://jenkins.koha-community[…]a_Master_U18/269/ |
| 11:28 |
|
kohaputti |
here is an easy & trivial patch to test if someone would like to sign-off: https://bugs.koha-community.or[…]_bug.cgi?id=23034 |
| 11:28 |
|
huginn` |
Bug 23034: minor, P5 - low, ---, joonas.kylmala, Needs Signoff , Warning when in Mana KB settings Auto subscription sharing is unchecked |
| 11:37 |
|
ashimema |
SO'd kohaputti |
| 11:37 |
|
kohaputti |
ashimema, thanks a lot :) |
| 11:37 |
|
ashimema |
have you looked at using git-bz kohaputti , it makes submissions a little easier |
| 11:38 |
|
ashimema |
https://wiki.koha-community.or[…]_bz_configuration |
| 11:38 |
|
kohaputti |
yes I have |
| 11:38 |
|
ashimema |
okies, :) |
| 11:38 |
|
kohaputti |
maybe some day I will get back at using it |
| 11:38 |
|
ashimema |
it's great if you're deving on one server.. if you're jumping around allot it's less helpful |
| 11:39 |
|
* ashimema |
wants to bring Norway back onboard with community more and more the next couple of cycles :) |
| 11:39 |
|
ashimema |
Sorry.. Finland |
| 11:39 |
|
ashimema |
fingers faster than brain there |
| 11:40 |
|
kohaputti |
yay, we are starting to focus on upstreaming in the upcoming fall |
| 11:40 |
|
ashimema |
remind me.. is the current koha fork most of you guys are using on github or somewhere publically visible? |
| 11:40 |
|
kohaputti |
there is 1000 commits not in upstream |
| 11:40 |
|
kohaputti |
it is here: http://github.com/kohasuomi/Koha |
| 11:40 |
|
ashimema |
at some point I'd love to compare and see what you've got that we haven't |
| 11:40 |
|
kohaputti |
AFAIK, all the libraries in Finland except 1 or 2 use that |
| 11:42 |
|
ashimema |
kivilahtio said he might be willing to help come up with a plan on how to merge lots back into upstream.. but I think he'd need to be contracted back to do so.. I've been meaning to reach out to ask if that's something you guys might want to try |
| 11:42 |
|
kohaputti |
ashimema, comparing will be easier when we get feature branches for all the patches |
| 11:42 |
|
kohaputti |
now there is one big branch with everything |
| 11:42 |
|
ashimema |
indeed |
| 11:42 |
|
ashimema |
are there plans to do that then? |
| 11:43 |
|
ashimema |
break out the features and prioritize them for submissions.. |
| 11:43 |
|
ashimema |
if there are drop me a line so we can collaborate on our side.. |
| 11:43 |
|
kohaputti |
ashimema, yes. The guys at Gotheburg uni did that, bywater solutions and so the feature branch way seem to be very efficient |
| 11:43 |
|
ashimema |
we'll obviously need to try and line of testing, SO and QA resources |
| 11:43 |
|
ashimema |
it's certainly the way to go |
| 11:46 |
|
|
alex_a joined #koha |
| 11:53 |
|
|
paul_p joined #koha |
| 11:53 |
|
|
oleonard joined #koha |
| 11:54 |
|
oleonard |
Hi all |
| 11:59 |
|
|
inlibro joined #koha |
| 12:07 |
|
|
fridolin joined #koha |
| 12:12 |
|
|
m23 joined #koha |
| 12:20 |
|
magnuse |
ashimema++ for pushing petter's first patch! |
| 12:24 |
|
huginn` |
News from kohagit: Bug 22653: DBRev 19.06.00.007 <http://git.koha-community.org/[…]13575734c72d0c58f> |
| 12:24 |
|
huginn` |
News from kohagit: Bug 22653: Remove unimplemented RotationPreventTransfers system preference <http://git.koha-community.org/[…]897f53b3b89b168b9> |
| 12:24 |
|
huginn` |
News from kohagit: Bug 23122: When searching callnumber in simple search, search option is not retained <http://git.koha-community.org/[…]42e336dc156b30a4a> |
| 12:24 |
|
huginn` |
News from kohagit: Bug 22851: Style navigation links in serials modules like same links in other modules <http://git.koha-community.org/[…]ba0c537e4cf6c5618> |
| 12:24 |
|
huginn` |
News from kohagit: Bug 23061: Add column/print/export feature on checkout history page <http://git.koha-community.org/[…]5dbb424a36d26be61> |
| 12:24 |
|
huginn` |
News from kohagit: Bug 22966: Add Norwegian library and patron names for installer <http://git.koha-community.org/[…]7ea3fbd3950a68bc7> |
| 12:28 |
|
cait |
nice stuff :) |
| 12:29 |
|
tcohen |
morning |
| 12:32 |
|
|
jraisa joined #koha |
| 12:47 |
|
|
caroline_catlady joined #koha |
| 12:48 |
|
* oleonard |
waves to awake people |
| 12:49 |
|
* eythian |
sleeps |
| 12:50 |
|
|
paul_p joined #koha |
| 12:50 |
|
caroline_catlady |
good morning everyone! |
| 12:51 |
|
oleonard |
Good morning caroline_catlady -- if that's even your real name?? |
| 12:51 |
|
caroline_catlady |
lol! |
| 12:55 |
|
koha-jenkins |
Project Koha_Master_U18 build #270: STILL UNSTABLE in 30 min: https://jenkins.koha-community[…]a_Master_U18/270/ |
| 12:55 |
|
* magnuse |
waves |
| 12:55 |
|
* magnuse |
waves louder |
| 12:56 |
|
caroline_catlady |
hehe! |
| 12:56 |
|
* magnuse |
wishes someone with more 1337 skillz would add a working example of how to use OAuth here: https://wiki.koha-community.or[…]the_Koha_REST_API |
| 13:00 |
|
|
inlibro joined #koha |
| 13:02 |
|
koha-jenkins |
Project Koha_Master_D9 build #773: UNSTABLE in 38 min: https://jenkins.koha-community[…]ha_Master_D9/773/ |
| 13:05 |
|
|
khall joined #koha |
| 13:06 |
|
|
wizzyrea joined #koha |
| 13:06 |
|
koha-jenkins |
Project Koha_Master_D8 build #285: SUCCESS in 43 min: https://jenkins.koha-community[…]ha_Master_D8/285/ |
| 13:11 |
|
|
wizzycray joined #koha |
| 13:15 |
|
|
wizzycray joined #koha |
| 13:42 |
|
|
cait left #koha |
| 13:44 |
|
koha-jenkins |
Project Koha_Master_D9 build #774: STILL UNSTABLE in 29 min: https://jenkins.koha-community[…]ha_Master_D9/774/ |
| 13:48 |
|
caroline_catlady |
lol! I kinda want to try fridolin's intranet theme, but at the same time, I'm afraid... |
| 13:50 |
|
fridolin |
^^ |
| 13:51 |
|
fridolin |
be cool, its safe buddy |
| 13:51 |
|
fridolin |
(new age sounds) |
| 13:51 |
|
caroline_catlady |
I'm not sure how to follow the instructions... I clicked download and changed the extension from zip to kpz |
| 13:51 |
|
caroline_catlady |
but when I upload it, it doesn't do anything |
| 13:51 |
|
fridolin |
whoooo i see a grey elephant |
| 13:52 |
|
fridolin |
caroline_catlady: ah do you see it in plugins list ? |
| 13:52 |
|
caroline_catlady |
Is there a minimum version? |
| 13:52 |
|
fridolin |
17.11.11 |
| 13:52 |
|
caroline_catlady |
ok I tried on 18.05 so it should be ok |
| 13:52 |
|
fridolin |
you may do ctrl+F5 |
| 13:52 |
|
fridolin |
its CSS rules |
| 13:52 |
|
caroline_catlady |
no I don't see it in the plugin lists, that's the problem |
| 13:53 |
|
fridolin |
starman memcached restart , |
| 13:53 |
|
fridolin |
? |
| 13:53 |
|
tcohen |
systemctl restart memcached koha-common apache2 |
| 13:53 |
|
fridolin |
we are on https://github.com/biblibre/ko[…]heme-intranet-lsd |
| 13:54 |
|
fridolin |
because plugins are perl code |
| 13:54 |
|
tcohen |
ah, reload plack so it refreshes the libs |
| 13:54 |
|
|
lukeG1 joined #koha |
| 13:55 |
|
caroline_catlady |
I restarted plack, still not in the list |
| 13:55 |
|
caroline_catlady |
But I didn't do the command in the read me, I just clicked download, is that ok? |
| 13:57 |
|
|
magnuse joined #koha |
| 13:58 |
|
ashimema |
nope |
| 13:58 |
|
ashimema |
you need /Koha at the top level of your zip file |
| 14:00 |
|
caroline_catlady |
ah! it worked! thx ashimema++ |
| 14:00 |
|
|
inlibro joined #koha |
| 14:00 |
|
ashimema |
you beat me to it. |
| 14:01 |
|
fridolin |
ah i add this commande line from another place |
| 14:01 |
|
fridolin |
i check |
| 14:02 |
|
ashimema |
ah.. my eyes.. my eyes.. it' burns |
| 14:02 |
|
ashimema |
random question |
| 14:02 |
|
ashimema |
on master.. the 'DISABLED' label on plugins |
| 14:02 |
|
ashimema |
is that always disabled for all of them for everyone? |
| 14:02 |
|
kidclamp |
I have an enabled plugin |
| 14:03 |
|
caroline_catlady |
I don't see it :( |
| 14:03 |
|
ashimema |
oh.. |
| 14:03 |
|
ashimema |
I have some enabled.. but that show as disabled |
| 14:04 |
|
ashimema |
ahh.. now I can't disable it |
| 14:04 |
|
fridolin |
caroline_catlady: ah indeed, you have to create the path : Koha/Plugin/Com/BibLibre/ThemeIntranetLsd.pm |
| 14:04 |
|
fridolin |
because the plugin is a perl module with package |
| 14:07 |
|
caroline_catlady |
there must be something I don't understand because it's not working |
| 14:07 |
|
caroline_catlady |
you're all talking developer to me, but I don't speak that language :( |
| 14:09 |
|
ashimema |
https://drive.google.com/file/[…]/view?usp=sharing |
| 14:09 |
|
ashimema |
have my kpz caroline_catlady |
| 14:09 |
|
ashimema |
it's just frido's plugin packaged for you |
| 14:10 |
|
* ashimema |
wonders if the current rmaints are reading release notes ready for their respective releases yet |
| 14:11 |
|
ashimema |
or delegating the task out perhaps ;) |
| 14:11 |
|
ashimema |
rmaints? |
| 14:11 |
|
wahanui |
i think rmaints is fridolin, lucas and wizzyrea |
| 14:11 |
|
fridolin |
yep |
| 14:11 |
|
ashimema |
:) |
| 14:12 |
|
fridolin |
is there a release planning ? |
| 14:12 |
|
fridolin |
for this month |
| 14:13 |
|
ashimema |
huh? |
| 14:15 |
|
|
m23 joined #koha |
| 14:19 |
|
ashimema |
did you just get my PM fridolin |
| 14:21 |
|
|
wizzycray joined #koha |
| 14:38 |
|
|
mtompset joined #koha |
| 14:38 |
|
mtompset |
Greetings, #koha. |
| 14:38 |
|
mtompset |
@seen Joubu |
| 14:38 |
|
huginn` |
mtompset: Joubu was last seen in #koha 6 days, 23 hours, 53 minutes, and 48 seconds ago: <Joubu> yes |
| 14:42 |
|
|
wizzyrea joined #koha |
| 14:43 |
|
mtompset |
greetings, wizzyrea |
| 14:44 |
|
ashimema |
he's around ;) |
| 14:45 |
|
Joubu |
hi mtompset, #koha |
| 14:53 |
|
wizzyrea |
hi :) |
| 14:53 |
|
wizzyrea |
how we doin |
| 14:55 |
|
eythian |
Well, I saw a band play last night that when I first saw them must have been almost exactly 19 years ago. |
| 14:56 |
|
oleonard |
eythian: The Spin Doctors?? |
| 14:57 |
|
eythian |
oleonard: you were there?! |
| 14:58 |
|
* oleonard |
shows off his whimsical jester's hat |
| 15:00 |
|
eythian |
That guy. Wearing a tall hat at a concert. |
| 15:00 |
|
|
inlibro joined #koha |
| 15:00 |
|
oleonard |
But look how whimsical |
| 15:06 |
|
|
wizzyrea joined #koha |
| 15:07 |
|
reiveune |
bye |
| 15:07 |
|
|
reiveune left #koha |
| 15:08 |
|
Joubu |
mtompset: I do not understand what you did on bug 23151, tests are still failing |
| 15:09 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=23151 blocker, P5 - low, ---, mtompset, Signed Off , Patron self modification sends null dateofbirth |
| 15:16 |
|
|
wizzyrea joined #koha |
| 15:37 |
|
mtompset |
I cleaned up my == issues... |
| 15:37 |
|
mtompset |
I'm working on another idea, Joubu |
| 15:37 |
|
mtompset |
putting a changed_fields field into the modification table. |
| 15:37 |
|
mtompset |
So we can tell the difference between a null (not set) and null (actual value) |
| 15:38 |
|
mtompset |
That will avoid the dummy_value. |
| 15:38 |
|
|
edveal joined #koha |
| 15:38 |
|
Joubu |
the upgrade will be tricky, and we need a quick patch to fix stable |
| 15:39 |
|
Joubu |
but that could be a good idea for master |
| 15:41 |
|
|
fridolin left #koha |
| 15:45 |
|
tcohen |
Joubu: around? |
| 15:45 |
|
Joubu |
yes |
| 15:46 |
|
tcohen |
about SQL12 |
| 15:46 |
|
tcohen |
are you willing to work on the koha-qa.pl checks? |
| 15:46 |
|
tcohen |
if such was the case |
| 15:46 |
|
tcohen |
maybe you should check if BOOLEAN helps detect things |
| 15:47 |
|
Joubu |
BOOLEAN must be forbidden from kohastructure.sql, it's an easy check at first glance |
| 15:49 |
|
|
AvengingChicken joined #koha |
| 16:00 |
|
|
inlibro joined #koha |
| 16:15 |
|
Joubu |
mtompset: could you upadte bug 23151's status to avoid unecessary work on SO? |
| 16:15 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=23151 blocker, P5 - low, ---, mtompset, Signed Off , Patron self modification sends null dateofbirth |
| 16:18 |
|
* ashimema |
wonders if he missed a case fo SQL12 now |
| 16:20 |
|
ashimema |
there are still a few in kohastructure.. should we create a bug to ensure they're all caught and changed tcohen? |
| 16:22 |
|
ashimema |
boo.. I did let one through |
| 16:22 |
|
ashimema |
bug 9834 |
| 16:22 |
|
huginn` |
Bug http://bugs.koha-community.org[…]w_bug.cgi?id=9834 normal, P5 - low, ---, jonathan.druart, Pushed to Master , Reverting a waiting hold should lead to the former hold type (item or biblio level) |
| 16:22 |
|
ashimema |
also let a spelling error creep through i that one.. grr |
| 16:22 |
|
ashimema |
bad RM, bad RM |
| 16:23 |
|
Joubu |
see bug 23133, there is a follow-up for that |
| 16:23 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=23133 enhancement, P5 - low, ---, tomascohen, Needs Signoff , Rename reserves.item_level_hold for reserves.item_level |
| 16:24 |
|
Joubu |
not you, that's why I asked tcohen if we should not fix them all then have a test to catch future regressions |
| 16:25 |
|
ashimema |
:D |
| 16:25 |
|
|
lisettelatah joined #koha |
| 16:30 |
|
ashimema |
Do we prescribe to an SQL- standard.. I know we're trying to get rid of as many mysql'isms as we can but ... |
| 16:34 |
|
|
wizzycray joined #koha |
| 16:36 |
|
oleonard |
wizzyrea: Connection problems today? We've got a checkout for that: https://search.myacpl.org/cgi-[…]blionumber=592625 |
| 16:38 |
|
mtompset |
Joubu, I don't understand... I've just pushed up my tweaks. |
| 16:39 |
|
* oleonard |
never thought people would be so pissed off by Bug 20044 |
| 16:39 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20044 enhancement, P5 - low, ---, oleonard, RESOLVED FIXED, Switch single-column templates to Bootstrap grid: Cataloging |
| 16:39 |
|
* mtompset |
agrees about avoiding boolean in kohastructure.sql -- boolean is not ANSI, and MySQL maps it to TinyInt. :) |
| 16:40 |
|
ashimema |
boolean is mentioned in sql-99.. but seems many db's didn't bother to implement it.. or implemented it differently |
| 16:40 |
|
mtompset |
DOH! That's what you meant. |
| 16:40 |
|
ashimema |
seems lots of people suggest using bit(1) for bools.. postgres and mysql both support that |
| 16:41 |
|
* ashimema |
isn't sure what oleonard means by his bug 20044 comment |
| 16:42 |
|
oleonard |
ashimema: Read the comments on Bug 23147 :( |
| 16:42 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=23147 trivial, P5 - low, ---, oleonard, NEW , changes made by bug 20044 to addbiblio.pl causing issues for some catalogers |
| 16:43 |
|
ashimema |
yikes |
| 16:43 |
|
* ashimema |
can't remember what it looked like before |
| 16:46 |
|
* ashimema |
sits and looks at the two screenshots in bug 20044 and the rant screenshot in bug 23147 |
| 16:46 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=20044 enhancement, P5 - low, ---, oleonard, RESOLVED FIXED, Switch single-column templates to Bootstrap grid: Cataloging |
| 16:46 |
|
ashimema |
mwah |
| 16:47 |
|
mtompset |
"Microsoft SQL Server is one of the few database systems that properly supports BOOLEAN values using its "BIT" data type" (https://en.wikipedia.org/wiki/SQL:1999#Data_types) -- You know it is bad when Microsoft gets it right. |
| 16:48 |
|
* ashimema |
was just reading that page.. haha |
| 17:00 |
|
|
inlibro joined #koha |
| 17:19 |
|
lukeG1 |
oleonard++ |
| 17:24 |
|
|
hizzycray joined #koha |
| 17:34 |
|
mtompset |
is the Template Toolkit filter suppose to be $raw or raw? |
| 17:34 |
|
mtompset |
or is either okay? |
| 17:35 |
|
Joubu |
$raw |
| 17:35 |
|
|
lukeG joined #koha |
| 17:35 |
|
mtompset |
Thanks, Joubu |
| 17:37 |
|
mtompset |
I'm looking back at 23042. |
| 17:40 |
|
|
wizzycray joined #koha |
| 17:42 |
|
oleonard |
Thanks lukeG |
| 17:44 |
|
mtompset |
Sorry about not changing the status, lukeG |
| 17:45 |
|
mtompset |
Joubu, the modify database structure has a .perl for the atomic update. |
| 17:45 |
|
mtompset |
bug 23151. |
| 17:45 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=23151 blocker, P5 - low, ---, mtompset, Failed QA , Patron self modification sends null dateofbirth |
| 17:46 |
|
Joubu |
ho, did not see that patch!! |
| 17:46 |
|
Joubu |
the new column still need to be populated, right? |
| 17:47 |
|
mtompset |
It gets populated when opac/opac-memberentry is done. |
| 17:47 |
|
mtompset |
It's part of the Koha/Patron/... can't remember s or not. |
| 17:49 |
|
mtompset |
Nop... opac-memberentry sets the hash value. :) |
| 17:51 |
|
mtompset |
Hmmm... triggered some thoughts... |
| 17:52 |
|
mtompset |
need to check another test. |
| 17:56 |
|
mtompset |
*whew* template toolkit test of letters doesn't fail. :) |
| 17:58 |
|
|
lukeG joined #koha |
| 17:59 |
|
tcohen |
Joubu: bug 23164 |
| 17:59 |
|
huginn` |
Bug http://bugs.koha-community.org[…]_bug.cgi?id=23164 normal, P5 - low, ---, chris, NEW , Add a way to unmock preferences and config entries |
| 18:00 |
|
tcohen |
^^ that'd be interesting |
| 18:00 |
|
|
inlibro joined #koha |
| 18:02 |
|
Joubu |
tcohen: what would be a use case? |
| 18:06 |
|
tcohen |
DESTROY { do_something_with_clean_env() } |
| 18:07 |
|
|
lukeG joined #koha |
| 18:08 |
|
tcohen |
does it make sense? |
| 18:08 |
|
Joubu |
I do not understand |
| 18:09 |
|
* mtompset |
doesn't understand either, and I'm just listening. |
| 18:09 |
|
mtompset |
Though, I do like the idea of OO'ing it. |
| 18:12 |
|
mtompset |
It would be nice to be explicit with an unmock_config([optional, where nothing means unmock_all]), etc. |
| 18:13 |
|
tcohen |
Joubu, mtompset: I'll try to explain |
| 18:13 |
|
tcohen |
we cannot control what plugins do |
| 18:13 |
|
tcohen |
particularly, they don't share the database handler with the calling code |
| 18:14 |
|
tcohen |
so tests that relate to plugins, not leave cruft on the DB |
| 18:14 |
|
tcohen |
if we were able to unmock config |
| 18:14 |
|
tcohen |
we could call $plugins->InstallPlugins, to restore the previous status |
| 18:16 |
|
Joubu |
tests for a plugin should be provided by the plugin, do not you think? |
| 18:18 |
|
tcohen |
well, we are not testing the plugins, but things like '$plugin->disable makes $plugin->is_enabled return false' |
| 18:18 |
|
mtompset |
Are you saying that plug in tests are currently leaving cruft? |
| 18:18 |
|
tcohen |
mtompset: yes! |
| 18:19 |
|
mtompset |
oh... plugins aren't playing nice with either other? |
| 18:21 |
|
Joubu |
Koha tests should use a sample plugin (Koha::Plugin::Test), not the ones that are installed |
| 18:22 |
|
tcohen |
Joubu: exactly |
| 18:22 |
|
tcohen |
they do that |
| 18:22 |
|
tcohen |
BUT |
| 18:22 |
|
tcohen |
we need to call InstallPlugins now |
| 18:22 |
|
tcohen |
which will re-populate the plugin_methods table |
| 18:22 |
|
tcohen |
and after tests are run |
| 18:23 |
|
tcohen |
we want to call it again to restore the 'really installed ones' |
| 18:24 |
|
Joubu |
I don't understand where the problem is, do you have a patch to recreate the issue? |
| 18:25 |
|
Joubu |
from Koha tests you mock GetPlugins and so you will only use Koha::Plugin::Test. You are in a transaction, you rollback and you are done |
| 18:26 |
|
Joubu |
(and don't shout at me) |
| 18:29 |
|
tcohen |
prove t/db_dependent/Plugins.t |
| 18:29 |
|
* mtompset |
wonders where the shouting was. |
| 18:32 |
|
|
lukeG1 joined #koha |
| 18:42 |
|
ashimema |
This is the issue I was asking about this message morning before I pushed the patch that highlights it. |
| 18:43 |
|
* ashimema |
goes back to lurk mode and hugs the wife |
| 18:44 |
|
tcohen |
ashimema: I submitted a fix for the failing tests on 21073 |
| 18:44 |
|
tcohen |
wasn't sure where you wanted it |
| 18:48 |
|
ashimema |
Thanks dude |
| 19:01 |
|
|
inlibro joined #koha |
| 19:05 |
|
tcohen |
bye all! |
| 19:22 |
|
mtompset |
And now I see why you are talking about cruft and calling InstallPlugins. |
| 19:45 |
|
|
davidnind joined #koha |
| 19:48 |
|
koha-jenkins |
Project Koha_18.11_U18 build #102: SUCCESS in 27 min: https://jenkins.koha-community[…]ha_18.11_U18/102/ |
| 19:55 |
|
koha-jenkins |
Project Koha_18.11_D9 build #108: SUCCESS in 31 min: https://jenkins.koha-community[…]oha_18.11_D9/108/ |
| 19:59 |
|
koha-jenkins |
Yippee, build fixed! |
| 19:59 |
|
wahanui |
Congratulations! |
| 19:59 |
|
koha-jenkins |
Project Koha_18.11_D8 build #107: FIXED in 39 min: https://jenkins.koha-community[…]oha_18.11_D8/107/ |
| 20:01 |
|
|
inlibro joined #koha |
| 20:15 |
|
koha-jenkins |
Project Koha_18.11_U18 build #103: SUCCESS in 26 min: https://jenkins.koha-community[…]ha_18.11_U18/103/ |
| 20:31 |
|
|
kathryn joined #koha |
| 20:32 |
|
|
lukeG joined #koha |
| 20:38 |
|
koha-jenkins |
Project Koha_18.11_D8 build #108: SUCCESS in 39 min: https://jenkins.koha-community[…]oha_18.11_D8/108/ |
| 20:55 |
|
|
cait joined #koha |
| 20:56 |
|
|
alexbuckley joined #koha |
| 21:01 |
|
|
inlibro joined #koha |
| 21:03 |
|
|
davidnind left #koha |
| 21:17 |
|
|
khall joined #koha |
| 21:18 |
|
|
khall joined #koha |
| 21:29 |
|
|
kathryn joined #koha |
| 21:53 |
|
caroline_catlady |
good night everyone! |
| 21:56 |
|
|
khall joined #koha |
| 22:00 |
|
|
khall joined #koha |
| 22:01 |
|
|
inlibro joined #koha |
| 22:41 |
|
|
khall joined #koha |
| 22:43 |
|
|
khall joined #koha |
| 22:57 |
|
|
aleisha joined #koha |
| 23:01 |
|
|
inlibro joined #koha |
| 23:22 |
|
|
khall joined #koha |
| 23:37 |
|
|
papa joined #koha |
| 23:46 |
|
|
rangi joined #koha |
